Issues in RemoteMethodCallParser.php (master) - Issues in master - appserver-io/rmi - Measure and Improve Code Quality continuously with Scrutinizer

Issues (18)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

RemoteMethodInvocation/RemoteMethodCallParser.php (5 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/**
 * AppserverIo\PersistenceContainerClient\RemoteMethodCallParser
 *
 * NOTICE OF LICENSE
 *
 * This source file is subject to the Open Software License (OSL 3.0)
 * that is available through the world-wide-web at this URL:
 * http://opensource.org/licenses/osl-3.0.php
 *
 * PHP version 5
 *
 * @author    Tim Wagner <[email protected]>
 * @copyright 2015 TechDivision GmbH <[email protected]>
 * @license   http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
 * @link      https://github.com/appserver-io/rmi
 * @link      http://www.appserver.io
 */

namespace AppserverIo\RemoteMethodInvocation;

use AppserverIo\Psr\Socket\SocketInterface;

/**
 * This is a parser for a native persistence container remote method call.
 *
 * A Remote method call must have the following format:
 *
 * <METHOD> <CONTENT-LENGTH> <PROTOCOL>/<VERSION>\r\n
 * <CONTENT>
 *
 * for example:
 *
 * INVOKE 12 RMC/1.0
 * czoxOiIxIjs=
 *
 * @author    Tim Wagner <[email protected]>
 * @copyright 2015 TechDivision GmbH <[email protected]>
 * @license   http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
 * @link      https://github.com/appserver-io/rmi
 * @link      http://www.appserver.io
 */
class RemoteMethodCallParser
{

    /**
     * Parses the header of a remote method call.
     *
     * @param string $line The header line to parse
     *
     * @return integer The content length to parse
     * @throws \AppserverIo\RemoteMethodInvocation\RemoteMethodCallException
     */
    public function parseHeader($line)
    {

        // parse the header line with
        list ($remoteMethod, $contentLength, $protocolVersion) = explode(' ', trim($line));

        // parse protocol and version
        list ($protocol, $version) = explode('/', $protocolVersion);

        // check if protocol and version are valid
        if ($protocol !== RemoteMethodProtocol::PROTOCOL && $version !== RemoteMethodProtocol::VERSION) {
            throw new RemoteMethodCallException(sprintf('Protocol %s not supported', $protocolVersion));
        }

        // check the request method
        switch ($remoteMethod) {


            case RemoteMethodProtocol::REMOTE_METHOD_INVOKE:
                return (integer) $contentLength;
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}

            case RemoteMethodProtocol::REMOTE_METHOD_RESULT:
                return (integer) $contentLength;
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}

            default:
                throw new RemoteMethodCallException(sprintf('Found invalid remote method %s', $remoteMethod));
                break;
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}


        }
    }

    /**
     * Parses the request body and tries to unpack the remote method
     * instance from it.
     *
     * @param \AppserverIo\Psr\Socket\SocketInterface $connection    The package remote method instance
     * @param integer                                 $contentLength The content length to read
     *
     * @return object The unpacked remote method object/result
     */
    public function parseBody(SocketInterface $connection, $contentLength)
    {
        $rawResponse = stream_get_contents($connection->getConnectionResource(), $contentLength);
        return RemoteMethodProtocol::unpack($rawResponse);
    }
}


1			<?php
2
3			/**
4			* AppserverIo\PersistenceContainerClient\RemoteMethodCallParser
5			*
6			* NOTICE OF LICENSE
7			*
8			* This source file is subject to the Open Software License (OSL 3.0)
9			* that is available through the world-wide-web at this URL:
10			* http://opensource.org/licenses/osl-3.0.php
11			*
12			* PHP version 5
13			*
14			* @author Tim Wagner <[email protected]>
15			* @copyright 2015 TechDivision GmbH <[email protected]>
16			* @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
17			* @link https://github.com/appserver-io/rmi
18			* @link http://www.appserver.io
19			*/
20
21			namespace AppserverIo\RemoteMethodInvocation;
22
23			use AppserverIo\Psr\Socket\SocketInterface;
24
25			/**
26			* This is a parser for a native persistence container remote method call.
27			*
28			* A Remote method call must have the following format:
29			*
30			* <METHOD> <CONTENT-LENGTH> <PROTOCOL>/<VERSION>\r\n
31			* <CONTENT>
32			*
33			* for example:
34			*
35			* INVOKE 12 RMC/1.0
36			* czoxOiIxIjs=
37			*
38			* @author Tim Wagner <[email protected]>
39			* @copyright 2015 TechDivision GmbH <[email protected]>
40			* @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
41			* @link https://github.com/appserver-io/rmi
42			* @link http://www.appserver.io
43			*/
44			class RemoteMethodCallParser
45			{
46
47			/**
48			* Parses the header of a remote method call.
49			*
50			* @param string $line The header line to parse
51			*
52			* @return integer The content length to parse
53			* @throws \AppserverIo\RemoteMethodInvocation\RemoteMethodCallException
54			*/
55			public function parseHeader($line)
56			{
57
58			// parse the header line with
59			list ($remoteMethod, $contentLength, $protocolVersion) = explode(' ', trim($line));
60
61			// parse protocol and version
62			list ($protocol, $version) = explode('/', $protocolVersion);
63
64			// check if protocol and version are valid
65			if ($protocol !== RemoteMethodProtocol::PROTOCOL && $version !== RemoteMethodProtocol::VERSION) {
66			throw new RemoteMethodCallException(sprintf('Protocol %s not supported', $protocolVersion));
67			}
68
69			// check the request method
70			switch ($remoteMethod) {
			0 ignored issues – show Coding Style introduced 2016-03-16 15:35 UTC by Report Bug Copy Issue Report Show Similar Issues like this Blank line found at start of control structure Loading history...
71
72			case RemoteMethodProtocol::REMOTE_METHOD_INVOKE:
73			return (integer) $contentLength;
74			break;
			0 ignored issues – show Unused Code introduced 2015-12-21 13:46 UTC by Report Bug Copy Issue Report Show Similar Issues like this `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
75
76			case RemoteMethodProtocol::REMOTE_METHOD_RESULT:
77			return (integer) $contentLength;
78			break;
			0 ignored issues – show Unused Code introduced 2015-12-21 13:46 UTC by Report Bug Copy Issue Report Show Similar Issues like this `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
79
80			default:
81			throw new RemoteMethodCallException(sprintf('Found invalid remote method %s', $remoteMethod));
82			break;
			0 ignored issues – show Unused Code introduced 2015-12-21 13:46 UTC by Report Bug Copy Issue Report Show Similar Issues like this `break;` does not seem to be reachable. This check looks for unreachable code. It uses sophisticated control flow analysis techniques to find statements which will never be executed. Unreachable code is most often the result of `return`, `die` or `exit` statements that have been added for debug purposes. function fx() { try { doSomething(); return true; } catch (\Exception $e) { return false; } return false; } In the above example, the last `return false` will never be executed, because a return statement has already been met in every possible execution path. Loading history...
83
			0 ignored issues – show Coding Style introduced 2016-03-16 15:35 UTC by Report Bug Copy Issue Report Show Similar Issues like this Blank line found at end of control structure Loading history...
84			}
85			}
86
87			/**
88			* Parses the request body and tries to unpack the remote method
89			* instance from it.
90			*
91			* @param \AppserverIo\Psr\Socket\SocketInterface $connection The package remote method instance
92			* @param integer $contentLength The content length to read
93			*
94			* @return object The unpacked remote method object/result
95			*/
96			public function parseBody(SocketInterface $connection, $contentLength)
97			{
98			$rawResponse = stream_get_contents($connection->getConnectionResource(), $contentLength);
99			return RemoteMethodProtocol::unpack($rawResponse);
100			}
101			}
102

appserver-io / rmi

Issues (18)

Security Analysis no request data

RemoteMethodInvocation/RemoteMethodCallParser.php (5 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like