Issues in QueueSession.php (master) - Issues in master - appserver-io/messaging - Measure and Improve Code Quality continuously with Scrutinizer

Issues (23)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/AppserverIo/Messaging/QueueSession.php (1 issue)

Labels

Bug 1

Severity

Major 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/**
 * AppserverIo\Messaging\QueueSession
 *
 * NOTICE OF LICENSE
 *
 * This source file is subject to the Open Software License (OSL 3.0)
 * that is available through the world-wide-web at this URL:
 * http://opensource.org/licenses/osl-3.0.php
 *
 * PHP version 5
 *
 * @author    Tim Wagner <[email protected]>
 * @copyright 2015 TechDivision GmbH <[email protected]>
 * @license   http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
 * @link      https://github.com/appserver-io/messaging
 * @link      http://www.appserver.io
 */

namespace AppserverIo\Messaging;

use AppserverIo\Psr\Pms\QueueInterface;
use AppserverIo\Psr\Pms\MessageInterface;

/**
 * The queue session implementation.
 *
 * @author    Tim Wagner <[email protected]>
 * @copyright 2015 TechDivision GmbH <[email protected]>
 * @license   http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
 * @link      https://github.com/appserver-io/messaging
 * @link      http://www.appserver.io
 */
class QueueSession
{

    /**
     * Holds the QueueConnection instance to use for the server connect.
     *
     * @var \AppserverIo\Messaging\QueueConnection
     */
    protected $connection = null;

    /**
     * Holds the unique session id.
     *
     * @var string
     */
    protected $id = null;

    /**
     * Initializes the session with the QueueConnection instance
     * to use for the server connection.
     *
     * @param \AppserverIo\Messaging\QueueConnection $connection Holds the QueueConnection instance to use
     */
    public function __construct(QueueConnection $connection)
    {
        // initialize the internal connection
        $this->connection = $connection;
        // generate and return the unique session id
        return $this->id = md5(uniqid(rand(), true));

    }

    /**
     * Sends the passed Message instance to the server,
     * using the QueueConnection instance.
     *
     * @param \AppserverIo\Psr\Pms\MessageInterface $message          The message to send
     * @param boolean                               $validateResponse If this flag is true, the QueueConnection waits for the MessageQueue response and validates it
     *
     * @return \AppserverIo\Messaging\QueueResponse The response of the MessageQueue, or null
     */
    public function send(MessageInterface $message, $validateResponse)
    {
        return $this->connection->send($message, $validateResponse);
    }

    /**
     * Creates and returns a new QueueSender instance for sending
     * the Message to the server.
     *
     * @param \AppserverIo\Psr\Pms\QueueInterface $queue the Queue instance to use for sending the message
     *
     * @return \AppserverIo\Messaging\QueueSender The initialized QueueSender instance
     */
    public function createSender(QueueInterface $queue)
    {
        return new QueueSender($this, $queue);
    }

    /**
     * Returns the session id.
     *
     * @return string The unique id
     */
    public function getId()
    {
        return $this->id;
    }
}


1			<?php
2
3			/**
4			* AppserverIo\Messaging\QueueSession
5			*
6			* NOTICE OF LICENSE
7			*
8			* This source file is subject to the Open Software License (OSL 3.0)
9			* that is available through the world-wide-web at this URL:
10			* http://opensource.org/licenses/osl-3.0.php
11			*
12			* PHP version 5
13			*
14			* @author Tim Wagner <[email protected]>
15			* @copyright 2015 TechDivision GmbH <[email protected]>
16			* @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
17			* @link https://github.com/appserver-io/messaging
18			* @link http://www.appserver.io
19			*/
20
21			namespace AppserverIo\Messaging;
22
23			use AppserverIo\Psr\Pms\QueueInterface;
24			use AppserverIo\Psr\Pms\MessageInterface;
25
26			/**
27			* The queue session implementation.
28			*
29			* @author Tim Wagner <[email protected]>
30			* @copyright 2015 TechDivision GmbH <[email protected]>
31			* @license http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
32			* @link https://github.com/appserver-io/messaging
33			* @link http://www.appserver.io
34			*/
35			class QueueSession
36			{
37
38			/**
39			* Holds the QueueConnection instance to use for the server connect.
40			*
41			* @var \AppserverIo\Messaging\QueueConnection
42			*/
43			protected $connection = null;
44
45			/**
46			* Holds the unique session id.
47			*
48			* @var string
49			*/
50			protected $id = null;
51
52			/**
53			* Initializes the session with the QueueConnection instance
54			* to use for the server connection.
55			*
56			* @param \AppserverIo\Messaging\QueueConnection $connection Holds the QueueConnection instance to use
57			*/
58			public function __construct(QueueConnection $connection)
59			{
60			// initialize the internal connection
61			$this->connection = $connection;
62			// generate and return the unique session id
63			return $this->id = md5(uniqid(rand(), true));
			0 ignored issues – show Bug introduced 2016-03-14 13:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this Constructors do not have meaningful return values, anything that is returned from here is discarded. Are you sure this is correct? Loading history...
64			}
65
66			/**
67			* Sends the passed Message instance to the server,
68			* using the QueueConnection instance.
69			*
70			* @param \AppserverIo\Psr\Pms\MessageInterface $message The message to send
71			* @param boolean $validateResponse If this flag is true, the QueueConnection waits for the MessageQueue response and validates it
72			*
73			* @return \AppserverIo\Messaging\QueueResponse The response of the MessageQueue, or null
74			*/
75			public function send(MessageInterface $message, $validateResponse)
76			{
77			return $this->connection->send($message, $validateResponse);
78			}
79
80			/**
81			* Creates and returns a new QueueSender instance for sending
82			* the Message to the server.
83			*
84			* @param \AppserverIo\Psr\Pms\QueueInterface $queue the Queue instance to use for sending the message
85			*
86			* @return \AppserverIo\Messaging\QueueSender The initialized QueueSender instance
87			*/
88			public function createSender(QueueInterface $queue)
89			{
90			return new QueueSender($this, $queue);
91			}
92
93			/**
94			* Returns the session id.
95			*
96			* @return string The unique id
97			*/
98			public function getId()
99			{
100			return $this->id;
101			}
102			}
103

appserver-io / messaging

Issues (23)

Security Analysis no request data

src/AppserverIo/Messaging/QueueSession.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like