AppserverIo\Doppelgaenger\StreamFilters\InvariantFilter::filterChunk()

Complexity

Conditions	7
Paths	15

Size

Total Lines	95
Code Lines	50

Duplication

Lines	34
Ratio	35.79 %

Importance

Changes

0

<?php
    public function filterChunk($chunk, StructureDefinitionInterface $structureDefinition)
    {
        // After iterate over the attributes and build up our array of attributes we have to include in our
        // checking mechanism.
        $obsoleteProperties = array();
        $propertyReplacements = array();
        $iterator = $structureDefinition->getAttributeDefinitions()->getIterator();

It seems like you code against a concrete implementation and not the interface AppserverIo\Doppelgaenger\Interfaces\StructureDefinitionInterface as the method getAttributeDefinitions() does only exist in the following implementations of said interface: AppserverIo\Doppelgaenger\Entities\Definitions\AspectDefinition, AppserverIo\Doppelgaenger\Entities\Definitions\ClassDefinition, AppserverIo\Doppelgaenger\Entities\Definitions\TraitDefinition.

        for ($i = 0; $i < $iterator->count(); $i++) {
            // Get the current attribute for more easy access
            $attribute = $iterator->current();

            // Only enter the attribute if it is used in an invariant and it is not private
            if ($attribute->inInvariant() && $attribute->getVisibility() !== 'private') {
                // Build up our regex expression to filter them out
                $obsoleteProperties[] = '/' . $attribute->getVisibility() . '.*?\\' . $attribute->getName() . '/';
                $propertyReplacements[] = 'private ' . $attribute->getName();
            }

            // Move the iterator
            $iterator->next();
        }

        // Get our buckets from the stream
        $functionHook = '';
        // We only have to do that once!
        if (empty($functionHook)) {
            $functionHook = Placeholders::STRUCTURE_END;

            // Get the code for our attribute storage
            $attributeCode = $this->generateAttributeCode($structureDefinition->getAttributeDefinitions());

It seems like you code against a concrete implementation and not the interface AppserverIo\Doppelgaenger\Interfaces\StructureDefinitionInterface as the method getAttributeDefinitions() does only exist in the following implementations of said interface: AppserverIo\Doppelgaenger\Entities\Definitions\AspectDefinition, AppserverIo\Doppelgaenger\Entities\Definitions\ClassDefinition, AppserverIo\Doppelgaenger\Entities\Definitions\TraitDefinition.

            // Get the code for the assertions
            $code = $this->generateFunctionCode($structureDefinition->getInvariants());

            // Insert the code
            $chunk = str_replace(
                array(
                    $functionHook,
                    $functionHook
                ),
                array(
                    $functionHook . $attributeCode,
                    $functionHook . $code
                ),
                $chunk
            );

            // Determine if we need the __set method to be injected
            if ($structureDefinition->getFunctionDefinitions()->entryExists('__set')) {

This code seems to be duplicated across your project.

                // Get the code for our __set() method
                $setCode = $this->generateSetCode($structureDefinition->hasParents(), true);
                $chunk = str_replace(
                    Placeholders::METHOD_INJECT . '__set' . Placeholders::PLACEHOLDER_CLOSE,
                    $setCode,
                    $chunk
                );

Blank line found at end of control structure

            } else {
                $setCode = $this->generateSetCode($structureDefinition->hasParents());
                $chunk = str_replace(
                    $functionHook,
                    $functionHook . $setCode,
                    $chunk
                );
            }

            // Determine if we need the __get method to be injected
            if ($structureDefinition->getFunctionDefinitions()->entryExists('__get')) {

This code seems to be duplicated across your project.

                // Get the code for our __set() method
                $getCode = $this->generateGetCode($structureDefinition->hasParents(), true);
                $chunk = str_replace(
                    Placeholders::METHOD_INJECT . '__get' . Placeholders::PLACEHOLDER_CLOSE,
                    $getCode,
                    $chunk
                );

Blank line found at end of control structure

            } else {
                $getCode = $this->generateGetCode($structureDefinition->hasParents());
                $chunk = str_replace(
                    $functionHook,
                    $functionHook . $getCode,
                    $chunk
                );
            }
        }

        // We need the code to call the invariant
        $this->injectInvariantCall($chunk);

        // Remove all the properties we will take care of with our magic setter and getter
        $chunk = preg_replace($obsoleteProperties, $propertyReplacements, $chunk, 1);


        return $chunk;
    }