AppserverIo\Doppelgaenger\Parser\PropertyParserTrait::getAttributes()

Complexity

Conditions	21
Paths	12

Size

Total Lines

87

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function getAttributes(array $tokens, TypedListList $invariants = null)
    {
        // Check the tokens
        $attributes = new AttributeDefinitionList();
        for ($i = 0; $i < count($tokens); $i++) {

It seems like you are calling the size function count() as part of the test condition. You might want to compute the size beforehand, and not on each iteration.

            // If we got a variable we will check if there is any function definition above it.
            // If not, we got an attribute, if so we will check if there is an even number of closing and opening
            // brackets above it, which would mean we are not in the function.
            if (is_array($tokens[$i]) && $tokens[$i][0] === T_VARIABLE) {
                for ($j = $i - 1; $j >= 0; $j--) {
                    if (is_array($tokens[$j]) && $tokens[$j][0] === T_FUNCTION) {
                        // Initialize our counter and also the check if we even started counting
                        $bracketCounter = 0;
                        $usedCounter = false;

                        // We got something, lets count the brackets between it and our variable's position
                        for ($k = $j + 1; $k < $i; $k++) {
                            if ($tokens[$k] === '{' || $tokens[$k][0] === T_CURLY_OPEN) {
                                $usedCounter = true;
                                $bracketCounter++;

Blank line found at end of control structure

                            } elseif ($tokens[$k] === '}') {
                                $usedCounter = true;
                                $bracketCounter--;
                            }
                        }

                        // If we got an even number of brackets (the counter is 0 and got used), we got an attribute
                        if ($bracketCounter === 0 && $usedCounter === true) {
                            $attributes->set($tokens[$i][1], $this->getAttributeProperties($tokens, $i));
                        }

                        break;

Blank line found at end of control structure

                    } elseif (is_array($tokens[$j]) && $tokens[$j][0] === $this->getToken()) {
                        // If we reach the class definition without passing a function we definitely got an attribute
                        $attributes->set($tokens[$i][1], $this->getAttributeProperties($tokens, $i));
                        break;
                    }
                }
            }
        }

        // If we got invariants we will check if our attributes are used in invariants
        if ($invariants !== null) {
            // Lets iterate over all the attributes and check them against the invariants we got
            $listIterator = $invariants->getIterator();
            $listCount = $listIterator->count();
            $attributeIterator = $attributes->getIterator();
            $attributeCount = $attributeIterator->count();
            for ($i = 0; $i < $attributeCount; $i++) {
                // Do we have any of these attributes in our invariants?
                $listIterator = $invariants->getIterator();
                for ($j = 0; $j < $listCount; $j++) {
                    // Did we get anything useful?
                    if ($listIterator->current() === null) {
                        continue;
                    }

                    /** @var \AppserverIo\Doppelgaenger\Interfaces\TypedListInterface|\Iterator $invariantIterator */
                    $invariantIterator = $listIterator->current()->getIterator();

The method getIterator cannot be called on $listIterator->current() (of type null).

                    $invariantCount = $invariantIterator->count();

The method count does only exist in AppserverIo\Doppelgaenger\Interfaces\TypedListInterface, but not in Iterator.

                    for ($k = 0; $k < $invariantCount; $k++) {
                        $attributePosition = strpos(
                            $invariantIterator->current()->getString(),

The method current does only exist in Iterator, but not in AppserverIo\Doppelgaenger\Interfaces\TypedListInterface.

                            '$this->' . ltrim(
                                $attributeIterator->current()->getName(),
                                '$'
                            )
                        );

                        if ($attributePosition !== false
                        ) {
                            // Tell them we were mentioned and persist it
                            $attributeIterator->current()->setInInvariant(true);
                        }

                        $invariantIterator->next();

The method next does only exist in Iterator, but not in AppserverIo\Doppelgaenger\Interfaces\TypedListInterface.

                    }
                    $listIterator->next();
                }
                $attributeIterator->next();
            }
        }

        return $attributes;
    }