AppserverIo\Authenticator\DigestAuthenticator::parse()

Complexity

Conditions	4
Paths	6

Size

Total Lines	44
Code Lines	22

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	20

Importance

Changes	1
Bugs	0	Features	0

<?php
    protected function parse(RequestInterface $request)
    {

        // load the raw login credentials
        $rawAuthData = $request->getHeader(Protocol::HEADER_AUTHORIZATION);

        // init data and matches arrays
        $data = array();
        $matches = array();

        // define required data
        $requiredData = array(
            'realm' => 1,
            'nonce' => 1,
            'nc' => 1,
            'cnonce' => 1,
            'qop' => 1,
            'username' => 1,
            'uri' => 1,
            'response' => 1
        );

        // prepare key for parsing logic
        $key = implode('|', array_keys($requiredData));

        // parse header value
        preg_match_all('@(' . $key . ')=(?:([\'"])([^\2]+?)\2|([^\s,]+))@', $rawAuthData, $matches, PREG_SET_ORDER);

        // iterate all found values for header value
        foreach ($matches as $match) {
            // check if match could be found
            if ($match[3]) {
                $data[$match[1]] = $match[3];
            } else {
                $data[$match[1]] = $match[4];
            }

            // unset required value because we got it processed
            unset($requiredData[$match[1]]);
        }

        // set if all required data was processed
        $data['method'] = $this->getRequestMethod();

The method getRequestMethod() does not exist on AppserverIo\Authenticator\DigestAuthenticator.

        $this->authData = $requiredData ? false : $data;

The property authData does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

$requiredData is a non-empty array, thus is always true.

    }