Completed
Pull Request — master (#1104)
by Tim
07:38
created
src/AppserverIo/Appserver/Naming/NamingDirectory.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -127,7 +127,7 @@
 block discarded – undo
127 127
      * Binds the passed instance with the name to the naming directory.
128 128
      *
129 129
      * @param string $name  The name to bind the value with
130
-     * @param mixed  $value The object instance to bind
130
+     * @param callable  $value The object instance to bind
131 131
      * @param array  $args  The array with the arguments
132 132
      *
133 133
      * @return void
Please login to merge, or discard this patch.
Appserver/PersistenceContainer/Doctrine/EntityManagerFactory.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -80,7 +80,7 @@
 block discarded – undo
80 80
     /**
81 81
      * Creates a new entity manager instance based on the passed configuration.
82 82
      *
83
-     * @return object The entity manager instance
83
+     * @return DoctrineEntityManagerDecorator The entity manager instance
84 84
      */
85 85
     public function factory()
86 86
     {
Please login to merge, or discard this patch.
PersistenceContainer/Doctrine/V2/CacheFactories/ApcCacheFactory.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -40,7 +40,7 @@
 block discarded – undo
40 40
      *
41 41
      * @param array $configuration The cache configuration
42 42
      *
43
-     * @return \Doctrine\Common\Cache\CacheProvider The cache instance
43
+     * @return ApcCache|null The cache instance
44 44
      */
45 45
     public static function get(array $configuration = array())
46 46
     {
Please login to merge, or discard this patch.
src/AppserverIo/Appserver/PersistenceContainer/TimedObject.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -55,7 +55,7 @@
 block discarded – undo
55 55
      * @param array            $annotationsToIgnore An array with annotations names we want to ignore when loaded
56 56
      * @param array            $annotationAliases   An array with annotation aliases used when create annotation instances
57 57
      *
58
-     * @return \AppserverIo\Lang\Reflection\ReflectionClass The instance
58
+     * @return \AppserverIo\Lang\Reflection\ClassInterface The instance
59 59
      */
60 60
     public static function fromPhpReflectionClass(\ReflectionClass $reflectionClass, array $annotationsToIgnore = array(), array $annotationAliases = array())
61 61
     {
Please login to merge, or discard this patch.
src/AppserverIo/Appserver/ServletEngine/Http/Request.php 1 patch
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -570,7 +570,7 @@  discard block
 block discarded – undo
570 570
      *
571 571
      * @param string $documentRoot The document root
572 572
      *
573
-     * @return void
573
+     * @return string
574 574
      */
575 575
     public function setDocumentRoot($documentRoot)
576 576
     {
@@ -678,7 +678,7 @@  discard block
 block discarded – undo
678 678
     /**
679 679
      * Return content
680 680
      *
681
-     * @return string $content
681
+     * @return resource $content
682 682
      */
683 683
     public function getBodyContent()
684 684
     {
@@ -924,7 +924,7 @@  discard block
 block discarded – undo
924 924
      *
925 925
      * @param boolean $create TRUE to create a new session, else FALSE
926 926
      *
927
-     * @return null|\AppserverIo\Psr\Servlet\Http\HttpSessionInterface The session instance
927
+     * @return null|SessionWrapper The session instance
928 928
      *
929 929
      * @throws \Exception
930 930
      */
@@ -1284,7 +1284,7 @@  discard block
 block discarded – undo
1284 1284
      *
1285 1285
      * @param string $name The name of the server variable to be returned
1286 1286
      *
1287
-     * @return mixed The requested server variable
1287
+     * @return string The requested server variable
1288 1288
      */
1289 1289
     public function getServerVar($name)
1290 1290
     {
Please login to merge, or discard this patch.
Appserver/ServletEngine/Security/Auth/Spi/AbstractLoginModule.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -225,7 +225,7 @@  discard block
 block discarded – undo
225 225
      * It also adds the members of each Group returned by getRoleSets()
226 226
      * to the subject getPrincipals() Set.
227 227
      *
228
-     * @return true always.
228
+     * @return boolean always.
229 229
      * @throws \AppserverIo\Psr\Security\Auth\Login\LoginException If login can't be committed'
230 230
      */
231 231
     public function commit()
@@ -282,7 +282,7 @@  discard block
 block discarded – undo
282 282
      * Called by login() to acquire the username and password strings for
283 283
      * authentication. This method does no validation of either.
284 284
      *
285
-     * @return array Array with name and password, e. g. array(0 => $name, 1 => $password)
285
+     * @return String[] Array with name and password, e. g. array(0 => $name, 1 => $password)
286 286
      * @throws \AppserverIo\Psr\Security\Auth\Login\LoginException Is thrown if name and password can't be loaded
287 287
      */
288 288
     public function getUsernameAndPassword()
Please login to merge, or discard this patch.
Appserver/ServletEngine/Security/Auth/Spi/NamingDirectoryLoginModule.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -128,7 +128,7 @@
 block discarded – undo
128 128
      *
129 129
      * @throws \AppserverIo\Psr\Security\Auth\Login\LoginException Is thrown if an error during logout occured
130 130
      *
131
-     * @return boolean Always TRUE
131
+     * @return boolean|null Always TRUE
132 132
      */
133 133
     public function logout()
134 134
     {
Please login to merge, or discard this patch.
src/AppserverIo/Appserver/ServletEngine/Security/GenericPrincipal.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -68,8 +68,8 @@
 block discarded – undo
68 68
     /**
69 69
      * Initializes the principal with the data from the passed objects.
70 70
      *
71
-     * @param \AppserverIo\Lang\String                     $username      The principal's username
72
-     * @param \AppserverIo\Lang\String                     $password      The principal's password
71
+     * @param string                     $username      The principal's username
72
+     * @param string                     $password      The principal's password
73 73
      * @param \AppserverIo\Collections\ArrayList           $roles         The principal's roles
74 74
      * @param \AppserverIo\Psr\Security\PrincipalInterface $userPrincipal The user principal instance that will be returned from the request
75 75
      */
Please login to merge, or discard this patch.
AppserverIo/Appserver/ServletEngine/Session/FilesystemSessionHandler.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -44,7 +44,7 @@
 block discarded – undo
44 44
      *
45 45
      * @param string $id The ID of the session we want to unpersist
46 46
      *
47
-     * @return \AppserverIo\Psr\Servlet\ServletSessionInterface The unpersisted session
47
+     * @return \AppserverIo\Psr\Servlet\Http\HttpSessionInterface|null The unpersisted session
48 48
      */
49 49
     public function load($id)
50 50
     {
Please login to merge, or discard this patch.