ObjectManager::addPreference() - Code Metrics - Inspection of "Fixed invalid logging for SFSBs garbage collector..." - appserver-io/appserver - Measure and Improve Code Quality continuously with Scrutinizer

Passed
Pull Request — master (#1108)

by Tim
created 2018-09-03 12:52 UTC
ObjectManager::addPreference() A

↳ Parent: ObjectManager
Complexity

Conditions	3
Paths	2
Size

Total Lines	10
Code Lines	3
Duplication

Lines	0
Ratio	0 %
Code Coverage

Tests	0
CRAP Score	12
Importance

Changes
Metric	Value
cc	3
eloc	3
nc	2
nop	2
dl	0
loc	10
ccs	0
cts	3
cp	0
crap	12
rs	10
c	0
b	0
f	0
<?php

/**
 * \AppserverIo\Appserver\DependencyInjectionContainer\ObjectManager
 *
 * NOTICE OF LICENSE
 *
 * This source file is subject to the Open Software License (OSL 3.0)
 * that is available through the world-wide-web at this URL:
 * http://opensource.org/licenses/osl-3.0.php
 *
 * PHP version 5
 *
 * @author    Tim Wagner <[email protected]>
 * @author    Bernhard Wick <[email protected]>
 * @copyright 2015 TechDivision GmbH <[email protected]>
 * @license   http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
 * @link      https://github.com/appserver-io/appserver
 * @link      http://www.appserver.io
 */

namespace AppserverIo\Appserver\DependencyInjectionContainer;

use AppserverIo\Storage\StorageInterface;
use AppserverIo\Appserver\Core\AbstractManager;
use AppserverIo\Psr\Di\ObjectManagerInterface;
use AppserverIo\Psr\Di\UnknownObjectDescriptorException;
use AppserverIo\Psr\Deployment\DescriptorInterface;
use AppserverIo\Psr\Application\ApplicationInterface;

/**
 * The object manager is necessary to load and provides information about all
 * objects related with the application itself.
 *
 * @author    Tim Wagner <[email protected]>
 * @author    Bernhard Wick <[email protected]>
 * @copyright 2015 TechDivision GmbH <[email protected]>
 * @license   http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)
 * @link      https://github.com/appserver-io/appserver
 * @link      http://www.appserver.io
 *
 * @property \AppserverIo\Storage\StorageInterface $objectDescriptors Storage for our collected object descriptors
 */
class ObjectManager extends AbstractManager implements ObjectManagerInterface
{

    /**
     * Inject the storage for the object descriptors.
     *
     * @param \AppserverIo\Storage\StorageInterface $objectDescriptors The storage for the object descriptors
     *
     * @return void
     */
    public function injectObjectDescriptors(StorageInterface $objectDescriptors)
    {
        $this->objectDescriptors = $objectDescriptors;
    }

    /**
     * Returns the storage with the object descriptors.
     *
     * @return \AppserverIo\Storage\StorageInterface The storage with the object descriptors
     */
    public function getObjectDescriptors()
    {
        return $this->objectDescriptors;
    }

    /**
     * Has been automatically invoked by the container after the application
     * instance has been created.
     *
     * @param \AppserverIo\Psr\Application\ApplicationInterface $application The application instance
     *
     * @return void
     * @see \AppserverIo\Psr\Application\ManagerInterface::initialize()
     */
    public function initialize(ApplicationInterface $application)
    {

        // parse the object descriptors
        $this->parseObjectDescriptors();
    }

    /**
     * Adds the passed object descriptor to the object manager. If the merge flag is TRUE, then
     * we check if already an object descriptor for the class exists before they will be merged.
     *
     * When we merge object descriptors this means, that the values of the passed descriptor
     * will override the existing ones.
     *
     * @param \AppserverIo\Psr\Deployment\DescriptorInterface $objectDescriptor The object descriptor to add
     * @param boolean                                         $merge            TRUE if we want to merge with an existing object descriptor
     *
     * @return void
     */
    public function addPreference(DescriptorInterface $objectDescriptor, $merge = false)
    {

        // query whether or not an existing preference has to be overwritten
        if ($this->hasAttribute($interface = $objectDescriptor->getInterface()) && !$merge) {
        if ($this->hasAttribute($interface = $objectDescriptor->/** @scrutinizer ignore-call */ getInterface()) && !$merge) {
            return;
        }

        // add the new preference
        $this->setAttribute($interface, $objectDescriptor->getClassName());
        $this->setAttribute($interface, $objectDescriptor->/** @scrutinizer ignore-call */ getClassName());
    }

    /**
     * Return's the preference for the passed class name.
     *
     * @param string $className The class name to return the preference for
     *
     * @return string The preference or the original class name
     */
    public function getPreference($className)
    {

        // query whether or not we've a preference
        if ($this->hasAttribute($className)) {
            return $this->getAttribute($className);
        }

        // if not, return the original class name
        return $className;
    }

    /**
     * Adds the passed object descriptor to the object manager. If the merge flag is TRUE, then
     * we check if already an object descriptor for the class exists before they will be merged.
     *
     * When we merge object descriptors this means, that the values of the passed descriptor
     * will override the existing ones.
     *
     * @param \AppserverIo\Psr\Deployment\DescriptorInterface $objectDescriptor The object descriptor to add
     * @param boolean                                         $merge            TRUE if we want to merge with an existing object descriptor
     *
     * @return void
     */
    public function addObjectDescriptor(DescriptorInterface $objectDescriptor, $merge = false)
    {

        // query whether we've to merge the configuration found in annotations
        if ($this->hasObjectDescriptor($objectDescriptor->getName()) && $merge) {
        if ($this->hasObjectDescriptor($objectDescriptor->/** @scrutinizer ignore-call */ getName()) && $merge) {
            // load the existing descriptor
            $existingDescriptor = $this->getObjectDescriptor($objectDescriptor->getName());
            $existingDescriptorType = get_class($existingDescriptor);
            // log on info level to make overwriting more obvious
            $this->getApplication()->getInitialContext()->getSystemLogger()->debug(
            $this->getApplication()->/** @scrutinizer ignore-call */ getInitialContext()->getSystemLogger()->debug(
                sprintf(
                    'Overriding descriptor "%s" of webapp "%s" from XML configuration.',
                    $existingDescriptor->getName(),
                    $this->getApplication()->getName()
                )
            );

            // Merge the descriptors. XML configuration overrides values from annotation but we have to make sure
            // that the descriptors are of the same type. If not we have to take the XML descriptor as our new base descriptor
            // and merge the annotations (but XML still has to be dominant)
            $mergedDescriptor = null;
            if (!$objectDescriptor instanceof $existingDescriptorType) {
                // create a temporary clone of the object (XML) descriptor to merge the existing descriptor into an instance with the same type
                $mergedDescriptor = clone $objectDescriptor;
                $mergedDescriptor->merge($existingDescriptor);
                                   merge($existingDescriptor);
                $mergedDescriptor->merge($objectDescriptor);


            } else {
                // merge the object descriptor into the existing one
                $mergedDescriptor = $existingDescriptor;
                $mergedDescriptor->merge($objectDescriptor);
                                   merge($objectDescriptor);
            }

            // re-register the merged descriptor
            $this->setObjectDescriptor($mergedDescriptor);
            $this->setObjectDescriptor(/** @scrutinizer ignore-type */ $mergedDescriptor);


        } else {
            // register the object descriptor
            $this->setObjectDescriptor($objectDescriptor);
        }
    }

    /**
     * Registers the passed object descriptor under its class name.
     *
     * @param \AppserverIo\Psr\Deployment\DescriptorInterface $objectDescriptor The object descriptor to set
     *
     * @return void
     */
    public function setObjectDescriptor(DescriptorInterface $objectDescriptor)
    {
        $this->objectDescriptors->set($objectDescriptor->getName(), $objectDescriptor);
    }

    /**
     * Query if we've an object descriptor for the passed name.
     *
     * @param string $name The name we query for a object descriptor
     *
     * @return boolean TRUE if an object descriptor has been registered, else FALSE
     */
    public function hasObjectDescriptor($name)
    {
        return $this->objectDescriptors->has($name);
    }

    /**
     * Returns the object descriptor if we've registered it.
     *
     * @param string $name The name we want to return the object descriptor for
     *
     * @return \AppserverIo\Psr\Deployment\DescriptorInterface|null The requested object descriptor instance
     * @throws \AppserverIo\Psr\Di\UnknownObjectDescriptorException Is thrown if someone tries to access an unknown object desciptor
     */
    public function getObjectDescriptor($name)
    {

        // query if we've an object descriptor registered
        if ($this->hasObjectDescriptor($name)) {
            // return the object descriptor
            return $this->objectDescriptors->get($name);
        }

        // throw an exception is object descriptor has not been registered
        throw new UnknownObjectDescriptorException(sprintf('Object Descriptor with name "%s" has not been registered', $name));
    }

    /**
     * Returns the identifier for the object manager instance.
     *
     * @return string
     * @see \AppserverIo\Psr\Application\ManagerInterface::getIdentifier()
     */
    public function getIdentifier()
    {
        return ObjectManagerInterface::IDENTIFIER;
    }
}

appserver-io / appserver

Pull Request — master (#1108)

ObjectManager::addPreference() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like
