appserver-io / appserver

src/AppserverIo/Appserver/ServletEngine/Security/Realm.php

Doc Comments +4 added lines, -4 removed lines

@@ -104,7 +104,7 @@ 
     /**
      * Inject the realm's configuration.
      *
-     * @param \AppserverIo\Appserver\ServletEngine\Security\SecurityDomainInterface $configuration The realm's configuration
+     * @param SecurityDomainNodeInterface $configuration The realm's configuration
      *
      * @return void
      */
@@ -149,7 +149,7 @@ 
      * @param \AppserverIo\Lang\String                                         $username        The name of the user to authenticate
      * @param \AppserverIo\Psr\Security\Auth\Callback\CallbackHandlerInterface $callbackHandler The callback handler used to load the credentials
      *
-     * @return \AppserverIo\Security\PrincipalInterface|null The authenticated user principal
+     * @return GenericPrincipal|null The authenticated user principal
      */
     public function authenticateByUsernameAndCallbackHandler(String $username, CallbackHandlerInterface $callbackHandler)
     {
@@ -183,7 +183,7 @@ 
      * @param \AppserverIo\Lang\String $username The name of the user to authenticate
      * @param \AppserverIo\Lang\String $password The password used for authentication
      *
-     * @return \AppserverIo\Security\PrincipalInterface|null The authenticated user principal
+     * @return GenericPrincipal|null The authenticated user principal
      */
     public function authenticate(String $username, String $password)
     {
@@ -208,7 +208,7 @@ 
      * @param \AppserverIo\Psr\Security\Auth\Subject                     $subject      The Subject representing the logged-in user
      * @param \AppserverIo\Psr\Security\Auth\Login\LoginContextInterface $loginContext Associated with the Principal so {@link LoginContext#logout()} can be called later
      *
-     * @return \AppserverIo\Security\PrincipalInterface the principal object
+     * @return GenericPrincipal the principal object
      */
     protected function createPrincipal(String $username, Subject $subject, LoginContextInterface $loginContext)
     {

Unused Use Statements -1 removed lines

@@ -22,7 +22,6 @@
 
 use AppserverIo\Lang\String;
 use AppserverIo\Collections\ArrayList;
-use AppserverIo\Configuration\Configuration;
 use AppserverIo\Psr\Security\Auth\Subject;
 use AppserverIo\Psr\Security\PrincipalInterface;
 use AppserverIo\Psr\Security\Auth\Login\LoginContext;

src/AppserverIo/Appserver/ServletEngine/Security/Utils/Util.php

Doc Comments +1 added lines, -1 removed lines

@@ -81,7 +81,7 @@
      * @param \AppserverIo\Lang\String                  $username   The username to load the roles for
      * @param \AppserverIo\Lang\String                  $lookupName The lookup name for the datasource
      * @param \AppserverIo\Lang\String                  $rolesQuery The query to load the roles
-     * @param \AppserverIo\Psr\Spi\LoginModuleInterface $aslm       The login module to add the roles to
+     * @param LoginModuleInterface $aslm       The login module to add the roles to
      *
      * @return array An array of groups containing the sets of roles
      * @throws \AppserverIo\Appserver\ServletEngine\Security\Logi\LoginException Is thrown if an error during login occured

src/AppserverIo/Appserver/ServletEngine/ServletEngine.php

Doc Comments +1 added lines, -1 removed lines

@@ -102,7 +102,7 @@
      * @param \AppserverIo\Server\Interfaces\RequestContextInterface $requestContext A requests context instance
      * @param integer                                                $hook           The current hook to process logic for
      *
-     * @return boolean
+     * @return boolean|null
      *
      * @throws \AppserverIo\Server\Exceptions\ModuleException
      */

src/AppserverIo/Appserver/ServletEngine/ServletManager.php

Doc Comments +2 added lines, -2 removed lines

@@ -58,7 +58,7 @@ 
     /**
      * Injects the additional directories to be parsed when looking for servlets.
      *
-     * @param array $directories The additional directories to be parsed
+     * @param \AppserverIo\Appserver\Core\Api\Node\DirectoryNode[] $directories The additional directories to be parsed
      *
      * @return void
      */
@@ -293,7 +293,7 @@ 
     /**
      * Returns all servlets
      *
-     * @return array The servlets collection
+     * @return StorageInterface The servlets collection
      */
     public function getServlets()
     {

src/AppserverIo/Appserver/ServletEngine/Session/ApcSessionHandler.php

Doc Comments +2 added lines, -2 removed lines

@@ -54,7 +54,7 @@ 
      *
      * @param string $id The ID of the session we want to unpersist
      *
-     * @return \AppserverIo\Psr\Servlet\ServletSessionInterface The unpersisted session
+     * @return null|Session The unpersisted session
      */
     public function load($id)
     {
@@ -147,7 +147,7 @@ 
      *
      * @param string $id The ID of the session to load
      *
-     * @return \AppserverIo\Psr\Servlet\Http\HttpSessionInterface The unmarshalled session
+     * @return null|Session The unmarshalled session
      * @throws \AppserverIo\Appserver\ServletEngine\SessionDataNotReadableException Is thrown if the file containing the session data is not readable
      */
     protected function unpersist($id)

Unused Use Statements -3 removed lines

@@ -20,11 +20,8 @@
 
 namespace AppserverIo\Appserver\ServletEngine\Session;
 
-use AppserverIo\Lang\Reflection\ReflectionClass;
 use AppserverIo\Psr\Servlet\ServletSessionInterface;
 use AppserverIo\Appserver\ServletEngine\Http\Session;
-use AppserverIo\Appserver\ServletEngine\SessionSettingsInterface;
-use AppserverIo\Appserver\ServletEngine\SessionMarshallerInterface;
 use AppserverIo\Appserver\ServletEngine\SessionCanNotBeSavedException;
 use AppserverIo\Appserver\ServletEngine\SessionCanNotBeDeletedException;
 

src/AppserverIo/Appserver/ServletEngine/Session/FilesystemSessionHandler.php

Doc Comments +2 added lines, -2 removed lines

@@ -47,7 +47,7 @@ 
      *
      * @param string $id The ID of the session we want to unpersist
      *
-     * @return \AppserverIo\Psr\Servlet\ServletSessionInterface The unpersisted session
+     * @return null|Session The unpersisted session
      */
     public function load($id)
     {
@@ -157,7 +157,7 @@ 
      *
      * @param string $pathname The path of the file to load the session data from
      *
-     * @return \AppserverIo\Psr\Servlet\Http\HttpSessionInterface The unmarshalled session
+     * @return null|Session The unmarshalled session
      * @throws \AppserverIo\Appserver\ServletEngine\SessionDataNotReadableException Is thrown if the file containing the session data is not readable
      */
     protected function unpersist($pathname)

Unused Use Statements -3 removed lines

@@ -20,11 +20,8 @@
 
 namespace AppserverIo\Appserver\ServletEngine\Session;
 
-use AppserverIo\Lang\Reflection\ReflectionClass;
 use AppserverIo\Psr\Servlet\ServletSessionInterface;
 use AppserverIo\Appserver\ServletEngine\Http\Session;
-use AppserverIo\Appserver\ServletEngine\SessionSettingsInterface;
-use AppserverIo\Appserver\ServletEngine\SessionMarshallerInterface;
 use AppserverIo\Appserver\ServletEngine\SessionCanNotBeSavedException;
 use AppserverIo\Appserver\ServletEngine\SessionCanNotBeDeletedException;
 

src/AppserverIo/Appserver/ServletEngine/StandardSessionManager.php

Doc Comments +3 added lines, -3 removed lines

@@ -124,7 +124,7 @@ 
     /**
      * Returns the application instance.
      *
-     * @return \AppserverIo\Psr\Application\ApplicationInterface|\AppserverIo\Psr\Naming\NamingDirectoryInterface The application instance
+     * @return ApplicationInterface The application instance
      */
     public function getApplication()
     {
@@ -212,7 +212,7 @@ 
     /**
      * Returns all registered session handlers.
      *
-     * @return \AppserverIo\Collections\ArrayList The session handlers
+     * @return HashMap The session handlers
      */
     public function getSessionHandlers()
     {
@@ -418,7 +418,7 @@ 
      *
      * @param string $id The unique session ID to that has to be returned
      *
-     * @return \AppserverIo\Psr\Servlet\Http\ServletSessionInterface|null The requested session
+     * @return null|ServletSessionInterface The requested session
      */
     public function find($id)
     {