Completed
Branch master (04f1dc)
by Tim
11:24
created
AppserverIo/Appserver/ServletEngine/Authenticator/DigestAuthenticator.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -23,7 +23,6 @@
 block discarded – undo
23 23
 
24 24
 use AppserverIo\Psr\HttpMessage\Protocol;
25 25
 use AppserverIo\Psr\HttpMessage\RequestInterface;
26
-use AppserverIo\Http\Authentication\Adapters\HtdigestAdapter;
27 26
 
28 27
 /**
29 28
  * Class DigestAuthentication
Please login to merge, or discard this patch.
src/AppserverIo/Appserver/ServletEngine/Authenticator/FormAuthenticator.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -579,7 +579,7 @@
 block discarded – undo
579 579
     /**
580 580
      * Returns the parsed password.
581 581
      *
582
-     * @return \AppserverIo\Lang\String The password
582
+     * @return string|null The password
583 583
      */
584 584
     public function getPassword()
585 585
     {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -23,7 +23,6 @@
 block discarded – undo
23 23
 use AppserverIo\Lang\String;
24 24
 use AppserverIo\Collections\ArrayList;
25 25
 use AppserverIo\Psr\HttpMessage\Protocol;
26
-use AppserverIo\Psr\Security\Auth\Subject;
27 26
 use AppserverIo\Psr\Servlet\ServletException;
28 27
 use AppserverIo\Psr\Security\Utils\Constants;
29 28
 use AppserverIo\Psr\Security\PrincipalInterface;
Please login to merge, or discard this patch.
src/AppserverIo/Appserver/ServletEngine/Http/Request.php 2 patches
Doc Comments   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -558,7 +558,7 @@  discard block
 block discarded – undo
558 558
      *
559 559
      * @param string $documentRoot The document root
560 560
      *
561
-     * @return void
561
+     * @return string
562 562
      */
563 563
     public function setDocumentRoot($documentRoot)
564 564
     {
@@ -666,7 +666,7 @@  discard block
 block discarded – undo
666 666
     /**
667 667
      * Return content
668 668
      *
669
-     * @return string $content
669
+     * @return resource $content
670 670
      */
671 671
     public function getBodyContent()
672 672
     {
@@ -912,7 +912,7 @@  discard block
 block discarded – undo
912 912
      *
913 913
      * @param boolean $create TRUE to create a new session, else FALSE
914 914
      *
915
-     * @return null|\AppserverIo\Psr\Servlet\Http\HttpSessionInterface The session instance
915
+     * @return null|SessionWrapper The session instance
916 916
      *
917 917
      * @throws \Exception
918 918
      */
@@ -1040,7 +1040,7 @@  discard block
 block discarded – undo
1040 1040
      *
1041 1041
      * @param string $name The header key to name
1042 1042
      *
1043
-     * @return string|null
1043
+     * @return string
1044 1044
      */
1045 1045
     public function getHeader($name)
1046 1046
     {
@@ -1198,7 +1198,7 @@  discard block
 block discarded – undo
1198 1198
     /**
1199 1199
      * Returns query string of the actual request.
1200 1200
      *
1201
-     * @return string|null The query string of the actual request
1201
+     * @return string The query string of the actual request
1202 1202
      */
1203 1203
     public function getQueryString()
1204 1204
     {
@@ -1269,7 +1269,7 @@  discard block
 block discarded – undo
1269 1269
      *
1270 1270
      * @param string $name The name of the server variable to be returned
1271 1271
      *
1272
-     * @return mixed The requested server variable
1272
+     * @return string The requested server variable
1273 1273
      */
1274 1274
     public function getServerVar($name)
1275 1275
     {
@@ -1293,7 +1293,7 @@  discard block
 block discarded – undo
1293 1293
     /**
1294 1294
      * Return's the authentication type.
1295 1295
      *
1296
-     * @return string|null The authentication type
1296
+     * @return string The authentication type
1297 1297
      */
1298 1298
     public function getAuthType()
1299 1299
     {
@@ -1315,7 +1315,7 @@  discard block
 block discarded – undo
1315 1315
     /**
1316 1316
      * Return's a PrincipalInterface object containing the name of the current authenticated user.
1317 1317
      *
1318
-     * @return \AppserverIo\Psr\Security\PrincipalInterface|null The user principal
1318
+     * @return PrincipalInterface The user principal
1319 1319
      */
1320 1320
     public function getUserPrincipal()
1321 1321
     {
@@ -1359,7 +1359,7 @@  discard block
 block discarded – undo
1359 1359
      * Use the container login mechanism configured for the servlet context to authenticate the user making this
1360 1360
      * request. This method may modify and commit the passed servlet response.
1361 1361
      *
1362
-     * @param AppserverIo\Psr\Servlet\Http\HttpServletResponseInterface $servletResponse The servlet response
1362
+     * @param HttpServletResponseInterface $servletResponse The servlet response
1363 1363
      *
1364 1364
      * @return boolean TRUE when non-null values were or have been established as the values returned by getRemoteUser, else FALSE
1365 1365
      */
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -28,7 +28,6 @@
 block discarded – undo
28 28
 use AppserverIo\Psr\HttpMessage\CookieInterface;
29 29
 use AppserverIo\Psr\HttpMessage\RequestInterface;
30 30
 use AppserverIo\Psr\Security\PrincipalInterface;
31
-use AppserverIo\Psr\Security\Auth\Subject;
32 31
 use AppserverIo\Psr\Servlet\SessionUtils;
33 32
 use AppserverIo\Psr\Servlet\ServletException;
34 33
 use AppserverIo\Psr\Servlet\Http\HttpServletRequestInterface;
Please login to merge, or discard this patch.
src/AppserverIo/Appserver/ServletEngine/Http/Session.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -57,7 +57,7 @@
 block discarded – undo
57 57
      *
58 58
      * @param mixed             $id         The session ID
59 59
      * @param string            $name       The session name
60
-     * @param integer|\DateTime $lifetime   Date and time after the session expires
60
+     * @param integer $lifetime   Date and time after the session expires
61 61
      * @param integer|null      $maximumAge Number of seconds until the session expires
62 62
      * @param string|null       $domain     The host to which the user agent will send this cookie
63 63
      * @param string            $path       The path describing the scope of this cookie
Please login to merge, or discard this patch.
src/AppserverIo/Appserver/ServletEngine/RequestHandler.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -26,7 +26,6 @@
 block discarded – undo
26 26
 use AppserverIo\Psr\Servlet\Http\HttpServletRequestInterface;
27 27
 use AppserverIo\Psr\Servlet\Http\HttpServletResponseInterface;
28 28
 use AppserverIo\Appserver\ServletEngine\Utils\Error;
29
-use AppserverIo\Appserver\ServletEngine\Http\Response;
30 29
 use AppserverIo\Appserver\ServletEngine\Utils\ErrorUtil;
31 30
 use AppserverIo\Appserver\ServletEngine\Security\AuthenticationManagerInterface;
32 31
 
Please login to merge, or discard this patch.
Appserver/ServletEngine/Security/Auth/Callback/DigestCallback.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -37,7 +37,7 @@
 block discarded – undo
37 37
     /**
38 38
      * Initializes the callback with the configuration params.
39 39
      *
40
-     * @param AppserverIo\Collections\HashMap $params The configuration params
40
+     * @param HashMap $params The configuration params
41 41
      *
42 42
      * @return void
43 43
      */
Please login to merge, or discard this patch.
Appserver/ServletEngine/Security/Auth/Spi/AbstractLoginModule.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -229,7 +229,7 @@  discard block
 block discarded – undo
229 229
      *
230 230
      * @see javax.security.auth.Subject;
231 231
      * @see java.security.acl.Group;
232
-     * @return true always.
232
+     * @return boolean always.
233 233
      * @throws \AppserverIo\Appserver\Psr\Security\Auth\Login\LoginException If login can't be committed'
234 234
      */
235 235
     public function commit()
@@ -286,7 +286,7 @@  discard block
 block discarded – undo
286 286
      * Called by login() to acquire the username and password strings for
287 287
      * authentication. This method does no validation of either.
288 288
      *
289
-     * @return array Array with name and password, e. g. array(0 => $name, 1 => $password)
289
+     * @return String[] Array with name and password, e. g. array(0 => $name, 1 => $password)
290 290
      * @throws \AppserverIo\Appserver\Psr\Security\Auth\Login\LoginException Is thrown if name and password can't be loaded
291 291
      */
292 292
     public function getUsernameAndPassword()
Please login to merge, or discard this patch.
Appserver/ServletEngine/Security/Auth/Spi/NamingDirectoryLoginModule.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -128,7 +128,7 @@
 block discarded – undo
128 128
      *
129 129
      * @throws \AppserverIo\Appserver\Psr\Security\Auth\Login\LoginException Is thrown if an error during logout occured
130 130
      *
131
-     * @return boolean Always TRUE
131
+     * @return boolean|null Always TRUE
132 132
      */
133 133
     public function logout()
134 134
     {
Please login to merge, or discard this patch.
ServletEngine/Security/DependencyInjection/DeploymentDescriptorParser.php 1 patch
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -26,8 +26,6 @@
 block discarded – undo
26 26
 use AppserverIo\Appserver\Core\Api\Node\WebAppNode;
27 27
 use AppserverIo\Appserver\ServletEngine\Security\Mapping;
28 28
 use AppserverIo\Appserver\ServletEngine\Security\AuthenticationManagerInterface;
29
-use AppserverIo\Appserver\ServletEngine\Authenticator\Utils\FormKeys;
30
-use AppserverIo\Psr\HttpMessage\Protocol;
31 29
 
32 30
 /**
33 31
  * Parser implementation to parse a web application deployment descriptor (WEB-INF/web.xml).
Please login to merge, or discard this patch.