Completed
Branch master (04f1dc)
by Tim
11:24
created
Appserver/ServletEngine/Security/Auth/Callback/DigestCallback.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -37,7 +37,7 @@
 block discarded – undo
37 37
     /**
38 38
      * Initializes the callback with the configuration params.
39 39
      *
40
-     * @param AppserverIo\Collections\HashMap $params The configuration params
40
+     * @param HashMap $params The configuration params
41 41
      *
42 42
      * @return void
43 43
      */
Please login to merge, or discard this patch.
Appserver/ServletEngine/Security/Auth/Spi/AbstractLoginModule.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -229,7 +229,7 @@  discard block
 block discarded – undo
229 229
      *
230 230
      * @see javax.security.auth.Subject;
231 231
      * @see java.security.acl.Group;
232
-     * @return true always.
232
+     * @return boolean always.
233 233
      * @throws \AppserverIo\Appserver\Psr\Security\Auth\Login\LoginException If login can't be committed'
234 234
      */
235 235
     public function commit()
@@ -286,7 +286,7 @@  discard block
 block discarded – undo
286 286
      * Called by login() to acquire the username and password strings for
287 287
      * authentication. This method does no validation of either.
288 288
      *
289
-     * @return array Array with name and password, e. g. array(0 => $name, 1 => $password)
289
+     * @return String[] Array with name and password, e. g. array(0 => $name, 1 => $password)
290 290
      * @throws \AppserverIo\Appserver\Psr\Security\Auth\Login\LoginException Is thrown if name and password can't be loaded
291 291
      */
292 292
     public function getUsernameAndPassword()
Please login to merge, or discard this patch.
Appserver/ServletEngine/Security/Auth/Spi/NamingDirectoryLoginModule.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -128,7 +128,7 @@
 block discarded – undo
128 128
      *
129 129
      * @throws \AppserverIo\Appserver\Psr\Security\Auth\Login\LoginException Is thrown if an error during logout occured
130 130
      *
131
-     * @return boolean Always TRUE
131
+     * @return boolean|null Always TRUE
132 132
      */
133 133
     public function logout()
134 134
     {
Please login to merge, or discard this patch.
src/AppserverIo/Appserver/ServletEngine/Security/GenericPrincipal.php 1 patch
Doc Comments   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -76,9 +76,9 @@  discard block
 block discarded – undo
76 76
     /**
77 77
      * Initializes the principal with the data from the passed objects.
78 78
      *
79
-     * @param \AppserverIo\Lang\String                                   $username      The principal's username
80
-     * @param \AppserverIo\Lang\String                                   $password      The principal's password
81
-     * @param \AppserverIo\Collection\ArrayList                          $roles         The principal's roles
79
+     * @param string                                   $username      The principal's username
80
+     * @param string                                   $password      The principal's password
81
+     * @param ArrayList                          $roles         The principal's roles
82 82
      * @param \AppserverIo\Psr\Security\PrincipalInterface               $userPrincipal The user principal instance that will be returned from the request
83 83
      * @param \AppserverIo\Psr\Security\Auth\Login\LoginContextInterface $loginContext  The actual login context instance
84 84
      */
@@ -107,7 +107,7 @@  discard block
 block discarded – undo
107 107
     /**
108 108
      * Return's the principal's username.
109 109
      *
110
-     * @return the \AppserverIo\Lang\String The username
110
+     * @return String \AppserverIo\Lang\String The username
111 111
      */
112 112
     public function getUsername()
113 113
     {
@@ -117,7 +117,7 @@  discard block
 block discarded – undo
117 117
     /**
118 118
      * Return's the principal's password.
119 119
      *
120
-     * @return the \AppserverIo\Lang\String The password
120
+     * @return String \AppserverIo\Lang\String The password
121 121
      */
122 122
     public function getPassword()
123 123
     {
@@ -137,7 +137,7 @@  discard block
 block discarded – undo
137 137
     /**
138 138
      * Return's the user principal instance that will be returned from the request.
139 139
      *
140
-     * @return the \AppserverIo\Psr\Security\PrincipalInterface The user principal
140
+     * @return PrincipalInterface \AppserverIo\Psr\Security\PrincipalInterface The user principal
141 141
      */
142 142
     public function getUserPrincipal()
143 143
     {
@@ -147,7 +147,7 @@  discard block
 block discarded – undo
147 147
     /**
148 148
      * Return's the actual login context instance.
149 149
      *
150
-     * @return the \AppserverIo\Psr\Security\Auth\Login\LoginContextInterface The login context instance
150
+     * @return LoginContextInterface \AppserverIo\Psr\Security\Auth\Login\LoginContextInterface The login context instance
151 151
      */
152 152
     public function getLoginContext()
153 153
     {
Please login to merge, or discard this patch.
src/AppserverIo/Appserver/ServletEngine/Security/Realm.php 1 patch
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -104,7 +104,7 @@  discard block
 block discarded – undo
104 104
     /**
105 105
      * Inject the realm's configuration.
106 106
      *
107
-     * @param \AppserverIo\Appserver\ServletEngine\Security\SecurityDomainInterface $configuration The realm's configuration
107
+     * @param SecurityDomainNodeInterface $configuration The realm's configuration
108 108
      *
109 109
      * @return void
110 110
      */
@@ -149,7 +149,7 @@  discard block
 block discarded – undo
149 149
      * @param \AppserverIo\Lang\String                                         $username        The name of the user to authenticate
150 150
      * @param \AppserverIo\Psr\Security\Auth\Callback\CallbackHandlerInterface $callbackHandler The callback handler used to load the credentials
151 151
      *
152
-     * @return \AppserverIo\Security\PrincipalInterface|null The authenticated user principal
152
+     * @return GenericPrincipal|null The authenticated user principal
153 153
      */
154 154
     public function authenticateByUsernameAndCallbackHandler(String $username, CallbackHandlerInterface $callbackHandler)
155 155
     {
@@ -183,7 +183,7 @@  discard block
 block discarded – undo
183 183
      * @param \AppserverIo\Lang\String $username The name of the user to authenticate
184 184
      * @param \AppserverIo\Lang\String $password The password used for authentication
185 185
      *
186
-     * @return \AppserverIo\Security\PrincipalInterface|null The authenticated user principal
186
+     * @return GenericPrincipal|null The authenticated user principal
187 187
      */
188 188
     public function authenticate(String $username, String $password)
189 189
     {
@@ -208,7 +208,7 @@  discard block
 block discarded – undo
208 208
      * @param \AppserverIo\Psr\Security\Auth\Subject                     $subject      The Subject representing the logged-in user
209 209
      * @param \AppserverIo\Psr\Security\Auth\Login\LoginContextInterface $loginContext Associated with the Principal so {@link LoginContext#logout()} can be called later
210 210
      *
211
-     * @return \AppserverIo\Security\PrincipalInterface the principal object
211
+     * @return GenericPrincipal the principal object
212 212
      */
213 213
     protected function createPrincipal(String $username, Subject $subject, LoginContextInterface $loginContext)
214 214
     {
Please login to merge, or discard this patch.
src/AppserverIo/Appserver/ServletEngine/Security/Utils/Util.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -81,7 +81,7 @@
 block discarded – undo
81 81
      * @param \AppserverIo\Lang\String                  $username   The username to load the roles for
82 82
      * @param \AppserverIo\Lang\String                  $lookupName The lookup name for the datasource
83 83
      * @param \AppserverIo\Lang\String                  $rolesQuery The query to load the roles
84
-     * @param \AppserverIo\Psr\Spi\LoginModuleInterface $aslm       The login module to add the roles to
84
+     * @param LoginModuleInterface $aslm       The login module to add the roles to
85 85
      *
86 86
      * @return array An array of groups containing the sets of roles
87 87
      * @throws \AppserverIo\Appserver\ServletEngine\Security\Logi\LoginException Is thrown if an error during login occured
Please login to merge, or discard this patch.
src/AppserverIo/Appserver/ServletEngine/ServletEngine.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -102,7 +102,7 @@
 block discarded – undo
102 102
      * @param \AppserverIo\Server\Interfaces\RequestContextInterface $requestContext A requests context instance
103 103
      * @param integer                                                $hook           The current hook to process logic for
104 104
      *
105
-     * @return boolean
105
+     * @return boolean|null
106 106
      *
107 107
      * @throws \AppserverIo\Server\Exceptions\ModuleException
108 108
      */
Please login to merge, or discard this patch.
src/AppserverIo/Appserver/ServletEngine/ServletManager.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -58,7 +58,7 @@  discard block
 block discarded – undo
58 58
     /**
59 59
      * Injects the additional directories to be parsed when looking for servlets.
60 60
      *
61
-     * @param array $directories The additional directories to be parsed
61
+     * @param \AppserverIo\Appserver\Core\Api\Node\DirectoryNode[] $directories The additional directories to be parsed
62 62
      *
63 63
      * @return void
64 64
      */
@@ -293,7 +293,7 @@  discard block
 block discarded – undo
293 293
     /**
294 294
      * Returns all servlets
295 295
      *
296
-     * @return array The servlets collection
296
+     * @return StorageInterface The servlets collection
297 297
      */
298 298
     public function getServlets()
299 299
     {
Please login to merge, or discard this patch.
src/AppserverIo/Appserver/ServletEngine/Session/ApcSessionHandler.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -54,7 +54,7 @@  discard block
 block discarded – undo
54 54
      *
55 55
      * @param string $id The ID of the session we want to unpersist
56 56
      *
57
-     * @return \AppserverIo\Psr\Servlet\ServletSessionInterface The unpersisted session
57
+     * @return null|Session The unpersisted session
58 58
      */
59 59
     public function load($id)
60 60
     {
@@ -147,7 +147,7 @@  discard block
 block discarded – undo
147 147
      *
148 148
      * @param string $id The ID of the session to load
149 149
      *
150
-     * @return \AppserverIo\Psr\Servlet\Http\HttpSessionInterface The unmarshalled session
150
+     * @return null|Session The unmarshalled session
151 151
      * @throws \AppserverIo\Appserver\ServletEngine\SessionDataNotReadableException Is thrown if the file containing the session data is not readable
152 152
      */
153 153
     protected function unpersist($id)
Please login to merge, or discard this patch.