appino / Blockchain

src/Classes/Conversion.php

<?php
/* vim: set expandtab tabstop=4 shiftwidth=4 softtabstop=4: */

/**
 * Short File Description
 *
 * PHP version 5
 *
 * @category   aCategory
 * @package    aPackage
 * @subpackage aSubPackage
 * @author     anAuthor
 * @copyright  2014 a Copyright
 * @license    a License
 * @link       http://www.aLink.com
 */
namespace Appino\Blockchain\Classes\Conversion;

/**
 * Short Class Description
 *
 * PHP version 5
 *
 * @category   aCategory
 * @package    aPackage
 * @subpackage aSubPackage
 * @author     anAuthor
 * @copyright  2014 a Copyright
 * @license    a License
 * @link       http://www.aLink.com
 */
class Conversion
{
    /**
     * Properties
     */


    /**
     * Methods
     */
    /**
     * Convert an incoming integer to a BTC string value
     */
    static function BTC_int2str($val)

It is generally recommended to explicitly declare the visibility for methods.

    {
        $a = bcmul($val, "1.0", 1);
        return bcdiv($a, "100000000", 8);
    }

    /**
     * Convert a float value to BTC satoshi integer string
     */
    static function BTC_float2int($val)

It is generally recommended to explicitly declare the visibility for methods.

    {
        return bcmul($val, "100000000", 0);
    }

    /**
     * From comment on http://php.net/manual/en/ref.bc.php
     */
    static function bcconv($fNumber)

It is generally recommended to explicitly declare the visibility for methods.

    {
        $sAppend = '';
        $iDecimals = ini_get('precision') - floor(log10(abs($fNumber)));
        if (0 > $iDecimals) {
            $fNumber *= pow(10, $iDecimals);
            $sAppend = str_repeat('0', -$iDecimals);

-$iDecimals of type double is incompatible with the type integer expected by parameter $multiplier of str_repeat().

            $iDecimals = 0;
        }

        return number_format($fNumber, $iDecimals, '.', '').$sAppend;

It seems like $iDecimals can also be of type double; however, parameter $decimals of number_format() does only seem to accept integer, maybe add an additional type check?

    }
}