| Conditions | 1 |
| Paths | 1 |
| Total Lines | 91 |
| Code Lines | 78 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 2 | ||
| Bugs | 0 | Features | 1 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 127 | public function getDefaultRouteRequestAction() |
||
| 128 | { |
||
| 129 | return [ |
||
| 130 | ['http://apparat/blog/2016', YearAction::class], |
||
| 131 | ['http://apparat/blog/*', YearAction::class], |
||
| 132 | |||
| 133 | ['http://apparat/blog/2016/06', MonthAction::class], |
||
| 134 | ['http://apparat/blog/*/*', MonthAction::class], |
||
| 135 | |||
| 136 | ['http://apparat/blog/2016/06/08', DayAction::class], |
||
| 137 | ['http://apparat/blog/*/*/*', DayAction::class], |
||
| 138 | |||
| 139 | ['http://apparat/blog/2016/06/08/19', HourAction::class], |
||
| 140 | ['http://apparat/blog/*/*/*/*', HourAction::class], |
||
| 141 | |||
| 142 | ['http://apparat/blog/2016/06/08/19/14', MinuteAction::class], |
||
| 143 | ['http://apparat/blog/*/*/*/*/*', MinuteAction::class], |
||
| 144 | |||
| 145 | ['http://apparat/blog/2016/06/08/19/14/52', SecondAction::class], |
||
| 146 | ['http://apparat/blog/*/*/*/*/*/*', SecondAction::class], |
||
| 147 | |||
| 148 | ['http://apparat/blog/2016/06/08/19/14/52/1', ObjectAction::class], |
||
| 149 | ['http://apparat/blog/2016/06/08/19/14/52/.1', ObjectAction::class], |
||
| 150 | ['http://apparat/blog/2016/06/08/19/14/52/1-article', ObjectAction::class], |
||
| 151 | ['http://apparat/blog/2016/06/08/19/14/52/1-*', ObjectAction::class], |
||
| 152 | ['http://apparat/blog/2016/06/08/19/14/52/.1-article', ObjectAction::class], |
||
| 153 | ['http://apparat/blog/2016/06/08/19/14/52/1-article/1', ObjectAction::class], |
||
| 154 | ['http://apparat/blog/2016/06/08/19/14/52/1-article/*', ObjectAction::class], |
||
| 155 | ['http://apparat/blog/2016/06/08/19/14/52/1-article/.1', ObjectAction::class], |
||
| 156 | ['http://apparat/blog/2016/06/08/19/14/52/1-article/.*', ObjectAction::class], |
||
| 157 | ['http://apparat/blog/2016/06/08/19/14/52/1-*/1', ObjectAction::class], |
||
| 158 | ['http://apparat/blog/2016/06/08/19/14/52/1-*/*', ObjectAction::class], |
||
| 159 | ['http://apparat/blog/2016/06/08/19/14/52/1-*/.1', ObjectAction::class], |
||
| 160 | ['http://apparat/blog/2016/06/08/19/14/52/1-*/.*', ObjectAction::class], |
||
| 161 | ['http://apparat/blog/2016/06/08/19/14/52/1-article/1-1', ObjectAction::class], |
||
| 162 | ['http://apparat/blog/2016/06/08/19/14/52/1-article/1-*', ObjectAction::class], |
||
| 163 | ['http://apparat/blog/2016/06/08/19/14/52/1-article/.1-1', ObjectAction::class], |
||
| 164 | ['http://apparat/blog/2016/06/08/19/14/52/1-article/.1-*', ObjectAction::class], |
||
| 165 | ['http://apparat/blog/2016/06/08/19/14/52/1-article/*-1', ObjectAction::class], |
||
| 166 | ['http://apparat/blog/2016/06/08/19/14/52/1-article/*-*', ObjectAction::class], |
||
| 167 | ['http://apparat/blog/2016/06/08/19/14/52/1-article/.*-1', ObjectAction::class], |
||
| 168 | ['http://apparat/blog/2016/06/08/19/14/52/1-article/.*-*', ObjectAction::class], |
||
| 169 | ['http://apparat/blog/2016/06/08/19/14/52/1-article/1.md', ObjectAction::class], |
||
| 170 | ['http://apparat/blog/2016/06/08/19/14/52/1-article/1-1.md', ObjectAction::class], |
||
| 171 | ['http://apparat/blog/2016/06/08/19/14/52/1-article/.1.md', ObjectAction::class], |
||
| 172 | ['http://apparat/blog/2016/06/08/19/14/52/1-article/.1-1.md', ObjectAction::class], |
||
| 173 | ['http://apparat/blog/2016/06/08/19/14/52/1-article/*.md', ObjectAction::class], |
||
| 174 | ['http://apparat/blog/2016/06/08/19/14/52/1-article/*-1.md', ObjectAction::class], |
||
| 175 | ['http://apparat/blog/2016/06/08/19/14/52/1-article/.*.md', ObjectAction::class], |
||
| 176 | ['http://apparat/blog/2016/06/08/19/14/52/1-article/.*-1.md', ObjectAction::class], |
||
| 177 | ['http://apparat/blog/2016/06/08/19/14/52/1-article/1-*.md', ObjectAction::class], |
||
| 178 | ['http://apparat/blog/2016/06/08/19/14/52/1-article/*-1.md', ObjectAction::class], |
||
| 179 | ['http://apparat/blog/2016/06/08/19/14/52/1-article/.1-*.md', ObjectAction::class], |
||
| 180 | ['http://apparat/blog/2016/06/08/19/14/52/1-article/.*-*.md', ObjectAction::class], |
||
| 181 | |||
| 182 | ['http://apparat/blog/2016/06/08/19/14/52/*-article', TypeAction::class], |
||
| 183 | ['http://apparat/blog/2016/06/08/19/14/52/.*-article', TypeAction::class], |
||
| 184 | ['http://apparat/blog/2016/06/08/19/14/52/*-article/*', TypeAction::class], |
||
| 185 | ['http://apparat/blog/2016/06/08/19/14/52/*-article/.*', TypeAction::class], |
||
| 186 | ['http://apparat/blog/2016/06/08/19/14/52/*-article/*-1', TypeAction::class], |
||
| 187 | ['http://apparat/blog/2016/06/08/19/14/52/*-article/*-*', TypeAction::class], |
||
| 188 | ['http://apparat/blog/2016/06/08/19/14/52/*-article/.*-1', TypeAction::class], |
||
| 189 | ['http://apparat/blog/2016/06/08/19/14/52/*-article/.*-*', TypeAction::class], |
||
| 190 | ['http://apparat/blog/2016/06/08/19/14/52/*-article/*.md', TypeAction::class], |
||
| 191 | ['http://apparat/blog/2016/06/08/19/14/52/*-article/*-1.md', TypeAction::class], |
||
| 192 | ['http://apparat/blog/2016/06/08/19/14/52/*-article/.*.md', TypeAction::class], |
||
| 193 | ['http://apparat/blog/2016/06/08/19/14/52/*-article/.*-1.md', TypeAction::class], |
||
| 194 | ['http://apparat/blog/2016/06/08/19/14/52/*-article/*-1.md', TypeAction::class], |
||
| 195 | ['http://apparat/blog/2016/06/08/19/14/52/*-article/.*-*.md', TypeAction::class], |
||
| 196 | |||
| 197 | ['http://apparat/blog/2016/06/08/19/14/52/*', ObjectsAction::class], |
||
| 198 | ['http://apparat/blog/2016/06/08/19/14/52/*-*', ObjectsAction::class], |
||
| 199 | ['http://apparat/blog/2016/06/08/19/14/52/.*', ObjectsAction::class], |
||
| 200 | ['http://apparat/blog/2016/06/08/19/14/52/*/*', ObjectsAction::class], |
||
| 201 | ['http://apparat/blog/2016/06/08/19/14/52/*/.*', ObjectsAction::class], |
||
| 202 | ['http://apparat/blog/2016/06/08/19/14/52/*-*/*', ObjectsAction::class], |
||
| 203 | ['http://apparat/blog/2016/06/08/19/14/52/*-*/.*', ObjectsAction::class], |
||
| 204 | ['http://apparat/blog/2016/06/08/19/14/52/*-*/*-1', ObjectsAction::class], |
||
| 205 | ['http://apparat/blog/2016/06/08/19/14/52/*-*/*-*', ObjectsAction::class], |
||
| 206 | ['http://apparat/blog/2016/06/08/19/14/52/*-*/.*-1', ObjectsAction::class], |
||
| 207 | ['http://apparat/blog/2016/06/08/19/14/52/*-*/.*-*', ObjectsAction::class], |
||
| 208 | ['http://apparat/blog/2016/06/08/19/14/52/*-*/*.md', ObjectsAction::class], |
||
| 209 | ['http://apparat/blog/2016/06/08/19/14/52/*-*/*-1.md', ObjectsAction::class], |
||
| 210 | ['http://apparat/blog/2016/06/08/19/14/52/*-*/.*.md', ObjectsAction::class], |
||
| 211 | ['http://apparat/blog/2016/06/08/19/14/52/*-*/.*-1.md', ObjectsAction::class], |
||
| 212 | ['http://apparat/blog/2016/06/08/19/14/52/*-*/*-1.md', ObjectsAction::class], |
||
| 213 | ['http://apparat/blog/2016/06/08/19/14/52/*-*/.*-*.md', ObjectsAction::class], |
||
| 214 | ]; |
||
| 215 | |||
| 216 | // |
||
| 217 | } |
||
| 218 | |||
| 236 |
This check looks for assignments to scalar types that may be of the wrong type.
To ensure the code behaves as expected, it may be a good idea to add an explicit type cast.