ObjectRoutesTest::getObjectRouteRequestAction() - Code Metrics - Inspection of "Improved code coverage" - apparat/server - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 9ce6e7...ad5412 )

by Joschi

created 2016-07-19 11:19 UTC

ObjectRoutesTest::getObjectRouteRequestAction() B

↳ Parent: ObjectRoutesTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	81
Code Lines	70

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	81
rs	8.8076
cc	1
eloc	70
nc	1
nop	0

How to fix Long Method

<?php

/**
 * apparat-server
 *
 * @category    Apparat
 * @package     Apparat\Server
 * @subpackage  Apparat\Server\Tests
 * @author      Joschi Kuphal <[email protected]> / @jkphl
 * @copyright   Copyright © 2016 Joschi Kuphal <[email protected]> / @jkphl
 * @license     http://opensource.org/licenses/MIT The MIT License (MIT)
 */

/***********************************************************************************
 *  The MIT License (MIT)
 *
 *  Copyright © 2016 Joschi Kuphal <[email protected]> / @jkphl
 *
 *  Permission is hereby granted, free of charge, to any person obtaining a copy of
 *  this software and associated documentation files (the "Software"), to deal in
 *  the Software without restriction, including without limitation the rights to
 *  use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of
 *  the Software, and to permit persons to whom the Software is furnished to do so,
 *  subject to the following conditions:
 *
 *  The above copyright notice and this permission notice shall be included in all
 *  copies or substantial portions of the Software.
 *
 *  THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 *  IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS
 *  FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR
 *  COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER
 *  IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
 *  CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
 ***********************************************************************************/

namespace Apparat\Server\Tests;

use Apparat\Kernel\Ports\Kernel;
use Apparat\Server\Infrastructure\Action\DayAction;
use Apparat\Server\Infrastructure\Action\HourAction;
use Apparat\Server\Infrastructure\Action\MinuteAction;
use Apparat\Server\Infrastructure\Action\MonthAction;
use Apparat\Server\Infrastructure\Action\ObjectAction;
use Apparat\Server\Infrastructure\Action\ObjectsAction;
use Apparat\Server\Infrastructure\Action\SecondAction;
use Apparat\Server\Infrastructure\Action\TypeAction;
use Apparat\Server\Infrastructure\Action\YearAction;
use Apparat\Server\Infrastructure\Model\Server;
use Apparat\Server\Infrastructure\Route\AuraObjectRoute;
use Zend\Diactoros\ServerRequest;
use Zend\Diactoros\Uri;

/**
 * Default routes test
 *
 * @package Apparat\Server
 * @subpackage Apparat\Server\Tests
 */
class ObjectRoutesTest extends AbstractServerTest
{
    /**
     * Server instance
     *
     * @var Server
     */
    protected static $server = null;
    /**
     * Configured object date precision
     *
     * @var int
     */
    protected static $objectDatePrecision;

    /**
     * This method is called before the first test of this test class is run.
     *
     * @since Method available since Release 3.4.0
     */
    public static function setUpBeforeClass()
    {
        parent::setUpBeforeClass();

        self::$objectDatePrecision = intval(getenv('OBJECT_DATE_PRECISION'));
        putenv('OBJECT_DATE_PRECISION=6');

        self::$server = Kernel::create(Server::class);
    }

    /**
     * This method is called after the last test of this test class is run.
     *
     * @since Method available since Release 3.4.0
     */
    public static function tearDownAfterClass()
    {
        parent::tearDownAfterClass();
        putenv('OBJECT_DATE_PRECISION='.self::$objectDatePrecision);
    }

    /**
     * Test enabling the object route
     */
    public function testEnableObjectRoute()
    {
        // Enable the object route
        self::$server->enableObjectRoute();
    }

    /**
     * Test dispatching default route requests to actions
     *
     * @dataProvider getObjectRouteRequestAction
     * @param string $request Server request
     * @param string $actionClass Action class
     */
    public function testObjectRouteAction($request, $actionClass)
    {
        $uri = new Uri($request);
        $request = new ServerRequest();
        $request = $request->withUri($uri);

        // Dispatch the route
        $route = self::$server->dispatchRequestToRoute($request);
        $this->assertInstanceOf(AuraObjectRoute::class, $route);

        // Get the associated action
        $action = self::$server->getRouteAction($request, $route);
        $this->assertInstanceOf($actionClass, $action);
    }

    /**
     * Provide default route requests and expected action classes
     */
    public function getObjectRouteRequestAction()
    {
        return [
            ['http://apparat/blog/2016', YearAction::class],
            ['http://apparat/blog/*', YearAction::class],

            ['http://apparat/blog/2016/06', MonthAction::class],
            ['http://apparat/blog/*/*', MonthAction::class],

            ['http://apparat/blog/2016/06/08', DayAction::class],
            ['http://apparat/blog/*/*/*', DayAction::class],

            ['http://apparat/blog/2016/06/08/19', HourAction::class],
            ['http://apparat/blog/*/*/*/*', HourAction::class],

            ['http://apparat/blog/2016/06/08/19/14', MinuteAction::class],
            ['http://apparat/blog/*/*/*/*/*', MinuteAction::class],

            ['http://apparat/blog/2016/06/08/19/14/52', SecondAction::class],
            ['http://apparat/blog/*/*/*/*/*/*', SecondAction::class],

            ['http://apparat/blog/2016/06/08/19/14/52/1', ObjectAction::class],
            ['http://apparat/blog/2016/06/08/19/14/52/.1', ObjectAction::class],
            ['http://apparat/blog/2016/06/08/19/14/52/~1', ObjectAction::class],
            ['http://apparat/blog/2016/06/08/19/14/52/1-article', ObjectAction::class],
            ['http://apparat/blog/2016/06/08/19/14/52/1-*', ObjectAction::class],
            ['http://apparat/blog/2016/06/08/19/14/52/.1-article', ObjectAction::class],
            ['http://apparat/blog/2016/06/08/19/14/52/~1-article', ObjectAction::class],
            ['http://apparat/blog/2016/06/08/19/14/52/1-article/1', ObjectAction::class],
            ['http://apparat/blog/2016/06/08/19/14/52/1-article/*', ObjectAction::class],
            ['http://apparat/blog/2016/06/08/19/14/52/1-article/.1', ObjectAction::class],
            ['http://apparat/blog/2016/06/08/19/14/52/1-article/.*', ObjectAction::class],
            ['http://apparat/blog/2016/06/08/19/14/52/1-*/1', ObjectAction::class],
            ['http://apparat/blog/2016/06/08/19/14/52/1-*/*', ObjectAction::class],
            ['http://apparat/blog/2016/06/08/19/14/52/1-*/.1', ObjectAction::class],
            ['http://apparat/blog/2016/06/08/19/14/52/1-*/.*', ObjectAction::class],
            ['http://apparat/blog/2016/06/08/19/14/52/1-*/~1', ObjectAction::class],
            ['http://apparat/blog/2016/06/08/19/14/52/1-*/~*', ObjectAction::class],
            ['http://apparat/blog/2016/06/08/19/14/52/1-article/1-1', ObjectAction::class],
            ['http://apparat/blog/2016/06/08/19/14/52/1-article/.1-1', ObjectAction::class],
            ['http://apparat/blog/2016/06/08/19/14/52/1-article/~1-1', ObjectAction::class],
            ['http://apparat/blog/2016/06/08/19/14/52/1-article/*-1', ObjectAction::class],
            ['http://apparat/blog/2016/06/08/19/14/52/1-article/.*-1', ObjectAction::class],
            ['http://apparat/blog/2016/06/08/19/14/52/1-article/~*-1', ObjectAction::class],

            ['http://apparat/blog/2016/06/08/19/14/52/*-article', TypeAction::class],
            ['http://apparat/blog/2016/06/08/19/14/52/.*-article', TypeAction::class],
            ['http://apparat/blog/2016/06/08/19/14/52/~*-article', TypeAction::class],
            ['http://apparat/blog/2016/06/08/19/14/52/*-article/*', TypeAction::class],
            ['http://apparat/blog/2016/06/08/19/14/52/*-article/.*', TypeAction::class],
            ['http://apparat/blog/2016/06/08/19/14/52/*-article/~*', TypeAction::class],
            ['http://apparat/blog/2016/06/08/19/14/52/*-article/*-1', TypeAction::class],
            ['http://apparat/blog/2016/06/08/19/14/52/*-article/*-*', TypeAction::class],
            ['http://apparat/blog/2016/06/08/19/14/52/*-article/.*-1', TypeAction::class],
            ['http://apparat/blog/2016/06/08/19/14/52/*-article/.*-*', TypeAction::class],
            ['http://apparat/blog/2016/06/08/19/14/52/*-article/~*-1', TypeAction::class],
            ['http://apparat/blog/2016/06/08/19/14/52/*-article/~*-*', TypeAction::class],

            ['http://apparat/blog/2016/06/08/19/14/52/*', ObjectsAction::class],
            ['http://apparat/blog/2016/06/08/19/14/52/*-*', ObjectsAction::class],
            ['http://apparat/blog/2016/06/08/19/14/52/.*', ObjectsAction::class],
            ['http://apparat/blog/2016/06/08/19/14/52/~*', ObjectsAction::class],
            ['http://apparat/blog/2016/06/08/19/14/52/*/*', ObjectsAction::class],
            ['http://apparat/blog/2016/06/08/19/14/52/*/.*', ObjectsAction::class],
            ['http://apparat/blog/2016/06/08/19/14/52/*-*/*', ObjectsAction::class],
            ['http://apparat/blog/2016/06/08/19/14/52/*-*/.*', ObjectsAction::class],
            ['http://apparat/blog/2016/06/08/19/14/52/*-*/~*', ObjectsAction::class],
            ['http://apparat/blog/2016/06/08/19/14/52/*-*/*-1', ObjectsAction::class],
            ['http://apparat/blog/2016/06/08/19/14/52/*-*/*-*', ObjectsAction::class],
            ['http://apparat/blog/2016/06/08/19/14/52/*-*/.*-1', ObjectsAction::class],
            ['http://apparat/blog/2016/06/08/19/14/52/*-*/.*-*', ObjectsAction::class],
            ['http://apparat/blog/2016/06/08/19/14/52/*-*/~*-1', ObjectsAction::class],
            ['http://apparat/blog/2016/06/08/19/14/52/*-*/~*-*', ObjectsAction::class],
            ['http://apparat/blog/2016/06/08/19/14/52/1-article/1-*', ObjectsAction::class],
            ['http://apparat/blog/2016/06/08/19/14/52/1-article/.1-*', ObjectsAction::class],
            ['http://apparat/blog/2016/06/08/19/14/52/1-article/~1-*', ObjectsAction::class],
            ['http://apparat/blog/2016/06/08/19/14/52/1-article/*-*', ObjectsAction::class],
            ['http://apparat/blog/2016/06/08/19/14/52/1-article/.*-*', ObjectsAction::class],
            ['http://apparat/blog/2016/06/08/19/14/52/1-article/~*-*', ObjectsAction::class],
        ];
    }
}


1			<?php
2
3			/**
4			* apparat-server
5			*
6			* @category Apparat
7			* @package Apparat\Server
8			* @subpackage Apparat\Server\Tests
9			* @author Joschi Kuphal <[email protected]> / @jkphl
10			* @copyright Copyright © 2016 Joschi Kuphal <[email protected]> / @jkphl
11			* @license http://opensource.org/licenses/MIT The MIT License (MIT)
12			*/
13
14			/***********************************************************************************
15			* The MIT License (MIT)
16			*
17			* Copyright © 2016 Joschi Kuphal <[email protected]> / @jkphl
18			*
19			* Permission is hereby granted, free of charge, to any person obtaining a copy of
20			* this software and associated documentation files (the "Software"), to deal in
21			* the Software without restriction, including without limitation the rights to
22			* use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of
23			* the Software, and to permit persons to whom the Software is furnished to do so,
24			* subject to the following conditions:
25			*
26			* The above copyright notice and this permission notice shall be included in all
27			* copies or substantial portions of the Software.
28			*
29			* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
30			* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS
31			* FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR
32			* COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER
33			* IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
34			* CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
35			***********************************************************************************/
36
37			namespace Apparat\Server\Tests;
38
39			use Apparat\Kernel\Ports\Kernel;
40			use Apparat\Server\Infrastructure\Action\DayAction;
41			use Apparat\Server\Infrastructure\Action\HourAction;
42			use Apparat\Server\Infrastructure\Action\MinuteAction;
43			use Apparat\Server\Infrastructure\Action\MonthAction;
44			use Apparat\Server\Infrastructure\Action\ObjectAction;
45			use Apparat\Server\Infrastructure\Action\ObjectsAction;
46			use Apparat\Server\Infrastructure\Action\SecondAction;
47			use Apparat\Server\Infrastructure\Action\TypeAction;
48			use Apparat\Server\Infrastructure\Action\YearAction;
49			use Apparat\Server\Infrastructure\Model\Server;
50			use Apparat\Server\Infrastructure\Route\AuraObjectRoute;
51			use Zend\Diactoros\ServerRequest;
52			use Zend\Diactoros\Uri;
53
54			/**
55			* Default routes test
56			*
57			* @package Apparat\Server
58			* @subpackage Apparat\Server\Tests
59			*/
60			class ObjectRoutesTest extends AbstractServerTest
61			{
62			/**
63			* Server instance
64			*
65			* @var Server
66			*/
67			protected static $server = null;
68			/**
69			* Configured object date precision
70			*
71			* @var int
72			*/
73			protected static $objectDatePrecision;
74
75			/**
76			* This method is called before the first test of this test class is run.
77			*
78			* @since Method available since Release 3.4.0
79			*/
80			public static function setUpBeforeClass()
81			{
82			parent::setUpBeforeClass();
83
84			self::$objectDatePrecision = intval(getenv('OBJECT_DATE_PRECISION'));
85			putenv('OBJECT_DATE_PRECISION=6');
86
87			self::$server = Kernel::create(Server::class);
88			}
89
90			/**
91			* This method is called after the last test of this test class is run.
92			*
93			* @since Method available since Release 3.4.0
94			*/
95			public static function tearDownAfterClass()
96			{
97			parent::tearDownAfterClass();
98			putenv('OBJECT_DATE_PRECISION='.self::$objectDatePrecision);
99			}
100
101			/**
102			* Test enabling the object route
103			*/
104			public function testEnableObjectRoute()
105			{
106			// Enable the object route
107			self::$server->enableObjectRoute();
108			}
109
110			/**
111			* Test dispatching default route requests to actions
112			*
113			* @dataProvider getObjectRouteRequestAction
114			* @param string $request Server request
115			* @param string $actionClass Action class
116			*/
117			public function testObjectRouteAction($request, $actionClass)
118			{
119			$uri = new Uri($request);
120			$request = new ServerRequest();
121			$request = $request->withUri($uri);
122
123			// Dispatch the route
124			$route = self::$server->dispatchRequestToRoute($request);
125			$this->assertInstanceOf(AuraObjectRoute::class, $route);
126
127			// Get the associated action
128			$action = self::$server->getRouteAction($request, $route);
129			$this->assertInstanceOf($actionClass, $action);
130			}
131
132			/**
133			* Provide default route requests and expected action classes
134			*/
135			public function getObjectRouteRequestAction()
136			{
137			return [
138			['http://apparat/blog/2016', YearAction::class],
139			['http://apparat/blog/*', YearAction::class],
140
141			['http://apparat/blog/2016/06', MonthAction::class],
142			['http://apparat/blog//', MonthAction::class],
143
144			['http://apparat/blog/2016/06/08', DayAction::class],
145			['http://apparat/blog///*', DayAction::class],
146
147			['http://apparat/blog/2016/06/08/19', HourAction::class],
148			['http://apparat/blog////', HourAction::class],
149
150			['http://apparat/blog/2016/06/08/19/14', MinuteAction::class],
151			['http://apparat/blog/////*', MinuteAction::class],
152
153			['http://apparat/blog/2016/06/08/19/14/52', SecondAction::class],
154			['http://apparat/blog//////', SecondAction::class],
155
156			['http://apparat/blog/2016/06/08/19/14/52/1', ObjectAction::class],
157			['http://apparat/blog/2016/06/08/19/14/52/.1', ObjectAction::class],
158			['http://apparat/blog/2016/06/08/19/14/52/~1', ObjectAction::class],
159			['http://apparat/blog/2016/06/08/19/14/52/1-article', ObjectAction::class],
160			['http://apparat/blog/2016/06/08/19/14/52/1-*', ObjectAction::class],
161			['http://apparat/blog/2016/06/08/19/14/52/.1-article', ObjectAction::class],
162			['http://apparat/blog/2016/06/08/19/14/52/~1-article', ObjectAction::class],
163			['http://apparat/blog/2016/06/08/19/14/52/1-article/1', ObjectAction::class],
164			['http://apparat/blog/2016/06/08/19/14/52/1-article/*', ObjectAction::class],
165			['http://apparat/blog/2016/06/08/19/14/52/1-article/.1', ObjectAction::class],
166			['http://apparat/blog/2016/06/08/19/14/52/1-article/.*', ObjectAction::class],
167			['http://apparat/blog/2016/06/08/19/14/52/1-*/1', ObjectAction::class],
168			['http://apparat/blog/2016/06/08/19/14/52/1-/', ObjectAction::class],
169			['http://apparat/blog/2016/06/08/19/14/52/1-*/.1', ObjectAction::class],
170			['http://apparat/blog/2016/06/08/19/14/52/1-/.', ObjectAction::class],
171			['http://apparat/blog/2016/06/08/19/14/52/1-*/~1', ObjectAction::class],
172			['http://apparat/blog/2016/06/08/19/14/52/1-/~', ObjectAction::class],
173			['http://apparat/blog/2016/06/08/19/14/52/1-article/1-1', ObjectAction::class],
174			['http://apparat/blog/2016/06/08/19/14/52/1-article/.1-1', ObjectAction::class],
175			['http://apparat/blog/2016/06/08/19/14/52/1-article/~1-1', ObjectAction::class],
176			['http://apparat/blog/2016/06/08/19/14/52/1-article/*-1', ObjectAction::class],
177			['http://apparat/blog/2016/06/08/19/14/52/1-article/.*-1', ObjectAction::class],
178			['http://apparat/blog/2016/06/08/19/14/52/1-article/~*-1', ObjectAction::class],
179
180			['http://apparat/blog/2016/06/08/19/14/52/*-article', TypeAction::class],
181			['http://apparat/blog/2016/06/08/19/14/52/.*-article', TypeAction::class],
182			['http://apparat/blog/2016/06/08/19/14/52/~*-article', TypeAction::class],
183			['http://apparat/blog/2016/06/08/19/14/52/-article/', TypeAction::class],
184			['http://apparat/blog/2016/06/08/19/14/52/-article/.', TypeAction::class],
185			['http://apparat/blog/2016/06/08/19/14/52/-article/~', TypeAction::class],
186			['http://apparat/blog/2016/06/08/19/14/52/-article/-1', TypeAction::class],
187			['http://apparat/blog/2016/06/08/19/14/52/-article/-*', TypeAction::class],
188			['http://apparat/blog/2016/06/08/19/14/52/-article/.-1', TypeAction::class],
189			['http://apparat/blog/2016/06/08/19/14/52/-article/.-*', TypeAction::class],
190			['http://apparat/blog/2016/06/08/19/14/52/-article/~-1', TypeAction::class],
191			['http://apparat/blog/2016/06/08/19/14/52/-article/~-*', TypeAction::class],
192
193			['http://apparat/blog/2016/06/08/19/14/52/*', ObjectsAction::class],
194			['http://apparat/blog/2016/06/08/19/14/52/-', ObjectsAction::class],
195			['http://apparat/blog/2016/06/08/19/14/52/.*', ObjectsAction::class],
196			['http://apparat/blog/2016/06/08/19/14/52/~*', ObjectsAction::class],
197			['http://apparat/blog/2016/06/08/19/14/52//', ObjectsAction::class],
198			['http://apparat/blog/2016/06/08/19/14/52//.', ObjectsAction::class],
199			['http://apparat/blog/2016/06/08/19/14/52/-/*', ObjectsAction::class],
200			['http://apparat/blog/2016/06/08/19/14/52/-/.*', ObjectsAction::class],
201			['http://apparat/blog/2016/06/08/19/14/52/-/~*', ObjectsAction::class],
202			['http://apparat/blog/2016/06/08/19/14/52/-/*-1', ObjectsAction::class],
203			['http://apparat/blog/2016/06/08/19/14/52/-/-', ObjectsAction::class],
204			['http://apparat/blog/2016/06/08/19/14/52/-/.*-1', ObjectsAction::class],
205			['http://apparat/blog/2016/06/08/19/14/52/-/.-', ObjectsAction::class],
206			['http://apparat/blog/2016/06/08/19/14/52/-/~*-1', ObjectsAction::class],
207			['http://apparat/blog/2016/06/08/19/14/52/-/~-', ObjectsAction::class],
208			['http://apparat/blog/2016/06/08/19/14/52/1-article/1-*', ObjectsAction::class],
209			['http://apparat/blog/2016/06/08/19/14/52/1-article/.1-*', ObjectsAction::class],
210			['http://apparat/blog/2016/06/08/19/14/52/1-article/~1-*', ObjectsAction::class],
211			['http://apparat/blog/2016/06/08/19/14/52/1-article/-', ObjectsAction::class],
212			['http://apparat/blog/2016/06/08/19/14/52/1-article/.-', ObjectsAction::class],
213			['http://apparat/blog/2016/06/08/19/14/52/1-article/~-', ObjectsAction::class],
214			];
215			}
216			}
217

apparat / server

Push — master ( 9ce6e7...ad5412 )

ObjectRoutesTest::getObjectRouteRequestAction() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like