AutoConnector::connect() - Code Metrics - Inspection of "Improved code climate" - apparat/object - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 61dfa4...99686d )

by Joschi

created 2016-03-01 23:30 UTC

AutoConnector::connect() D

↳ Parent: AutoConnector

Complexity

Conditions	10
Paths	10

Size

Total Lines	37
Code Lines	17

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	17
CRAP Score	10.017

Importance

Changes	6
Bugs	1	Features	1

Metric	Value
c	6
b	1
f	1
dl	0
loc	37
ccs	17
cts	18
cp	0.9444
rs	4.8196
cc	10
eloc	17
nc	10
nop	1
crap	10.017

How to fix Complexity

<?php

/**
 * apparat-object
 *
 * @category    Apparat
 * @package     Apparat\Object
 * @subpackage  Apparat\Object\Infrastructure
 * @author      Joschi Kuphal <[email protected]> / @jkphl
 * @copyright   Copyright © 2016 Joschi Kuphal <[email protected]> / @jkphl
 * @license     http://opensource.org/licenses/MIT The MIT License (MIT)
 */

/***********************************************************************************
 *  The MIT License (MIT)
 *
 *  Copyright © 2016 Joschi Kuphal <[email protected]> / @jkphl
 *
 *  Permission is hereby granted, free of charge, to any person obtaining a copy of
 *  this software and associated documentation files (the "Software"), to deal in
 *  the Software without restriction, including without limitation the rights to
 *  use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of
 *  the Software, and to permit persons to whom the Software is furnished to do so,
 *  subject to the following conditions:
 *
 *  The above copyright notice and this permission notice shall be included in all
 *  copies or substantial portions of the Software.
 *
 *  THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 *  IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS
 *  FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR
 *  COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER
 *  IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
 *  CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
 ***********************************************************************************/

namespace Apparat\Object\Infrastructure\Repository;


use Apparat\Object\Domain\Model\Path\Url;
use Apparat\Object\Domain\Repository\AutoConnectorInterface;
use Apparat\Object\Ports\Repository;

/**
 * Repository auto-connector service
 *
 * @package Apparat\Object
 * @subpackage Apparat\Object\Infrastructure
 */
class AutoConnector implements AutoConnectorInterface
{

    /**
     * Auto-connect a repository with URL default settings
     *
     * @param string $url Repository URL
     * @return boolean Success
     */
    public function connect($url)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $config = null;

        // If it's an absolute URL
        $url = new Url($url);
        if ($url->isAbsolute()) {
            // TODO: Absolute connection

            // Else: Relative / local URL -> Instantiate as file repository
        } else {
            // If this is run via CLI
            if (php_sapi_name() == 'cli') {
                $documentRoot = realpath(getenv('APPARAT_DOCUMENT_ROOT') ?: (ini_get('doc_root') ?: getcwd()));

                // Else: Use the server's document root
            } else {
                $documentRoot = realpath(empty($_SERVER['DOCUMENT_ROOT']) ? (getenv('APPARAT_DOCUMENT_ROOT') ?: (ini_get('doc_root') ?: getcwd())) : $_SERVER['DOCUMENT_ROOT']);
            }

            // If the is a document root: Create a file repository configuration
            if (strlen($documentRoot)) {
                $config = [
                    'type' => FileAdapterStrategy::TYPE,
                    'root' => rtrim($documentRoot, DIRECTORY_SEPARATOR) . DIRECTORY_SEPARATOR . $url,
                ];
            }
        }

        // If a repository configuration has been created
        if ($config !== null) {
            $repository = Repository::register(strval($url), $config);
            return $repository instanceof \Apparat\Object\Domain\Repository\Repository;
        }

        return true;
    }
}


1		<?php
2
3		/**
4		* apparat-object
5		*
6		* @category Apparat
7		* @package Apparat\Object
8		* @subpackage Apparat\Object\Infrastructure
9		* @author Joschi Kuphal <[email protected]> / @jkphl
10		* @copyright Copyright © 2016 Joschi Kuphal <[email protected]> / @jkphl
11		* @license http://opensource.org/licenses/MIT The MIT License (MIT)
12		*/
13
14		/***********************************************************************************
15		* The MIT License (MIT)
16		*
17		* Copyright © 2016 Joschi Kuphal <[email protected]> / @jkphl
18		*
19		* Permission is hereby granted, free of charge, to any person obtaining a copy of
20		* this software and associated documentation files (the "Software"), to deal in
21		* the Software without restriction, including without limitation the rights to
22		* use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of
23		* the Software, and to permit persons to whom the Software is furnished to do so,
24		* subject to the following conditions:
25		*
26		* The above copyright notice and this permission notice shall be included in all
27		* copies or substantial portions of the Software.
28		*
29		* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
30		* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS
31		* FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR
32		* COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER
33		* IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
34		* CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
35		***********************************************************************************/
36
37		namespace Apparat\Object\Infrastructure\Repository;
38
39
40		use Apparat\Object\Domain\Model\Path\Url;
41		use Apparat\Object\Domain\Repository\AutoConnectorInterface;
42		use Apparat\Object\Ports\Repository;
43
44		/**
45		* Repository auto-connector service
46		*
47		* @package Apparat\Object
48		* @subpackage Apparat\Object\Infrastructure
49		*/
50		class AutoConnector implements AutoConnectorInterface
51		{
52
53		/**
54		* Auto-connect a repository with URL default settings
55		*
56		* @param string $url Repository URL
57		* @return boolean Success
58		*/
59	3	public function connect($url)
		0 ignored issues – show Coding Style introduced 2016-02-06 22:26 UTC by Report Bug Copy Issue Report `connect` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
60		{
61	3	$config = null;
62
63		// If it's an absolute URL
64	3	$url = new Url($url);
65	3	if ($url->isAbsolute()) {
66		// TODO: Absolute connection
67
68		// Else: Relative / local URL -> Instantiate as file repository
69	1	} else {
70		// If this is run via CLI
71	2	if (php_sapi_name() == 'cli') {
72	2	$documentRoot = realpath(getenv('APPARAT_DOCUMENT_ROOT') ?: (ini_get('doc_root') ?: getcwd()));
73
74		// Else: Use the server's document root
75	2	} else {
76		$documentRoot = realpath(empty($_SERVER['DOCUMENT_ROOT']) ? (getenv('APPARAT_DOCUMENT_ROOT') ?: (ini_get('doc_root') ?: getcwd())) : $_SERVER['DOCUMENT_ROOT']);
77		}
78
79		// If the is a document root: Create a file repository configuration
80	2	if (strlen($documentRoot)) {
81		$config = [
82	2	'type' => FileAdapterStrategy::TYPE,
83	2	'root' => rtrim($documentRoot, DIRECTORY_SEPARATOR) . DIRECTORY_SEPARATOR . $url,
84	2	];
85	2	}
86		}
87
88		// If a repository configuration has been created
89	3	if ($config !== null) {
90	2	$repository = Repository::register(strval($url), $config);
91	2	return $repository instanceof \Apparat\Object\Domain\Repository\Repository;
92		}
93
94	1	return true;
95		}
96		}
97

apparat / object

Push — master ( 61dfa4...99686d )

AutoConnector::connect() D

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like