AutoConnector - Code Metrics - Inspection of "Refactored module structure" - apparat/object - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 4455f5...4b418f )

by Joschi

created 2016-02-07 19:38 UTC

AutoConnector A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	48
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	7
c	1
b	0
f	0
lcom	0
cbo	1
dl	0
loc	48
rs	10

1 Method

Rating	Name	Duplication	Size	Complexity
C	connect()	0	38	7

<?php

/**
 * apparat-object
 *
 * @category    Apparat
 * @package     Apparat\Object
 * @subpackage  Apparat\Object\Infrastructure
 * @author      Joschi Kuphal <[email protected]> / @jkphl
 * @copyright   Copyright © 2016 Joschi Kuphal <[email protected]> / @jkphl
 * @license     http://opensource.org/licenses/MIT	The MIT License (MIT)

 */

/***********************************************************************************
 *  The MIT License (MIT)
 *
 *  Copyright © 2016 Joschi Kuphal <[email protected]> / @jkphl
 *
 *  Permission is hereby granted, free of charge, to any person obtaining a copy of
 *  this software and associated documentation files (the "Software"), to deal in
 *  the Software without restriction, including without limitation the rights to
 *  use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of
 *  the Software, and to permit persons to whom the Software is furnished to do so,
 *  subject to the following conditions:
 *
 *  The above copyright notice and this permission notice shall be included in all
 *  copies or substantial portions of the Software.
 *
 *  THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 *  IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS
 *  FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR
 *  COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER
 *  IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
 *  CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
 ***********************************************************************************/

namespace Apparat\Object\Infrastructure\Repository;


use Apparat\Object\Domain\Model\Path\Url;
use Apparat\Object\Domain\Repository\AutoConnectorInterface;
use Apparat\Object\Ports\Repository;

/**
 * Repository auto-connector service
 *
 * @package Apparat\Object
 * @subpackage Apparat\Object\Infrastructure
 */
class AutoConnector implements AutoConnectorInterface
{

    /**
     * Auto-connect a repository with by URL default settings
     *
     * @param string $url Repository URL
     * @return boolean Success
     */
    public function connect($url)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        echo "Auto-connecting: $url\n";
        $config = null;

        // If it's an absolute URL
        $url = new Url($url);
        if ($url->isAbsolute()) {


            // Else: Relative / local URL -> Instantiate as file repository
        } else {

            // If this is run via CLI
            if (PHP_SAPI == 'cli') {
                $documentRoot = ini_get('doc_root') ?: getcwd();

                // Else: Use the server's document root
            } else {
                $documentRoot = empty($_SERVER['DOCUMENT_ROOT']) ? ini_get('doc_root') : $_SERVER['DOCUMENT_ROOT'];
            }

            // If the is a document root: Create a file repository configuration
            if (strlen($documentRoot)) {
                $config = [
                    'type' => FileAdapterStrategy::TYPE,
                    'root' => rtrim($documentRoot, DIRECTORY_SEPARATOR).DIRECTORY_SEPARATOR.$url,
                ];
            }
        }

        // If a repository configuration has been created
        if ($config !== null) {
            return Repository::register($url, $config) instanceof \Apparat\Object\Domain\Repository\Repository;
        }

        return true;
    }
}


1			<?php
2
3			/**
4			* apparat-object
5			*
6			* @category Apparat
7			* @package Apparat\Object
8			* @subpackage Apparat\Object\Infrastructure
9			* @author Joschi Kuphal <[email protected]> / @jkphl
10			* @copyright Copyright © 2016 Joschi Kuphal <[email protected]> / @jkphl
11			* @license http://opensource.org/licenses/MIT The MIT License (MIT)
			0 ignored issues – show Coding Style introduced 2016-02-07 19:45 UTC by Report Bug Copy Issue Report Spaces must be used for alignment; tabs are not allowed Loading history...
12			*/
13
14			/***********************************************************************************
15			* The MIT License (MIT)
16			*
17			* Copyright © 2016 Joschi Kuphal <[email protected]> / @jkphl
18			*
19			* Permission is hereby granted, free of charge, to any person obtaining a copy of
20			* this software and associated documentation files (the "Software"), to deal in
21			* the Software without restriction, including without limitation the rights to
22			* use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of
23			* the Software, and to permit persons to whom the Software is furnished to do so,
24			* subject to the following conditions:
25			*
26			* The above copyright notice and this permission notice shall be included in all
27			* copies or substantial portions of the Software.
28			*
29			* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
30			* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS
31			* FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR
32			* COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER
33			* IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
34			* CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
35			***********************************************************************************/
36
37			namespace Apparat\Object\Infrastructure\Repository;
38
39
40			use Apparat\Object\Domain\Model\Path\Url;
41			use Apparat\Object\Domain\Repository\AutoConnectorInterface;
42			use Apparat\Object\Ports\Repository;
43
44			/**
45			* Repository auto-connector service
46			*
47			* @package Apparat\Object
48			* @subpackage Apparat\Object\Infrastructure
49			*/
50			class AutoConnector implements AutoConnectorInterface
51			{
52
53			/**
54			* Auto-connect a repository with by URL default settings
55			*
56			* @param string $url Repository URL
57			* @return boolean Success
58			*/
59			public function connect($url)
			0 ignored issues – show Coding Style introduced 2016-02-06 22:26 UTC by Report Bug Copy Issue Report `connect` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
60			{
61			echo "Auto-connecting: $url\n";
62			$config = null;
63
64			// If it's an absolute URL
65			$url = new Url($url);
66			if ($url->isAbsolute()) {
67
68
69			// Else: Relative / local URL -> Instantiate as file repository
70			} else {
71
72			// If this is run via CLI
73			if (PHP_SAPI == 'cli') {
74			$documentRoot = ini_get('doc_root') ?: getcwd();
75
76			// Else: Use the server's document root
77			} else {
78			$documentRoot = empty($_SERVER['DOCUMENT_ROOT']) ? ini_get('doc_root') : $_SERVER['DOCUMENT_ROOT'];
79			}
80
81			// If the is a document root: Create a file repository configuration
82			if (strlen($documentRoot)) {
83			$config = [
84			'type' => FileAdapterStrategy::TYPE,
85			'root' => rtrim($documentRoot, DIRECTORY_SEPARATOR).DIRECTORY_SEPARATOR.$url,
86			];
87			}
88			}
89
90			// If a repository configuration has been created
91			if ($config !== null) {
92			return Repository::register($url, $config) instanceof \Apparat\Object\Domain\Repository\Repository;
93			}
94
95			return true;
96			}
97			}
98

apparat / object

Push — master ( 4455f5...4b418f )

AutoConnector A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

1 Method

Duplication Side-by-Side

Filter issues like