IterableTrait::next() - Code Metrics - Inspection of "Refactored draft mode, started object iteration" - apparat/object - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 2d5356...e3df84 )

by Joschi

created 2016-05-19 21:44 UTC

IterableTrait::next() A

↳ Parent: IterableTrait

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	3
c	1
b	0
f	0
nc	1
nop	0
dl	0
loc	5
ccs	0
cts	4
cp	0
crap	2
rs	9.4285

<?php

/**
 * apparat-object
 *
 * @category    Apparat
 * @package     Apparat\Object
 * @subpackage  Apparat\Object\Domain
 * @author      Joschi Kuphal <[email protected]> / @jkphl
 * @copyright   Copyright © 2016 Joschi Kuphal <[email protected]> / @jkphl
 * @license     http://opensource.org/licenses/MIT The MIT License (MIT)
 */

/***********************************************************************************
 *  The MIT License (MIT)
 *
 *  Copyright © 2016 Joschi Kuphal <[email protected]> / @jkphl
 *
 *  Permission is hereby granted, free of charge, to any person obtaining a copy of
 *  this software and associated documentation files (the "Software"), to deal in
 *  the Software without restriction, including without limitation the rights to
 *  use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of
 *  the Software, and to permit persons to whom the Software is furnished to do so,
 *  subject to the following conditions:
 *
 *  The above copyright notice and this permission notice shall be included in all
 *  copies or substantial portions of the Software.
 *
 *  THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 *  IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS
 *  FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR
 *  COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER
 *  IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
 *  CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
 ***********************************************************************************/

namespace Apparat\Object\Domain\Model\Object\Traits;

use Apparat\Kernel\Ports\Kernel;
use Apparat\Object\Domain\Model\Object\AbstractObject;
use Apparat\Object\Domain\Model\Object\ObjectInterface;
use Apparat\Object\Domain\Model\Object\Revision;

/**
 * Iterable trait
 *
 * @package Apparat\Object\Domain
 * @property Revision $currentRevision
 * @property AbstractObject $this
 */
trait IterableTrait
{
    /**
     * Return the current revision
     *
     * @return ObjectInterface Self reference
     */
    public function current()
    {
        echo "current\n";
        /** @var Revision $currentRevision */
        $currentRevision = Kernel::create(Revision::class, [$this->currentRevision->getRevision()]);
        return $this->useRevision($currentRevision);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * Forward to the next revision
     */
    public function next()
    {
        echo "next\n";
        $this->currentRevision = $this->currentRevision->increment();
    }

    /**
     * Return the current revision number
     *
     * @return int Current revision
     */
    public function key()
    {
        echo "key\n";
        return $this->currentRevision;
    }

    /**
     * Return whether the current revision is valid
     *
     * @return bool Current revision is valid
     */
    public function valid()
    {
        echo "valud\n";
        /** AbstractObject $this */
        return $this->currentRevision->getRevision() <= count($this);
    }

    /**
     * Rewind to the first revision
     */
    public function rewind()
    {
        echo "rewind\n";
        /** @var Revision $firstRevision */
        $firstRevision = Kernel::create(Revision::class, [1]);
        $this->useRevision($firstRevision);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * Return the number of available revisions
     *
     * @return int Number of available revisions
     */
    public function count()
    {
        /** AbstractObject $this */
        return $this->latestRevision->getRevision();
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }
}

1			<?php
2
3			/**
4			* apparat-object
5			*
6			* @category Apparat
7			* @package Apparat\Object
8			* @subpackage Apparat\Object\Domain
9			* @author Joschi Kuphal <[email protected]> / @jkphl
10			* @copyright Copyright © 2016 Joschi Kuphal <[email protected]> / @jkphl
11			* @license http://opensource.org/licenses/MIT The MIT License (MIT)
12			*/
13
14			/***********************************************************************************
15			* The MIT License (MIT)
16			*
17			* Copyright © 2016 Joschi Kuphal <[email protected]> / @jkphl
18			*
19			* Permission is hereby granted, free of charge, to any person obtaining a copy of
20			* this software and associated documentation files (the "Software"), to deal in
21			* the Software without restriction, including without limitation the rights to
22			* use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of
23			* the Software, and to permit persons to whom the Software is furnished to do so,
24			* subject to the following conditions:
25			*
26			* The above copyright notice and this permission notice shall be included in all
27			* copies or substantial portions of the Software.
28			*
29			* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
30			* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS
31			* FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR
32			* COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER
33			* IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
34			* CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
35			***********************************************************************************/
36
37			namespace Apparat\Object\Domain\Model\Object\Traits;
38
39			use Apparat\Kernel\Ports\Kernel;
40			use Apparat\Object\Domain\Model\Object\AbstractObject;
41			use Apparat\Object\Domain\Model\Object\ObjectInterface;
42			use Apparat\Object\Domain\Model\Object\Revision;
43
44			/**
45			* Iterable trait
46			*
47			* @package Apparat\Object\Domain
48			* @property Revision $currentRevision
49			* @property AbstractObject $this
50			*/
51			trait IterableTrait
52			{
53			/**
54			* Return the current revision
55			*
56			* @return ObjectInterface Self reference
57			*/
58			public function current()
59			{
60			echo "current\n";
61			/** @var Revision $currentRevision */
62			$currentRevision = Kernel::create(Revision::class, [$this->currentRevision->getRevision()]);
63			return $this->useRevision($currentRevision);
			0 ignored issues – show Bug introduced 2016-05-19 21:47 UTC by Report Bug Copy Issue Report It seems like `useRevision()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
64			}
65
66			/**
67			* Forward to the next revision
68			*/
69			public function next()
70			{
71			echo "next\n";
72			$this->currentRevision = $this->currentRevision->increment();
73			}
74
75			/**
76			* Return the current revision number
77			*
78			* @return int Current revision
79			*/
80			public function key()
81			{
82			echo "key\n";
83			return $this->currentRevision;
84			}
85
86			/**
87			* Return whether the current revision is valid
88			*
89			* @return bool Current revision is valid
90			*/
91			public function valid()
92			{
93			echo "valud\n";
94			/** AbstractObject $this */
95			return $this->currentRevision->getRevision() <= count($this);
96			}
97
98			/**
99			* Rewind to the first revision
100			*/
101			public function rewind()
102			{
103			echo "rewind\n";
104			/** @var Revision $firstRevision */
105			$firstRevision = Kernel::create(Revision::class, [1]);
106			$this->useRevision($firstRevision);
			0 ignored issues – show Bug introduced 2016-05-19 21:47 UTC by Report Bug Copy Issue Report It seems like `useRevision()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
107			}
108
109			/**
110			* Return the number of available revisions
111			*
112			* @return int Number of available revisions
113			*/
114			public function count()
115			{
116			/** AbstractObject $this */
117			return $this->latestRevision->getRevision();
			0 ignored issues – show Bug introduced 2016-05-19 21:47 UTC by Report Bug Copy Issue Report The property `latestRevision` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
118			}
119			}

apparat / object

Push — master ( 2d5356...e3df84 )

IterableTrait::next() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like