Complex classes like SystemProperties often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use SystemProperties, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 55 | class SystemProperties extends AbstractProperties |
||
| 56 | { |
||
| 57 | /** |
||
| 58 | * Collection name |
||
| 59 | * |
||
| 60 | * @var string |
||
| 61 | */ |
||
| 62 | const COLLECTION = 'system'; |
||
| 63 | /** |
||
| 64 | * ID property |
||
| 65 | * |
||
| 66 | * @var string |
||
| 67 | */ |
||
| 68 | const PROPERTY_ID = 'id'; |
||
| 69 | /** |
||
| 70 | * Type property |
||
| 71 | * |
||
| 72 | * @var string |
||
| 73 | */ |
||
| 74 | const PROPERTY_TYPE = 'type'; |
||
| 75 | /** |
||
| 76 | * Revision property |
||
| 77 | * |
||
| 78 | * @var string |
||
| 79 | */ |
||
| 80 | const PROPERTY_REVISION = 'revision'; |
||
| 81 | /** |
||
| 82 | * Created property |
||
| 83 | * |
||
| 84 | * @var string |
||
| 85 | */ |
||
| 86 | const PROPERTY_CREATED = 'created'; |
||
| 87 | /** |
||
| 88 | * Modified property |
||
| 89 | * |
||
| 90 | * @var string |
||
| 91 | */ |
||
| 92 | const PROPERTY_MODIFIED = 'modified'; |
||
| 93 | /** |
||
| 94 | * Published property |
||
| 95 | * |
||
| 96 | * @var string |
||
| 97 | */ |
||
| 98 | const PROPERTY_PUBLISHED = 'published'; |
||
| 99 | /** |
||
| 100 | * Deleted property |
||
| 101 | * |
||
| 102 | * @var string |
||
| 103 | */ |
||
| 104 | const PROPERTY_DELETED = 'deleted'; |
||
| 105 | /** |
||
| 106 | * Language property |
||
| 107 | * |
||
| 108 | * @var string |
||
| 109 | */ |
||
| 110 | const PROPERTY_LANGUAGE = 'language'; |
||
| 111 | /** |
||
| 112 | * Location property |
||
| 113 | * |
||
| 114 | * @var string |
||
| 115 | */ |
||
| 116 | const PROPERTY_LOCATION = 'location'; |
||
| 117 | /** |
||
| 118 | * Object ID (constant throughout revisions) |
||
| 119 | * |
||
| 120 | * @var Id |
||
| 121 | */ |
||
| 122 | protected $uid = null; |
||
| 123 | /** |
||
| 124 | * Object type (constant throughout revisions) |
||
| 125 | * |
||
| 126 | * @var Type |
||
| 127 | */ |
||
| 128 | protected $type = null; |
||
| 129 | /** |
||
| 130 | * Object revision |
||
| 131 | * |
||
| 132 | * @var Revision |
||
| 133 | */ |
||
| 134 | protected $revision = null; |
||
| 135 | /** |
||
| 136 | * Creation date of this revision |
||
| 137 | * |
||
| 138 | * @var \DateTimeImmutable |
||
| 139 | */ |
||
| 140 | protected $created = null; |
||
| 141 | /** |
||
| 142 | * Modification date of this revision |
||
| 143 | * |
||
| 144 | * @var \DateTimeImmutable |
||
| 145 | */ |
||
| 146 | protected $modified = null; |
||
| 147 | /** |
||
| 148 | * Publication date of this revision |
||
| 149 | * |
||
| 150 | * @var \DateTimeImmutable |
||
| 151 | */ |
||
| 152 | protected $published = null; |
||
| 153 | /** |
||
| 154 | * Deletion date of this revision |
||
| 155 | * |
||
| 156 | * @var \DateTimeImmutable |
||
| 157 | */ |
||
| 158 | protected $deleted = null; |
||
| 159 | /** |
||
| 160 | * Location |
||
| 161 | * |
||
| 162 | * @var LocationProperties |
||
| 163 | */ |
||
| 164 | protected $location = null; |
||
| 165 | /** |
||
| 166 | * Language (BCP 47 compliant) |
||
| 167 | * |
||
| 168 | * @var string |
||
| 169 | * @see https://tools.ietf.org/html/bcp47 |
||
| 170 | */ |
||
| 171 | protected $language = null; |
||
| 172 | |||
| 173 | /** |
||
| 174 | * System properties constructor |
||
| 175 | * |
||
| 176 | * @param array $data Property data |
||
| 177 | * @param ObjectInterface $object Owner object |
||
| 178 | */ |
||
| 179 | 27 | public function __construct(array $data, ObjectInterface $object) |
|
| 243 | |||
| 244 | /** |
||
| 245 | * Return the object ID |
||
| 246 | * |
||
| 247 | * @return Id Object ID |
||
| 248 | */ |
||
| 249 | 5 | public function getId() |
|
| 253 | |||
| 254 | /** |
||
| 255 | * Return the object type |
||
| 256 | * |
||
| 257 | * @return Type Object type |
||
| 258 | */ |
||
| 259 | 1 | public function getType() |
|
| 263 | |||
| 264 | /** |
||
| 265 | * Return the object revision |
||
| 266 | * |
||
| 267 | * @return Revision Object revision |
||
| 268 | */ |
||
| 269 | 24 | public function getRevision() |
|
| 273 | |||
| 274 | /** |
||
| 275 | * Return the object draft mode |
||
| 276 | * |
||
| 277 | * @return boolean Object draft mode |
||
| 278 | */ |
||
| 279 | 5 | public function isDraft() |
|
| 283 | |||
| 284 | /** |
||
| 285 | * Return the object publication state |
||
| 286 | * |
||
| 287 | * @return boolean Object is published |
||
| 288 | */ |
||
| 289 | public function isPublished() |
||
| 293 | |||
| 294 | /** |
||
| 295 | * Return the object deletion state |
||
| 296 | * |
||
| 297 | * @return boolean Object is deleted |
||
| 298 | */ |
||
| 299 | public function isDeleted() |
||
| 303 | |||
| 304 | /** |
||
| 305 | * Return the creation date & time of this revision |
||
| 306 | * |
||
| 307 | * @return \DateTimeImmutable Creation date & time |
||
| 308 | */ |
||
| 309 | 1 | public function getCreated() |
|
| 313 | |||
| 314 | /** |
||
| 315 | * Return the modification date & time of this revision |
||
| 316 | * |
||
| 317 | * @return \DateTimeImmutable Modification date & time |
||
| 318 | */ |
||
| 319 | 1 | public function getModified() |
|
| 323 | |||
| 324 | /** |
||
| 325 | * Return the publication date & time of this revision |
||
| 326 | * |
||
| 327 | * @return \DateTimeImmutable|null Publication date & time |
||
| 328 | */ |
||
| 329 | 1 | public function getPublished() |
|
| 333 | |||
| 334 | /** |
||
| 335 | * Return the deletion date & time of this revision |
||
| 336 | * |
||
| 337 | * @return \DateTimeImmutable|null Deletion date & time |
||
| 338 | */ |
||
| 339 | 1 | public function getDeleted() |
|
| 343 | |||
| 344 | /** |
||
| 345 | * Return the object language |
||
| 346 | * |
||
| 347 | * @return string |
||
| 348 | */ |
||
| 349 | 1 | public function getLanguage() |
|
| 353 | |||
| 354 | /** |
||
| 355 | * Return the latitude |
||
| 356 | * |
||
| 357 | * @return float Latitude |
||
| 358 | */ |
||
| 359 | 1 | public function getLatitude() |
|
| 363 | |||
| 364 | /** |
||
| 365 | * Set the latitude |
||
| 366 | * |
||
| 367 | * @param float $latitude Latitude |
||
| 368 | * @return SystemProperties Self reference |
||
| 369 | */ |
||
| 370 | 1 | public function setLatitude($latitude) |
|
| 371 | { |
||
| 372 | 1 | return $this->mutatePropertiesProperty( |
|
| 373 | 1 | self::PROPERTY_LOCATION, |
|
| 374 | 1 | $this->location->setLatitude($latitude) |
|
| 375 | ); |
||
| 376 | } |
||
| 377 | |||
| 378 | /** |
||
| 379 | * Return the longitude |
||
| 380 | * |
||
| 381 | * @return float Longitude |
||
| 382 | */ |
||
| 383 | 1 | public function getLongitude() |
|
| 387 | |||
| 388 | /** |
||
| 389 | * Set the longitude |
||
| 390 | * |
||
| 391 | * @param float $longitude Longitude |
||
| 392 | * @return SystemProperties Self reference |
||
| 393 | */ |
||
| 394 | 1 | public function setLongitude($longitude) |
|
| 395 | { |
||
| 396 | 1 | return $this->mutatePropertiesProperty( |
|
| 397 | 1 | self::PROPERTY_LOCATION, |
|
| 398 | 1 | $this->location->setLongitude($longitude) |
|
| 399 | ); |
||
| 400 | } |
||
| 401 | |||
| 402 | /** |
||
| 403 | * Return the elevation |
||
| 404 | * |
||
| 405 | * @return float Elevation |
||
| 406 | */ |
||
| 407 | 1 | public function getElevation() |
|
| 411 | |||
| 412 | /** |
||
| 413 | * Set the elevation |
||
| 414 | * |
||
| 415 | * @param float $elevation |
||
| 416 | * @return SystemProperties Self reference |
||
| 417 | */ |
||
| 418 | 1 | public function setElevation($elevation) |
|
| 419 | { |
||
| 420 | 1 | return $this->mutatePropertiesProperty( |
|
| 421 | 1 | self::PROPERTY_LOCATION, |
|
| 422 | 1 | $this->location->setElevation($elevation) |
|
| 423 | ); |
||
| 424 | } |
||
| 425 | |||
| 426 | /** |
||
| 427 | * Derive draft system properties |
||
| 428 | * |
||
| 429 | * @param Revision $draftRevision Draft revision |
||
| 430 | * @return SystemProperties Draft system properties |
||
| 431 | */ |
||
| 432 | 4 | public function createDraft(Revision $draftRevision) |
|
| 433 | { |
||
| 434 | 4 | $now = time(); |
|
| 435 | 4 | return new static( |
|
| 436 | [ |
||
| 437 | 4 | self::PROPERTY_ID => $this->uid->getId(), |
|
| 438 | 4 | self::PROPERTY_TYPE => $this->type->getType(), |
|
| 439 | 4 | self::PROPERTY_REVISION => $draftRevision->getRevision(), |
|
| 440 | 4 | self::PROPERTY_CREATED => $now, |
|
| 441 | 4 | self::PROPERTY_MODIFIED => $now, |
|
| 442 | 4 | self::PROPERTY_LANGUAGE => $this->language, |
|
| 443 | ], |
||
| 444 | 4 | $this->object |
|
| 445 | ); |
||
| 446 | } |
||
| 447 | |||
| 448 | /** |
||
| 449 | * Indicate that the object got published |
||
| 450 | * |
||
| 451 | * @return SystemProperties System properties |
||
| 452 | * @throws RuntimeException If the object is already published |
||
| 453 | */ |
||
| 454 | 2 | public function publish() |
|
| 468 | |||
| 469 | /** |
||
| 470 | * Update the object's modification timestamp |
||
| 471 | * |
||
| 472 | * @return SystemProperties System properties |
||
| 473 | */ |
||
| 474 | 7 | public function touch() |
|
| 480 | |||
| 481 | /** |
||
| 482 | * Set the object's deletion timestamp |
||
| 483 | * |
||
| 484 | * @return SystemProperties System properties |
||
| 485 | */ |
||
| 486 | public function delete() |
||
| 492 | |||
| 493 | /** |
||
| 494 | * Unset the object's deletion timestamp |
||
| 495 | * |
||
| 496 | * @return SystemProperties System properties |
||
| 497 | */ |
||
| 498 | public function undelete() |
||
| 504 | |||
| 505 | /** |
||
| 506 | * Return the property values as array |
||
| 507 | * |
||
| 508 | * @return array Property values |
||
| 509 | */ |
||
| 510 | 5 | public function toArray() |
|
| 525 | } |
||
| 526 |