Collection::__construct() - Code Metrics - Inspection of "Improved code climate" - apparat/object - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 99686d...4efdc3 )

by Joschi

created 2016-03-01 23:50 UTC

Collection::__construct() B

↳ Parent: Collection

Complexity

Conditions	4
Paths	4

Size

Total Lines	22
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	14
CRAP Score	4

Importance

Changes	7
Bugs	0	Features	0

Metric	Value
c	7
b	0
f	0
dl	0
loc	22
ccs	14
cts	14
cp	1
rs	8.9197
cc	4
eloc	12
nc	4
nop	1
crap	4

<?php

/**
 * apparat-object
 *
 * @category    Apparat
 * @package     Apparat\Object\Domain
 * @author      Joschi Kuphal <[email protected]> / @jkphl
 * @copyright   Copyright © 2016 Joschi Kuphal <[email protected]> / @jkphl
 * @license     http://opensource.org/licenses/MIT The MIT License (MIT)
 */

/***********************************************************************************
 *  The MIT License (MIT)
 *
 *  Copyright © 2016 Joschi Kuphal <[email protected]> / @jkphl
 *
 *  Permission is hereby granted, free of charge, to any person obtaining a copy of
 *  this software and associated documentation files (the "Software"), to deal in
 *  the Software without restriction, including without limitation the rights to
 *  use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of
 *  the Software, and to permit persons to whom the Software is furnished to do so,
 *  subject to the following conditions:
 *
 *  The above copyright notice and this permission notice shall be included in all
 *  copies or substantial portions of the Software.
 *
 *  THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 *  IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS
 *  FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR
 *  COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER
 *  IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
 *  CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
 ***********************************************************************************/

namespace Apparat\Object\Domain\Model\Object;

use Apparat\Object\Domain\Model\Path\RepositoryPath;

/**
 * Lazy loading object collection
 *
 * @package Apparat\Object
 * @subpackage Apparat\Object\Domain
 */
class Collection implements CollectionInterface
{
    /**
     * Objects
     *
     * @var ObjectInterface[]|RepositoryPath[]
     */
    protected $objects = array();
    /**
     * Object IDs
     *
     * @var array
     */
    protected $objectIds = array();
    /**
     * Internal object pointer
     *
     * @var int
     */
    protected $pointer = 0;

    /*******************************************************************************
     * PUBLIC METHODS
     *******************************************************************************/

    /**
     * Collection constructor
     *
     * @param array $objects Collection objects
     * @throws InvalidArgumentException If the an invalid object or path is provided
     */
    public function __construct(array $objects = [])
    {
        foreach ($objects as $object) {
            // If it's an object
            if ($object instanceof ObjectInterface) {
                $this->objects[$object->getId()->getId()] = $object;
                continue;

                // Else if it's an object path
            } elseif ($object instanceof RepositoryPath) {
                $this->objects[$object->getId()->getId()] = $object;

                continue;
            }

            throw new InvalidArgumentException(
                'Invalid collection object or path',
                InvalidArgumentException::INVALID_COLLECTION_OBJECT_OR_PATH
            );
        }

        $this->objectIds = array_keys($this->objects);
    }

    /**
     * Return the current object
     *
     * @return ObjectInterface Current object
     */
    public function current()
    {
        return $this->loadObject($this->objectIds[$this->pointer]);
    }

    /**
     * Load and return an object by ID
     *
     * @param int $objectId Object ID
     * @return ObjectInterface Object
     */
    protected function loadObject($objectId)
    {
        // Lazy-load the object once
        if ($this->objects[$objectId] instanceof RepositoryPath) {
            $this->objects[$objectId] = $this->objects[$objectId]->getRepository()->loadObject(
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
                $this->objects[$objectId]
            );
        }

        return $this->objects[$objectId];
    }

    /**
     * Move forward to next object
     *
     * @return void
     */
    public function next()
    {
        ++$this->pointer;
    }

    /**
     * Return the ID of the current object
     *
     * @return int Object ID
     */
    public function key()
    {
        return $this->objectIds[$this->pointer];
    }

    /**
     * Checks if current position is valid
     *
     * @return boolean The current position is valid
     */
    public function valid()
    {
        return isset($this->objectIds[$this->pointer]);
    }

    /**
     * Rewind the Iterator to the first object
     *
     * @return void
     */
    public function rewind()
    {
        $this->pointer = 0;
    }

    /**
     * Whether an object ID exists
     *
     * @param int $offset Object ID
     * @return boolean Whether the object ID exists
     */
    public function offsetExists($offset)
    {
        return isset($this->objects[$offset]);
    }

    /**
     * Get an object with a particular ID
     *
     * @param int $offset Object ID
     * @return ObjectInterface Object
     */
    public function offsetGet($offset)
    {
        return $this->objects[$offset];

    }

    /**
     * Set an object by ID
     *
     * @param int $offset Object ID
     * @param ObjectInterface $value Object
     * @throws RuntimeException When an object should be set by ID
     */
    public function offsetSet($offset, $value)
    {
        $offset = null;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $value = null;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        throw new RuntimeException('Cannot modify collection by index. Use add() / remove() instead', RuntimeException::CANNOT_MODIFY_COLLECTION_BY_INDEX);
    }

    /**
     * Unset an object by ID
     *
     * @param int $offset Object ID
     * @throws RuntimeException When an object should be set by ID
     */
    public function offsetUnset($offset)
    {
        $offset = null;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        throw new RuntimeException('Cannot modify collection by index. Use add() / remove() instead', RuntimeException::CANNOT_MODIFY_COLLECTION_BY_INDEX);
    }

    /**
     * Add an object to the collection
     *
     * @param string|ObjectInterface $object Object or object URL
     * @return Collection Modified object collection
     */
    public function add($object)
    {
        $objects = $this->objects;
        $objects[] = $object;
        return new self(array_values($objects));
    }

    /**
     * Remove an object out of this collection
     *
     * @param string|ObjectInterface $object Object or object ID
     * @return Collection Modified object collection
     */
    public function remove($object)
    {
        $object = ($object instanceof ObjectInterface) ? $object->getId()->getId() : intval($object);
        if (empty($this->objects[$object])) {
            throw new InvalidArgumentException(
                sprintf('Unknown object ID "%s"', $object),
                InvalidArgumentException::UNKNOWN_OBJECT_ID
            );
        }

        $objects = $this->objects;
        unset($objects[$object]);
        return new self(array_values($objects));
    }

    /**
     * Count objects in this collection
     *
     * @return int The number of objects in this collection
     */
    public function count()
    {
        return count($this->objects);
    }

    /*******************************************************************************
     * PRIVATE METHODS
     *******************************************************************************/

    /**
     * Append another collection
     *
     * @param Collection $collection Collection
     * @return Collection Combined collections
     */
    public function append(Collection $collection)
    {
        $objects = array_merge($this->objects, $collection->objects);
        return new self(array_values($objects));
    }
}


1		<?php
2
3		/**
4		* apparat-object
5		*
6		* @category Apparat
7		* @package Apparat\Object\Domain
8		* @author Joschi Kuphal <[email protected]> / @jkphl
9		* @copyright Copyright © 2016 Joschi Kuphal <[email protected]> / @jkphl
10		* @license http://opensource.org/licenses/MIT The MIT License (MIT)
11		*/
12
13		/***********************************************************************************
14		* The MIT License (MIT)
15		*
16		* Copyright © 2016 Joschi Kuphal <[email protected]> / @jkphl
17		*
18		* Permission is hereby granted, free of charge, to any person obtaining a copy of
19		* this software and associated documentation files (the "Software"), to deal in
20		* the Software without restriction, including without limitation the rights to
21		* use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of
22		* the Software, and to permit persons to whom the Software is furnished to do so,
23		* subject to the following conditions:
24		*
25		* The above copyright notice and this permission notice shall be included in all
26		* copies or substantial portions of the Software.
27		*
28		* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
29		* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS
30		* FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR
31		* COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER
32		* IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
33		* CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
34		***********************************************************************************/
35
36		namespace Apparat\Object\Domain\Model\Object;
37
38		use Apparat\Object\Domain\Model\Path\RepositoryPath;
39
40		/**
41		* Lazy loading object collection
42		*
43		* @package Apparat\Object
44		* @subpackage Apparat\Object\Domain
45		*/
46		class Collection implements CollectionInterface
47		{
48		/**
49		* Objects
50		*
51		* @var ObjectInterface[]\|RepositoryPath[]
52		*/
53		protected $objects = array();
54		/**
55		* Object IDs
56		*
57		* @var array
58		*/
59		protected $objectIds = array();
60		/**
61		* Internal object pointer
62		*
63		* @var int
64		*/
65		protected $pointer = 0;
66
67		/*******************************************************************************
68		* PUBLIC METHODS
69		*******************************************************************************/
70
71		/**
72		* Collection constructor
73		*
74		* @param array $objects Collection objects
75		* @throws InvalidArgumentException If the an invalid object or path is provided
76		*/
77	7	public function __construct(array $objects = [])
78		{
79	7	foreach ($objects as $object) {
80		// If it's an object
81	7	if ($object instanceof ObjectInterface) {
82	3	$this->objects[$object->getId()->getId()] = $object;
83	3	continue;
84
85		// Else if it's an object path
86	7	} elseif ($object instanceof RepositoryPath) {
87	7	$this->objects[$object->getId()->getId()] = $object;
		0 ignored issues – show Bug introduced 2016-02-06 22:26 UTC by Report Bug Copy Issue Report The method `getId` cannot be called on `$object->getId()` (of type `integer`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
88	7	continue;
89		}
90
91	1	throw new InvalidArgumentException(
92	1	'Invalid collection object or path',
93		InvalidArgumentException::INVALID_COLLECTION_OBJECT_OR_PATH
94	1	);
95	7	}
96
97	7	$this->objectIds = array_keys($this->objects);
98	7	}
99
100		/**
101		* Return the current object
102		*
103		* @return ObjectInterface Current object
104		*/
105	3	public function current()
106		{
107	3	return $this->loadObject($this->objectIds[$this->pointer]);
108		}
109
110		/**
111		* Load and return an object by ID
112		*
113		* @param int $objectId Object ID
114		* @return ObjectInterface Object
115		*/
116	3	protected function loadObject($objectId)
117		{
118		// Lazy-load the object once
119	3	if ($this->objects[$objectId] instanceof RepositoryPath) {
120	3	$this->objects[$objectId] = $this->objects[$objectId]->getRepository()->loadObject(
		0 ignored issues – show Bug introduced 2016-02-06 22:26 UTC by Report Bug Copy Issue Report The method `getRepository` does only exist in `Apparat\Object\Domain\Model\Path\RepositoryPath`, but not in `Apparat\Object\Domain\Model\Object\ObjectInterface`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
121	3	$this->objects[$objectId]
122	3	);
123	3	}
124
125	3	return $this->objects[$objectId];
126		}
127
128		/**
129		* Move forward to next object
130		*
131		* @return void
132		*/
133	1	public function next()
134		{
135	1	++$this->pointer;
136	1	}
137
138		/**
139		* Return the ID of the current object
140		*
141		* @return int Object ID
142		*/
143	1	public function key()
144		{
145	1	return $this->objectIds[$this->pointer];
146		}
147
148		/**
149		* Checks if current position is valid
150		*
151		* @return boolean The current position is valid
152		*/
153	3	public function valid()
154		{
155	3	return isset($this->objectIds[$this->pointer]);
156		}
157
158		/**
159		* Rewind the Iterator to the first object
160		*
161		* @return void
162		*/
163	3	public function rewind()
164		{
165	3	$this->pointer = 0;
166	3	}
167
168		/**
169		* Whether an object ID exists
170		*
171		* @param int $offset Object ID
172		* @return boolean Whether the object ID exists
173		*/
174	1	public function offsetExists($offset)
175		{
176	1	return isset($this->objects[$offset]);
177		}
178
179		/**
180		* Get an object with a particular ID
181		*
182		* @param int $offset Object ID
183		* @return ObjectInterface Object
184		*/
185	2	public function offsetGet($offset)
186		{
187	2	return $this->objects[$offset];
		0 ignored issues – show Bug Compatibility introduced 2016-03-01 23:33 UTC by Report Bug Copy Issue Report The expression `$this->objects[$offset];` of type `Apparat\Object\Domain\Mo...del\Path\RepositoryPath` adds the type `Apparat\Object\Domain\Model\Path\RepositoryPath` to the return on line 187 which is incompatible with the return type documented by `Apparat\Object\Domain\Mo...t\Collection::offsetGet` of type `Apparat\Object\Domain\Model\Object\ObjectInterface`. Loading history...
188		}
189
190		/**
191		* Set an object by ID
192		*
193		* @param int $offset Object ID
194		* @param ObjectInterface $value Object
195		* @throws RuntimeException When an object should be set by ID
196		*/
197	1	public function offsetSet($offset, $value)
198		{
199	1	$offset = null;
		0 ignored issues – show Unused Code introduced 2016-03-01 23:53 UTC by Report Bug Copy Issue Report `$offset` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
200	1	$value = null;
		0 ignored issues – show Unused Code introduced 2016-03-01 23:53 UTC by Report Bug Copy Issue Report `$value` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
201	1	throw new RuntimeException('Cannot modify collection by index. Use add() / remove() instead', RuntimeException::CANNOT_MODIFY_COLLECTION_BY_INDEX);
202		}
203
204		/**
205		* Unset an object by ID
206		*
207		* @param int $offset Object ID
208		* @throws RuntimeException When an object should be set by ID
209		*/
210	1	public function offsetUnset($offset)
211		{
212	1	$offset = null;
		0 ignored issues – show Unused Code introduced 2016-03-01 23:53 UTC by Report Bug Copy Issue Report `$offset` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
213	1	throw new RuntimeException('Cannot modify collection by index. Use add() / remove() instead', RuntimeException::CANNOT_MODIFY_COLLECTION_BY_INDEX);
214		}
215
216		/**
217		* Add an object to the collection
218		*
219		* @param string\|ObjectInterface $object Object or object URL
220		* @return Collection Modified object collection
221		*/
222	2	public function add($object)
223		{
224	2	$objects = $this->objects;
225	2	$objects[] = $object;
226	2	return new self(array_values($objects));
227		}
228
229		/**
230		* Remove an object out of this collection
231		*
232		* @param string\|ObjectInterface $object Object or object ID
233		* @return Collection Modified object collection
234		*/
235	1	public function remove($object)
236		{
237	1	$object = ($object instanceof ObjectInterface) ? $object->getId()->getId() : intval($object);
238	1	if (empty($this->objects[$object])) {
239	1	throw new InvalidArgumentException(
240	1	sprintf('Unknown object ID "%s"', $object),
241		InvalidArgumentException::UNKNOWN_OBJECT_ID
242	1	);
243		}
244
245	1	$objects = $this->objects;
246	1	unset($objects[$object]);
247	1	return new self(array_values($objects));
248		}
249
250		/**
251		* Count objects in this collection
252		*
253		* @return int The number of objects in this collection
254		*/
255	6	public function count()
256		{
257	6	return count($this->objects);
258		}
259
260		/*******************************************************************************
261		* PRIVATE METHODS
262		*******************************************************************************/
263
264		/**
265		* Append another collection
266		*
267		* @param Collection $collection Collection
268		* @return Collection Combined collections
269		*/
270	1	public function append(Collection $collection)
271		{
272	1	$objects = array_merge($this->objects, $collection->objects);
273	1	return new self(array_values($objects));
274		}
275		}
276

apparat / object

Push — master ( 99686d...4efdc3 )

Collection::__construct() B

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like