SelectorFactory::castInt() - Code Metrics - Inspection of "Improved code climate" - apparat/object - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 99686d...4efdc3 )

by Joschi

created 2016-03-01 23:50 UTC

SelectorFactory::castInt() A

↳ Parent: SelectorFactory

Complexity

Conditions	2
Paths	2

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	2

Metric	Value
dl	0
loc	4
ccs	2
cts	2
cp	1
rs	10
cc	2
eloc	2
nc	2
nop	1
crap	2

<?php

/**
 * apparat-object
 *
 * @category    Apparat
 * @package     Apparat\Object
 * @subpackage  Apparat\Object\Domain
 * @author      Joschi Kuphal <[email protected]> / @jkphl
 * @copyright   Copyright © 2016 Joschi Kuphal <[email protected]> / @jkphl
 * @license     http://opensource.org/licenses/MIT The MIT License (MIT)
 */

/***********************************************************************************
 *  The MIT License (MIT)
 *
 *  Copyright © 2016 Joschi Kuphal <[email protected]> / @jkphl
 *
 *  Permission is hereby granted, free of charge, to any person obtaining a copy of
 *  this software and associated documentation files (the "Software"), to deal in
 *  the Software without restriction, including without limitation the rights to
 *  use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of
 *  the Software, and to permit persons to whom the Software is furnished to do so,
 *  subject to the following conditions:
 *
 *  The above copyright notice and this permission notice shall be included in all
 *  copies or substantial portions of the Software.
 *
 *  THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 *  IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS
 *  FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR
 *  COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER
 *  IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
 *  CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
 ***********************************************************************************/

namespace Apparat\Object\Domain\Factory;

use Apparat\Object\Domain\Model\Object\Revision;
use Apparat\Object\Domain\Repository\InvalidArgumentException;
use Apparat\Object\Domain\Repository\Selector as RepositorySelector;

/**
 * Object selector factory
 *
 * @package Apparat\Object
 * @subpackage Apparat\Object\Domain
 */
class SelectorFactory
{
    /**
     * Date PCRE pattern
     *
     * @var array
     * @see ObjectUrl::$datePattern
     */
    protected static $datePattern = [
        'Y' => '/(?P<year>\d{4}|\*)',
        'm' => '(?:/(?P<month>\d{2}|\*)',
        'd' => '(?:/(?P<day>\d{2}|\*)',
        'H' => '(?:/(?P<hour>\d{2}|\*)',
        'i' => '(?:/(?P<minute>\d{2}|\*)',
        's' => '(?:/(?P<second>\d{2}|\*)',
    ];

    /**
     * Parse and instantiate an object selector
     *
     * @param string $selector String selector
     * @return \Apparat\Object\Domain\Repository\Selector Object selector
     * @throws InvalidArgumentException If the selector is invalid
     */
    public static function createFromString($selector)
    {
        $datePrecision = intval(getenv('OBJECT_DATE_PRECISION'));
        $selectorPattern = '/(?P<id>(?:\d+)|\*)\.(?P<type>(?:[a-z]+)|\*)(?:/\\k<id>(?:-(?P<revision>\d+))?)?';

        // If the creation date is used as selector component
        if ($datePrecision) {
            $selectorPattern = implode(
                    '', array_slice(
                    self::$datePattern, 0,
                    $datePrecision
                )

                ).'(?:'.$selectorPattern.str_repeat(
                    ')?',
                    $datePrecision
                );
        }
        $selectorPattern = '%^'.$selectorPattern.'$%';

        // If the selector is invalid
        if (!strlen($selector) || !preg_match(
                $selectorPattern, $selector,
                $selectorParts
            ) || !strlen($selectorParts[0])
        ) {
            throw new InvalidArgumentException(
                sprintf('Invalid respository selector "%s"', $selector),
                InvalidArgumentException::INVALID_REPOSITORY_SELECTOR
            );
        }

        $year = $month = $day = $hour = $minute = $second = $uid = null;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        if (($datePrecision > 0)) {
            $year = isset($selectorParts['year']) ? self::castInt(
                $selectorParts['year']
            ) : RepositorySelector::WILDCARD;
        }
        if (($datePrecision > 1)) {
            $month = isset($selectorParts['month']) ? self::castInt(
                $selectorParts['month']
            ) : RepositorySelector::WILDCARD;
        }
        if (($datePrecision > 2)) {
            $day = isset($selectorParts['day']) ? self::castInt($selectorParts['day']) : RepositorySelector::WILDCARD;
        }
        if (($datePrecision > 3)) {
            $hour = isset($selectorParts['hour']) ? self::castInt(
                $selectorParts['hour']
            ) : RepositorySelector::WILDCARD;
        }
        if (($datePrecision > 4)) {
            $minute = isset($selectorParts['minute']) ? self::castInt(
                $selectorParts['minute']
            ) : RepositorySelector::WILDCARD;
        }
        if (($datePrecision > 5)) {
            $second = isset($selectorParts['second']) ? self::castInt(
                $selectorParts['second']
            ) : RepositorySelector::WILDCARD;
        }
        $uid = isset($selectorParts['id']) ? self::castInt($selectorParts['id']) : RepositorySelector::WILDCARD;

        $type = empty($selectorParts['type']) ? RepositorySelector::WILDCARD : trim($selectorParts['type']);
        $revision = (isset($selectorParts['revision']) && strlen($selectorParts['revision'])) ? intval(
            $selectorParts['revision']
        ) : Revision::CURRENT;

        return new RepositorySelector($year, $month, $day, $hour, $minute, $second, $uid, $type, $revision);
    }

    /**
     * Cast a value as integer if it's not a wildcard
     *
     * @param string $value Value
     * @return int|string Integer value or wildcard
     */
    protected static function castInt($value)
    {
        return ($value === RepositorySelector::WILDCARD) ? $value : intval($value);
    }
}


1		<?php
2
3		/**
4		* apparat-object
5		*
6		* @category Apparat
7		* @package Apparat\Object
8		* @subpackage Apparat\Object\Domain
9		* @author Joschi Kuphal <[email protected]> / @jkphl
10		* @copyright Copyright © 2016 Joschi Kuphal <[email protected]> / @jkphl
11		* @license http://opensource.org/licenses/MIT The MIT License (MIT)
12		*/
13
14		/***********************************************************************************
15		* The MIT License (MIT)
16		*
17		* Copyright © 2016 Joschi Kuphal <[email protected]> / @jkphl
18		*
19		* Permission is hereby granted, free of charge, to any person obtaining a copy of
20		* this software and associated documentation files (the "Software"), to deal in
21		* the Software without restriction, including without limitation the rights to
22		* use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of
23		* the Software, and to permit persons to whom the Software is furnished to do so,
24		* subject to the following conditions:
25		*
26		* The above copyright notice and this permission notice shall be included in all
27		* copies or substantial portions of the Software.
28		*
29		* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
30		* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS
31		* FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR
32		* COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER
33		* IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
34		* CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
35		***********************************************************************************/
36
37		namespace Apparat\Object\Domain\Factory;
38
39		use Apparat\Object\Domain\Model\Object\Revision;
40		use Apparat\Object\Domain\Repository\InvalidArgumentException;
41		use Apparat\Object\Domain\Repository\Selector as RepositorySelector;
42
43		/**
44		* Object selector factory
45		*
46		* @package Apparat\Object
47		* @subpackage Apparat\Object\Domain
48		*/
49		class SelectorFactory
50		{
51		/**
52		* Date PCRE pattern
53		*
54		* @var array
55		* @see ObjectUrl::$datePattern
56		*/
57		protected static $datePattern = [
58		'Y' => '/(?P<year>\d{4}\|\*)',
59		'm' => '(?:/(?P<month>\d{2}\|\*)',
60		'd' => '(?:/(?P<day>\d{2}\|\*)',
61		'H' => '(?:/(?P<hour>\d{2}\|\*)',
62		'i' => '(?:/(?P<minute>\d{2}\|\*)',
63		's' => '(?:/(?P<second>\d{2}\|\*)',
64		];
65
66		/**
67		* Parse and instantiate an object selector
68		*
69		* @param string $selector String selector
70		* @return \Apparat\Object\Domain\Repository\Selector Object selector
71		* @throws InvalidArgumentException If the selector is invalid
72		*/
73	11	public static function createFromString($selector)
74		{
75	11	$datePrecision = intval(getenv('OBJECT_DATE_PRECISION'));
76	11	$selectorPattern = '/(?P<id>(?:\d+)\|\)\.(?P<type>(?:[a-z]+)\|\)(?:/\\k<id>(?:-(?P<revision>\d+))?)?';
77
78		// If the creation date is used as selector component
79	11	if ($datePrecision) {
80	11	$selectorPattern = implode(
81	11	'', array_slice(
82	11	self::$datePattern, 0,
83		$datePrecision
84	11	)
		0 ignored issues – show Coding Style introduced 2016-02-06 22:26 UTC by Report Bug Copy Issue Report It seems like the identation of this line is off (expected at least 20 spaces, but found 16). Loading history...
85	11	).'(?:'.$selectorPattern.str_repeat(
86	11	')?',
87		$datePrecision
88	11	);
89	11	}
90	11	$selectorPattern = '%^'.$selectorPattern.'$%';
91
92		// If the selector is invalid
93	11	if (!strlen($selector) \|\| !preg_match(
94	11	$selectorPattern, $selector,
95		$selectorParts
96	11	) \|\| !strlen($selectorParts[0])
97	11	) {
98	1	throw new InvalidArgumentException(
99	1	sprintf('Invalid respository selector "%s"', $selector),
100		InvalidArgumentException::INVALID_REPOSITORY_SELECTOR
101	1	);
102		}
103
104	10	$year = $month = $day = $hour = $minute = $second = $uid = null;
		0 ignored issues – show Unused Code introduced 2016-03-01 23:33 UTC by Report Bug Copy Issue Report `$uid` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
105	10	if (($datePrecision > 0)) {
106	10	$year = isset($selectorParts['year']) ? self::castInt(
107	10	$selectorParts['year']
108	10	) : RepositorySelector::WILDCARD;
109	10	}
110	10	if (($datePrecision > 1)) {
111	10	$month = isset($selectorParts['month']) ? self::castInt(
112	8	$selectorParts['month']
113	10	) : RepositorySelector::WILDCARD;
114	10	}
115	10	if (($datePrecision > 2)) {
116	10	$day = isset($selectorParts['day']) ? self::castInt($selectorParts['day']) : RepositorySelector::WILDCARD;
117	10	}
118	10	if (($datePrecision > 3)) {
119	3	$hour = isset($selectorParts['hour']) ? self::castInt(
120	2	$selectorParts['hour']
121	3	) : RepositorySelector::WILDCARD;
122	3	}
123	10	if (($datePrecision > 4)) {
124	3	$minute = isset($selectorParts['minute']) ? self::castInt(
125	2	$selectorParts['minute']
126	3	) : RepositorySelector::WILDCARD;
127	3	}
128	10	if (($datePrecision > 5)) {
129	3	$second = isset($selectorParts['second']) ? self::castInt(
130	2	$selectorParts['second']
131	3	) : RepositorySelector::WILDCARD;
132	3	}
133	10	$uid = isset($selectorParts['id']) ? self::castInt($selectorParts['id']) : RepositorySelector::WILDCARD;
134
135	10	$type = empty($selectorParts['type']) ? RepositorySelector::WILDCARD : trim($selectorParts['type']);
136	10	$revision = (isset($selectorParts['revision']) && strlen($selectorParts['revision'])) ? intval(
137	2	$selectorParts['revision']
138	10	) : Revision::CURRENT;
139
140	10	return new RepositorySelector($year, $month, $day, $hour, $minute, $second, $uid, $type, $revision);
141		}
142
143		/**
144		* Cast a value as integer if it's not a wildcard
145		*
146		* @param string $value Value
147		* @return int\|string Integer value or wildcard
148		*/
149	10	protected static function castInt($value)
150		{
151	10	return ($value === RepositorySelector::WILDCARD) ? $value : intval($value);
152		}
153		}
154

apparat / object

Push — master ( 99686d...4efdc3 )

SelectorFactory::castInt() A

Complexity

Size

Duplication

Code Coverage

Duplication Side-by-Side

Filter issues like