Complex classes like SystemProperties often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use SystemProperties, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
55 | class SystemProperties extends AbstractProperties |
||
56 | { |
||
57 | /** |
||
58 | * Collection name |
||
59 | * |
||
60 | * @var string |
||
61 | */ |
||
62 | const COLLECTION = 'system'; |
||
63 | /** |
||
64 | * ID property |
||
65 | * |
||
66 | * @var string |
||
67 | */ |
||
68 | const PROPERTY_ID = 'id'; |
||
69 | /** |
||
70 | * Type property |
||
71 | * |
||
72 | * @var string |
||
73 | */ |
||
74 | const PROPERTY_TYPE = 'type'; |
||
75 | /** |
||
76 | * Revision property |
||
77 | * |
||
78 | * @var string |
||
79 | */ |
||
80 | const PROPERTY_REVISION = 'revision'; |
||
81 | /** |
||
82 | * Created property |
||
83 | * |
||
84 | * @var string |
||
85 | */ |
||
86 | const PROPERTY_CREATED = 'created'; |
||
87 | /** |
||
88 | * Modified property |
||
89 | * |
||
90 | * @var string |
||
91 | */ |
||
92 | const PROPERTY_MODIFIED = 'modified'; |
||
93 | /** |
||
94 | * Published property |
||
95 | * |
||
96 | * @var string |
||
97 | */ |
||
98 | const PROPERTY_PUBLISHED = 'published'; |
||
99 | /** |
||
100 | * Deleted property |
||
101 | * |
||
102 | * @var string |
||
103 | */ |
||
104 | const PROPERTY_DELETED = 'deleted'; |
||
105 | /** |
||
106 | * Language property |
||
107 | * |
||
108 | * @var string |
||
109 | */ |
||
110 | const PROPERTY_LANGUAGE = 'language'; |
||
111 | /** |
||
112 | * Location property |
||
113 | * |
||
114 | * @var string |
||
115 | */ |
||
116 | const PROPERTY_LOCATION = 'location'; |
||
117 | /** |
||
118 | * Object ID (constant throughout revisions) |
||
119 | * |
||
120 | * @var Id |
||
121 | */ |
||
122 | protected $uid = null; |
||
123 | /** |
||
124 | * Object type (constant throughout revisions) |
||
125 | * |
||
126 | * @var Type |
||
127 | */ |
||
128 | protected $type = null; |
||
129 | /** |
||
130 | * Object revision |
||
131 | * |
||
132 | * @var Revision |
||
133 | */ |
||
134 | protected $revision = null; |
||
135 | /** |
||
136 | * Creation date of this revision |
||
137 | * |
||
138 | * @var \DateTimeInterface |
||
139 | */ |
||
140 | protected $created = null; |
||
141 | /** |
||
142 | * Modification date of this revision |
||
143 | * |
||
144 | * @var \DateTimeInterface |
||
145 | */ |
||
146 | protected $modified = null; |
||
147 | /** |
||
148 | * Publication date of this revision |
||
149 | * |
||
150 | * @var \DateTimeInterface |
||
151 | */ |
||
152 | protected $published = null; |
||
153 | /** |
||
154 | * Deletion date of this revision |
||
155 | * |
||
156 | * @var \DateTimeInterface |
||
157 | */ |
||
158 | protected $deleted = null; |
||
159 | /** |
||
160 | * Location |
||
161 | * |
||
162 | * @var LocationProperties |
||
163 | */ |
||
164 | protected $location = null; |
||
165 | /** |
||
166 | * Language (BCP 47 compliant) |
||
167 | * |
||
168 | * @var string |
||
169 | * @see https://tools.ietf.org/html/bcp47 |
||
170 | */ |
||
171 | protected $language = null; |
||
172 | |||
173 | /** |
||
174 | * System properties constructor |
||
175 | * |
||
176 | * @param array $data Property data |
||
177 | * @param ObjectInterface $object Owner object |
||
178 | */ |
||
179 | 48 | public function __construct(array $data, ObjectInterface $object) |
|
180 | { |
||
181 | 48 | parent::__construct($data, $object); |
|
182 | |||
183 | // Initialize the object ID |
||
184 | 48 | if (array_key_exists(self::PROPERTY_ID, $data)) { |
|
185 | 46 | $this->uid = Id::unserialize($data[self::PROPERTY_ID]); |
|
186 | } |
||
187 | |||
188 | // Initialize the object type |
||
189 | 48 | if (array_key_exists(self::PROPERTY_TYPE, $data)) { |
|
190 | 47 | $this->type = Type::unserialize($data[self::PROPERTY_TYPE]); |
|
191 | } |
||
192 | |||
193 | // Initialize the object creation date |
||
194 | 47 | if (array_key_exists(self::PROPERTY_CREATED, $data)) { |
|
195 | 46 | $this->created = $data[self::PROPERTY_CREATED]; |
|
196 | } |
||
197 | |||
198 | // Initialize the object modification date |
||
199 | 47 | if (array_key_exists(self::PROPERTY_MODIFIED, $data)) { |
|
200 | 46 | $this->modified = $data[self::PROPERTY_MODIFIED]; |
|
201 | } |
||
202 | |||
203 | // Initialize the object publication date |
||
204 | 47 | if (array_key_exists(self::PROPERTY_PUBLISHED, $data)) { |
|
205 | 33 | $this->published = $data[self::PROPERTY_PUBLISHED]; |
|
206 | } |
||
207 | |||
208 | // Initialize the object deletion date |
||
209 | 47 | if (array_key_exists(self::PROPERTY_DELETED, $data)) { |
|
210 | 2 | $this->deleted = $data[self::PROPERTY_DELETED]; |
|
211 | } |
||
212 | |||
213 | // Initialize the object language |
||
214 | 47 | if (array_key_exists(self::PROPERTY_LANGUAGE, $data)) { |
|
215 | 46 | $this->language = trim($data[self::PROPERTY_LANGUAGE]); |
|
216 | } |
||
217 | |||
218 | // Initialize the location |
||
219 | 47 | $this->location = Kernel::create( |
|
220 | 47 | LocationProperties::class, |
|
221 | 47 | [empty($data[self::PROPERTY_LOCATION]) ? [] : $data[self::PROPERTY_LOCATION], $this->object] |
|
222 | ); |
||
223 | |||
224 | // Initialize the object revision |
||
225 | 47 | if (array_key_exists(self::PROPERTY_REVISION, $data)) { |
|
226 | 46 | $this->revision = Revision::unserialize($data[self::PROPERTY_REVISION])->setDraft($this->isDraft()); |
|
227 | } |
||
228 | |||
229 | // Test if all mandatory properties are set |
||
230 | 47 | if (!($this->uid instanceof Id) |
|
231 | 46 | || !($this->type instanceof Type) |
|
232 | 46 | || !($this->revision instanceof Revision) |
|
233 | 46 | || !($this->created instanceof \DateTimeInterface) |
|
234 | 46 | || !($this->modified instanceof \DateTimeInterface) |
|
235 | 47 | || !strlen($this->language) |
|
236 | ) { |
||
237 | 1 | throw new InvalidArgumentException( |
|
238 | 1 | 'Invalid system properties', |
|
239 | 1 | InvalidArgumentException::INVALID_SYSTEM_PROPERTIES |
|
240 | ); |
||
241 | } |
||
242 | 46 | } |
|
243 | |||
244 | /** |
||
245 | * Return the object draft mode |
||
246 | * |
||
247 | * @return boolean Object draft mode |
||
248 | */ |
||
249 | 46 | public function isDraft() |
|
250 | { |
||
251 | 46 | return !($this->published instanceof \DateTimeInterface); |
|
252 | } |
||
253 | |||
254 | /** |
||
255 | * Return the object ID |
||
256 | * |
||
257 | * @return Id Object ID |
||
258 | */ |
||
259 | 10 | public function getId() |
|
260 | { |
||
261 | 10 | return $this->uid; |
|
262 | } |
||
263 | |||
264 | /** |
||
265 | * Return the object type |
||
266 | * |
||
267 | * @return Type Object type |
||
268 | */ |
||
269 | 15 | public function getObjectType() |
|
270 | { |
||
271 | 15 | return $this->type; |
|
272 | } |
||
273 | |||
274 | /** |
||
275 | * Return the object revision |
||
276 | * |
||
277 | * @return Revision Object revision |
||
278 | */ |
||
279 | 45 | public function getRevision() |
|
280 | { |
||
281 | 45 | return $this->revision; |
|
282 | } |
||
283 | |||
284 | /** |
||
285 | * Return the object publication state |
||
286 | * |
||
287 | * @return boolean Object is published |
||
288 | */ |
||
289 | 1 | public function isPublished() |
|
290 | { |
||
291 | 1 | return ($this->published instanceof \DateTimeInterface); |
|
292 | } |
||
293 | |||
294 | /** |
||
295 | * Return the object deletion state |
||
296 | * |
||
297 | * @return boolean Object is deleted |
||
298 | */ |
||
299 | 45 | public function isDeleted() |
|
300 | { |
||
301 | 45 | return ($this->deleted instanceof \DateTimeInterface); |
|
302 | } |
||
303 | |||
304 | /** |
||
305 | * Return the creation date & time of this revision |
||
306 | * |
||
307 | * @return \DateTimeInterface Creation date & time |
||
308 | */ |
||
309 | 3 | public function getCreated() |
|
313 | |||
314 | /** |
||
315 | * Return the modification date & time of this revision |
||
316 | * |
||
317 | * @return \DateTimeInterface Modification date & time |
||
318 | */ |
||
319 | 2 | public function getModified() |
|
320 | { |
||
321 | 2 | return $this->modified; |
|
322 | } |
||
323 | |||
324 | /** |
||
325 | * Return the publication date & time of this revision |
||
326 | * |
||
327 | * @return \DateTimeInterface|null Publication date & time |
||
328 | */ |
||
329 | 2 | public function getPublished() |
|
333 | |||
334 | /** |
||
335 | * Return the deletion date & time of this revision |
||
336 | * |
||
337 | * @return \DateTimeInterface|null Deletion date & time |
||
338 | */ |
||
339 | 1 | public function getDeleted() |
|
340 | { |
||
341 | 1 | return $this->deleted; |
|
343 | |||
344 | /** |
||
345 | * Return the object language |
||
346 | * |
||
347 | * @return string |
||
348 | */ |
||
349 | 1 | public function getLanguage() |
|
353 | |||
354 | /** |
||
355 | * Return the latitude |
||
356 | * |
||
357 | * @return float Latitude |
||
358 | */ |
||
359 | 1 | public function getLatitude() |
|
363 | |||
364 | /** |
||
365 | * Set the latitude |
||
366 | * |
||
367 | * @param float $latitude Latitude |
||
368 | * @return SystemProperties Self reference |
||
369 | */ |
||
370 | 1 | public function setLatitude($latitude) |
|
377 | |||
378 | /** |
||
379 | * Return the longitude |
||
380 | * |
||
381 | * @return float Longitude |
||
382 | */ |
||
383 | 1 | public function getLongitude() |
|
387 | |||
388 | /** |
||
389 | * Set the longitude |
||
390 | * |
||
391 | * @param float $longitude Longitude |
||
392 | * @return SystemProperties Self reference |
||
393 | */ |
||
394 | 1 | public function setLongitude($longitude) |
|
401 | |||
402 | /** |
||
403 | * Return the elevation |
||
404 | * |
||
405 | * @return float Elevation |
||
406 | */ |
||
407 | 1 | public function getElevation() |
|
411 | |||
412 | /** |
||
413 | * Set the elevation |
||
414 | * |
||
415 | * @param float $elevation |
||
416 | * @return SystemProperties Self reference |
||
417 | */ |
||
418 | 1 | public function setElevation($elevation) |
|
425 | |||
426 | /** |
||
427 | * Derive draft system properties |
||
428 | * |
||
429 | * @param Revision $draftRevision Draft revision |
||
430 | * @return SystemProperties Draft system properties |
||
431 | */ |
||
432 | 5 | public function createDraft(Revision $draftRevision) |
|
447 | |||
448 | /** |
||
449 | * Indicate that the object got published |
||
450 | * |
||
451 | * @return SystemProperties System properties |
||
452 | * @throws RuntimeException If the object is already published |
||
453 | */ |
||
454 | 3 | public function publish() |
|
469 | |||
470 | /** |
||
471 | * Update the object's modification timestamp |
||
472 | * |
||
473 | * @return SystemProperties System properties |
||
474 | */ |
||
475 | 14 | public function touch() |
|
481 | |||
482 | /** |
||
483 | * Set the object's deletion timestamp |
||
484 | * |
||
485 | * @return SystemProperties System properties |
||
486 | */ |
||
487 | 3 | public function delete() |
|
493 | |||
494 | /** |
||
495 | * Unset the object's deletion timestamp |
||
496 | * |
||
497 | * @return SystemProperties System properties |
||
498 | */ |
||
499 | 2 | public function undelete() |
|
505 | |||
506 | /** |
||
507 | * Return the property values as array |
||
508 | * |
||
509 | * @param bool $serialize Serialize property objects |
||
510 | * @return array Property values |
||
511 | */ |
||
512 | 10 | public function toArray($serialize = true) |
|
529 | } |
||
530 |