Complex classes like AbstractObject often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use AbstractObject, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 65 | abstract class AbstractObject implements ObjectInterface |
||
| 66 | { |
||
| 67 | /** |
||
| 68 | * Use traits |
||
| 69 | */ |
||
| 70 | use SystemPropertiesTrait, MetaPropertiesTrait, DomainPropertiesTrait, RelationsTrait, |
||
| 71 | ProcessingInstructionsTrait, PayloadTrait, IterableTrait, StatesTrait; |
||
| 72 | |||
| 73 | /** |
||
| 74 | * Repository locator |
||
| 75 | * |
||
| 76 | * @var RepositoryLocatorInterface |
||
| 77 | */ |
||
| 78 | protected $locator; |
||
| 79 | /** |
||
| 80 | * Latest revision |
||
| 81 | * |
||
| 82 | * @var Revision |
||
| 83 | */ |
||
| 84 | protected $latestRevision; |
||
| 85 | |||
| 86 | /** |
||
| 87 | * Object constructor |
||
| 88 | * |
||
| 89 | * @param RepositoryLocatorInterface $locator Object repository locator |
||
| 90 | * @param string $payload Object payload |
||
| 91 | * @param array $propertyData Property data |
||
| 92 | */ |
||
| 93 | 47 | public function __construct(RepositoryLocatorInterface $locator, $payload = '', array $propertyData = []) |
|
| 94 | { |
||
| 95 | // If the domain property collection class is invalid |
||
| 96 | 47 | if (!$this->domainPropertyCClass |
|
| 97 | 47 | || !class_exists($this->domainPropertyCClass) |
|
| 98 | 47 | || !(new \ReflectionClass($this->domainPropertyCClass))->isSubclassOf(AbstractDomainProperties::class) |
|
| 99 | ) { |
||
| 100 | 1 | throw new PropertyInvalidArgumentException( |
|
| 101 | sprintf( |
||
| 102 | 1 | 'Invalid domain property collection class "%s"', |
|
| 103 | 1 | $this->domainPropertyCClass |
|
| 104 | ), |
||
| 105 | 1 | PropertyInvalidArgumentException::INVALID_DOMAIN_PROPERTY_COLLECTION_CLASS |
|
| 106 | ); |
||
| 107 | } |
||
| 108 | |||
| 109 | // Save the original object locator |
||
| 110 | 46 | $this->locator = $locator; |
|
| 111 | |||
| 112 | // Load the current revision data |
||
| 113 | 46 | $this->loadRevisionData($payload, $propertyData); |
|
| 114 | |||
| 115 | // Determine the latest revision number (considering a possible draft) |
||
| 116 | 45 | $this->latestRevision = $this->hasDraft() |
|
| 117 | ? Kernel::create(Revision::class, [$this->getRevision()->getRevision() + 1, true]) |
||
| 118 | 45 | : $this->getRevision(); |
|
| 119 | |||
| 120 | // Update the object locator |
||
| 121 | 45 | $this->updateLocator(); |
|
| 122 | 45 | } |
|
| 123 | |||
| 124 | /** |
||
| 125 | * Load object revision data |
||
| 126 | * |
||
| 127 | * @param string $payload Object payload |
||
| 128 | * @param array $propertyData Property data |
||
| 129 | */ |
||
| 130 | 46 | protected function loadRevisionData($payload = '', array $propertyData = []) |
|
| 131 | { |
||
| 132 | 46 | $this->payload = $payload; |
|
| 133 | |||
| 134 | // Instantiate the system properties |
||
| 135 | 46 | $systemPropertyData = (empty($propertyData[SystemProperties::COLLECTION]) || |
|
| 136 | 46 | !is_array( |
|
| 137 | 46 | $propertyData[SystemProperties::COLLECTION] |
|
| 138 | 46 | )) ? [] : $propertyData[SystemProperties::COLLECTION]; |
|
| 139 | 46 | $this->systemProperties = Kernel::create(SystemProperties::class, [$systemPropertyData, $this]); |
|
| 140 | |||
| 141 | // Instantiate the meta properties |
||
| 142 | 45 | $metaPropertyData = (empty($propertyData[MetaProperties::COLLECTION]) || |
|
| 143 | 45 | !is_array( |
|
| 144 | 45 | $propertyData[MetaProperties::COLLECTION] |
|
| 145 | 45 | )) ? [] : $propertyData[MetaProperties::COLLECTION]; |
|
| 146 | /** @var MetaProperties $metaProperties */ |
||
| 147 | 45 | $metaProperties = Kernel::create(MetaProperties::class, [$metaPropertyData, $this]); |
|
| 148 | 45 | $this->setMetaProperties($metaProperties, true); |
|
| 149 | |||
| 150 | // Instantiate the domain properties |
||
| 151 | 45 | $domainPropertyData = (empty($propertyData[AbstractDomainProperties::COLLECTION]) || |
|
| 152 | 37 | !is_array( |
|
| 153 | 45 | $propertyData[AbstractDomainProperties::COLLECTION] |
|
| 154 | 45 | )) ? [] : $propertyData[AbstractDomainProperties::COLLECTION]; |
|
| 155 | /** @var AbstractDomainProperties $domainProperties */ |
||
| 156 | 45 | $domainProperties = Kernel::create($this->domainPropertyCClass, [$domainPropertyData, $this]); |
|
| 157 | 45 | $this->setDomainProperties($domainProperties, true); |
|
| 158 | |||
| 159 | // Instantiate the processing instructions |
||
| 160 | 45 | $procInstData = (empty($propertyData[ProcessingInstructions::COLLECTION]) || |
|
| 161 | 31 | !is_array( |
|
| 162 | 45 | $propertyData[ProcessingInstructions::COLLECTION] |
|
| 163 | 45 | )) ? [] : $propertyData[ProcessingInstructions::COLLECTION]; |
|
| 164 | /** @var ProcessingInstructions $procInstCollection */ |
||
| 165 | 45 | $procInstCollection = Kernel::create(ProcessingInstructions::class, [$procInstData, $this]); |
|
| 166 | 45 | $this->setProcessingInstructions($procInstCollection, true); |
|
| 167 | |||
| 168 | // Instantiate the object relations |
||
| 169 | 45 | $relationData = (empty($propertyData[Relations::COLLECTION]) || |
|
| 170 | 38 | !is_array( |
|
| 171 | 45 | $propertyData[Relations::COLLECTION] |
|
| 172 | 45 | )) ? [] : $propertyData[Relations::COLLECTION]; |
|
| 173 | /** @var Relations $relationCollection */ |
||
| 174 | 45 | $relationCollection = Kernel::create(Relations::class, [$relationData, $this]); |
|
| 175 | 45 | $this->setRelations($relationCollection, true); |
|
| 176 | |||
| 177 | // Reset the object state |
||
| 178 | 45 | $this->resetState(); |
|
| 179 | 45 | } |
|
| 180 | |||
| 181 | /** |
||
| 182 | * Return whether this object already has a draft revision |
||
| 183 | * |
||
| 184 | * @return bool Whether this object has a draft revision |
||
| 185 | */ |
||
| 186 | 45 | protected function hasDraft() |
|
| 187 | { |
||
| 188 | // Create the object draft resource locator |
||
| 189 | 45 | $draftLocator = $this->locator->setRevision(Revision::current(true)); |
|
| 190 | |||
| 191 | // Use the object manager to look for a draft resource |
||
| 192 | /** @var ManagerInterface $objectManager */ |
||
| 193 | 45 | $objectManager = Kernel::create(Service::class)->getObjectManager(); |
|
| 194 | 45 | return $objectManager->objectResourceExists($draftLocator); |
|
| 195 | } |
||
| 196 | |||
| 197 | /** |
||
| 198 | * Update the object locator |
||
| 199 | */ |
||
| 200 | 45 | protected function updateLocator() |
|
| 201 | { |
||
| 202 | 45 | $revision = $this->getRevision(); |
|
| 203 | 45 | $this->locator = $this->locator->setRevision( |
|
| 204 | 45 | !$revision->isDraft() && ($this->getCurrentRevision()->getRevision() == $revision->getRevision()) |
|
| 205 | 34 | ? Revision::current($revision->isDraft()) |
|
| 206 | 45 | : $revision |
|
| 207 | 45 | )->setHidden($this->isDeleted()); |
|
| 208 | 45 | } |
|
| 209 | |||
| 210 | /** |
||
| 211 | * Return this object's current revision |
||
| 212 | * |
||
| 213 | * @return Revision Current revision |
||
| 214 | */ |
||
| 215 | 41 | protected function getCurrentRevision() |
|
| 216 | { |
||
| 217 | 41 | if ($this->latestRevision->isDraft() && ($this->latestRevision->getRevision() > 1)) { |
|
| 218 | 1 | return Kernel::create(Revision::class, [$this->latestRevision->getRevision() - 1, false]); |
|
| 219 | } |
||
| 220 | 41 | return $this->latestRevision; |
|
| 221 | } |
||
| 222 | |||
| 223 | /** |
||
| 224 | * Use a specific object revision |
||
| 225 | * |
||
| 226 | * @param Revision $revision Revision to be used |
||
| 227 | * @return ObjectInterface Object |
||
| 228 | * @throws OutOfBoundsException If a revision beyond the latest one is requested |
||
| 229 | */ |
||
| 230 | 40 | public function useRevision(Revision $revision) |
|
| 231 | { |
||
| 232 | // If a revision beyond the latest one is requested |
||
| 233 | 40 | if (!$revision->isCurrent() && ($revision->getRevision() > $this->latestRevision->getRevision())) { |
|
| 234 | 1 | throw new OutOfBoundsException( |
|
| 235 | 1 | sprintf('Invalid object revision "%s"', $revision->getRevision()), |
|
| 236 | 1 | OutOfBoundsException::INVALID_OBJECT_REVISION |
|
| 237 | ); |
||
| 238 | } |
||
| 239 | |||
| 240 | // Determine whether the current revision was requested |
||
| 241 | 40 | $currentRevision = $this->getCurrentRevision(); |
|
| 242 | 40 | $isCurrentRevision = $revision->isCurrent() || $currentRevision->equals($revision); |
|
| 243 | 40 | if ($isCurrentRevision) { |
|
| 244 | 40 | $revision = $currentRevision; |
|
| 245 | } |
||
| 246 | |||
| 247 | // If the requested revision is not already used |
||
| 248 | 40 | if (!$this->getRevision()->equals($revision)) { |
|
| 249 | |||
| 250 | /** @var ManagerInterface $objectManager */ |
||
| 251 | 1 | $objectManager = Kernel::create(Service::class)->getObjectManager(); |
|
| 252 | /** @var Revision $newRevision */ |
||
| 253 | 1 | $newRevision = $isCurrentRevision ? Revision::current() : $revision; |
|
| 254 | /** @var RepositoryLocator $newRevisionLocator */ |
||
| 255 | 1 | $newRevisionLocator = $this->locator->setRevision($newRevision); |
|
| 256 | |||
| 257 | // Instantiate the requested revision resource |
||
| 258 | 1 | $revisionResource = $objectManager->loadObjectResource($newRevisionLocator, SelectorInterface::ALL); |
|
| 259 | |||
| 260 | // Load the revision resource data |
||
| 261 | 1 | $this->loadRevisionData($revisionResource->getPayload(), $revisionResource->getPropertyData()); |
|
| 262 | |||
| 263 | // Update the object locator |
||
| 264 | 1 | $this->updateLocator(); |
|
| 265 | } |
||
| 266 | |||
| 267 | 40 | return $this; |
|
| 268 | } |
||
| 269 | |||
| 270 | /** |
||
| 271 | * Return the object repository locator |
||
| 272 | * |
||
| 273 | * @return RepositoryLocatorInterface Object repository locator |
||
| 274 | */ |
||
| 275 | 47 | public function getRepositoryLocator() |
|
| 279 | |||
| 280 | /** |
||
| 281 | * Return the object property data |
||
| 282 | * |
||
| 283 | * @param bool $serialize Serialize property objects |
||
| 284 | * @return array Object property data |
||
| 285 | */ |
||
| 286 | 10 | public function getPropertyData($serialize = true) |
|
| 300 | |||
| 301 | /** |
||
| 302 | * Return the absolute object URL |
||
| 303 | * |
||
| 304 | * @return string |
||
| 305 | */ |
||
| 306 | 5 | public function getAbsoluteUrl() |
|
| 310 | |||
| 311 | /** |
||
| 312 | * Return the canonical object URL |
||
| 313 | * |
||
| 314 | * @return string |
||
| 315 | */ |
||
| 316 | 1 | public function getCanonicalUrl() |
|
| 320 | |||
| 321 | /** |
||
| 322 | * Persist the current object revision |
||
| 323 | * |
||
| 324 | * @return ObjectInterface Object |
||
| 325 | */ |
||
| 326 | 5 | public function persist() |
|
| 353 | |||
| 354 | /** |
||
| 355 | * Post persistence hook |
||
| 356 | * |
||
| 357 | * @return void |
||
| 358 | */ |
||
| 359 | 3 | protected function postPersist() |
|
| 362 | |||
| 363 | /** |
||
| 364 | * Publish the current object revision |
||
| 365 | * |
||
| 366 | * @return ObjectInterface Object |
||
| 367 | */ |
||
| 368 | 2 | public function publish() |
|
| 379 | |||
| 380 | /** |
||
| 381 | * Delete the object and all its revisions |
||
| 382 | * |
||
| 383 | * @return ObjectInterface Object |
||
| 384 | */ |
||
| 385 | 3 | public function delete() |
|
| 395 | |||
| 396 | /** |
||
| 397 | * Undelete the object and all its revisions |
||
| 398 | * |
||
| 399 | * @return ObjectInterface Object |
||
| 400 | */ |
||
| 401 | 2 | public function undelete() |
|
| 411 | |||
| 412 | /** |
||
| 413 | * Convert this object revision into a draft |
||
| 414 | */ |
||
| 415 | 5 | protected function convertToDraft() |
|
| 431 | } |
||
| 432 |