WebhooksController::__invoke() - Code Metrics - app-vise/laravel-appstore-notifications - Measure and Improve Code Quality continuously with Scrutinizer

WebhooksController::__invoke() A
last analyzed 2020-04-27 16:27 UTC

↳ Parent: WebhooksController

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	20
rs	9.6
c	0
b	0
f	0
cc	2
nc	2
nop	1

<?php

namespace Appvise\AppStoreNotifications;

use Illuminate\Http\Request;
use Appvise\AppStoreNotifications\Model\NotificationType;
use Appvise\AppStoreNotifications\Model\AppleNotification;
use Appvise\AppStoreNotifications\Exceptions\WebhookFailed;
use Appvise\AppStoreNotifications\Model\NotificationPayload;

class WebhooksController
{
    public function __invoke(Request $request)
    {
        $jobConfigKey = NotificationType::{$request->input('notification_type')}();
        $this->determineValidRequest($request->input('password'));

        AppleNotification::storeNotification($jobConfigKey, $request->input());

        $payload = NotificationPayload::createFromRequest($request);

        $jobClass = config("appstore-server-notifications.jobs.{$jobConfigKey}", null);

        if (is_null($jobClass)) {
            throw WebhookFailed::jobClassDoesNotExist($jobConfigKey);
        }

        $job = new $jobClass($payload);
        dispatch($job);

        return response()->json();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }

    private function determineValidRequest(string $password): bool
    {
        if ($password !== config('appstore-server-notifications.shared_secret')) {
            throw WebhookFailed::nonValidRequest();
        }

        return true;
    }
}


1			<?php
2
3			namespace Appvise\AppStoreNotifications;
4
5			use Illuminate\Http\Request;
6			use Appvise\AppStoreNotifications\Model\NotificationType;
7			use Appvise\AppStoreNotifications\Model\AppleNotification;
8			use Appvise\AppStoreNotifications\Exceptions\WebhookFailed;
9			use Appvise\AppStoreNotifications\Model\NotificationPayload;
10
11			class WebhooksController
12			{
13			public function __invoke(Request $request)
14			{
15			$jobConfigKey = NotificationType::{$request->input('notification_type')}();
16			$this->determineValidRequest($request->input('password'));
17
18			AppleNotification::storeNotification($jobConfigKey, $request->input());
19
20			$payload = NotificationPayload::createFromRequest($request);
21
22			$jobClass = config("appstore-server-notifications.jobs.{$jobConfigKey}", null);
23
24			if (is_null($jobClass)) {
25			throw WebhookFailed::jobClassDoesNotExist($jobConfigKey);
26			}
27
28			$job = new $jobClass($payload);
29			dispatch($job);
30
31			return response()->json();
			0 ignored issues – show Bug introduced 2019-10-30 14:17 UTC by Report Bug Copy Issue Report The method `json` does only exist in `Illuminate\Contracts\Routing\ResponseFactory`, but not in `Illuminate\Http\Response`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
32			}
33
34			private function determineValidRequest(string $password): bool
35			{
36			if ($password !== config('appstore-server-notifications.shared_secret')) {
37			throw WebhookFailed::nonValidRequest();
38			}
39
40			return true;
41			}
42			}
43

app-vise / laravel-appstore-notifications

WebhooksController::__invoke() A last analyzed 2020-04-27 16:27 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like

WebhooksController::__invoke() A
last analyzed 2020-04-27 16:27 UTC