NamespaceSorterTest::testCompareNamespaces() - Code Metrics - Inspection of "composer.json: alias master as 5.0.x-dev" - apigen/ApiGen - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 4.2-to-master ( ed215f )

by E

created 2017-04-03 23:21 UTC

NamespaceSorterTest::testCompareNamespaces() A

↳ Parent: NamespaceSorterTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	7
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	4
nc	1
nop	3
dl	0
loc	7
rs	9.4285
c	0
b	0
f	0

<?php declare(strict_types=1);

namespace ApiGen\Parser\Tests\Elements;

use ApiGen\Contracts\Configuration\ConfigurationInterface;
use ApiGen\Contracts\Parser\Elements\NamespaceSorterInterface;
use ApiGen\Parser\Elements\Elements;
use ApiGen\Parser\Elements\NamespaceSorter;
use ApiGen\Tests\MethodInvoker;
use PHPUnit\Framework\Assert;
use PHPUnit\Framework\TestCase;

final class NamespaceSorterTest extends TestCase
{
    /**
     * @var NamespaceSorterInterface
     */
    private $namespaceSorter;

    protected function setUp(): void
    {
        $configurationMock = $this->createMock(ConfigurationInterface::class);

        $this->namespaceSorter = new NamespaceSorter(new Elements, $configurationMock);

    }

    public function testSort(): void
    {
        $groups = ['OneGroup' => [], 'OtherGroup' => [], 'OneMoreGroup' => []];
        $sortedGroups = $this->namespaceSorter->sort($groups);
        $this->assertCount(3, $sortedGroups);
        $this->assertArrayHasKey('OneGroup', $sortedGroups);
        $this->assertArrayHasKey('OtherGroup', $sortedGroups);
        $this->assertArrayHasKey('OneMoreGroup', $sortedGroups);
    }

    public function testSortNoneOnly(): void
    {
        $groups = ['None' => []];
        $sortedGroups = $this->namespaceSorter->sort($groups);
        $this->assertSame([], $sortedGroups);
    }

    public function testIsNoneOnly(): void
    {
        $groups['None'] = true;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        $this->assertTrue(MethodInvoker::callMethodOnObject($this->namespaceSorter, 'isNoneOnly', [$groups]));
    }

    public function testAddMissingParentNamespaces(): void
    {
        $this->assertNull(Assert::getObjectAttribute($this->namespaceSorter, 'namespaces'));
        MethodInvoker::callMethodOnObject(
            $this->namespaceSorter, 'addMissingParentNamespaces', ['Some\Group\Name']
        );

        $groups = Assert::getObjectAttribute($this->namespaceSorter, 'namespaces');
        $this->assertArrayHasKey('Some\Group\Name', $groups);
        $this->assertArrayHasKey('Some\Group', $groups);
        $this->assertArrayHasKey('Some', $groups);
    }

    public function testAddMissingElementTypes(): void
    {
        MethodInvoker::callMethodOnObject($this->namespaceSorter, 'addMissingElementTypes', ['Some\Group']);
        $groups = Assert::getObjectAttribute($this->namespaceSorter, 'namespaces');
        $this->assertArrayHasKey('Some\Group', $groups);

        $someGroup = $groups['Some\Group'];
        $this->assertArrayHasKey('classes', $someGroup);
        $this->assertArrayHasKey('constants', $someGroup);
        $this->assertArrayHasKey('exceptions', $someGroup);
        $this->assertArrayHasKey('functions', $someGroup);
        $this->assertArrayHasKey('interfaces', $someGroup);
        $this->assertArrayHasKey('traits', $someGroup);
    }

    /**
     * @dataProvider getCompareNamespacesData()
     */
    public function testCompareNamespaces(string $one, string $two, int $expected): void
    {
        $this->assertSame(
            $expected,
            MethodInvoker::callMethodOnObject($this->namespaceSorter, 'compareNamespaceNames', [$one, $two])
        );
    }

    /**
     * @return mixed[]
     */
    public function getCompareNamespacesData(): array
    {
        return [
            ['GroupOne', 'OtherGroup', -8],
            ['One', 'Two', -5],
        ];
    }
}


1			<?php declare(strict_types=1);
2
3			namespace ApiGen\Parser\Tests\Elements;
4
5			use ApiGen\Contracts\Configuration\ConfigurationInterface;
6			use ApiGen\Contracts\Parser\Elements\NamespaceSorterInterface;
7			use ApiGen\Parser\Elements\Elements;
8			use ApiGen\Parser\Elements\NamespaceSorter;
9			use ApiGen\Tests\MethodInvoker;
10			use PHPUnit\Framework\Assert;
11			use PHPUnit\Framework\TestCase;
12
13			final class NamespaceSorterTest extends TestCase
14			{
15			/**
16			* @var NamespaceSorterInterface
17			*/
18			private $namespaceSorter;
19
20			protected function setUp(): void
21			{
22			$configurationMock = $this->createMock(ConfigurationInterface::class);
23
24			$this->namespaceSorter = new NamespaceSorter(new Elements, $configurationMock);
			0 ignored issues – show Unused Code introduced 2017-04-03 23:27 UTC by Report Bug Copy Issue Report The call to `NamespaceSorter::__construct()` has too many arguments starting with `$configurationMock`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
25			}
26
27			public function testSort(): void
28			{
29			$groups = ['OneGroup' => [], 'OtherGroup' => [], 'OneMoreGroup' => []];
30			$sortedGroups = $this->namespaceSorter->sort($groups);
31			$this->assertCount(3, $sortedGroups);
32			$this->assertArrayHasKey('OneGroup', $sortedGroups);
33			$this->assertArrayHasKey('OtherGroup', $sortedGroups);
34			$this->assertArrayHasKey('OneMoreGroup', $sortedGroups);
35			}
36
37			public function testSortNoneOnly(): void
38			{
39			$groups = ['None' => []];
40			$sortedGroups = $this->namespaceSorter->sort($groups);
41			$this->assertSame([], $sortedGroups);
42			}
43
44			public function testIsNoneOnly(): void
45			{
46			$groups['None'] = true;
			0 ignored issues – show Coding Style Comprehensibility introduced 2017-04-03 23:27 UTC by Report Bug Copy Issue Report `$groups` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$groups = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
47			$this->assertTrue(MethodInvoker::callMethodOnObject($this->namespaceSorter, 'isNoneOnly', [$groups]));
48			}
49
50			public function testAddMissingParentNamespaces(): void
51			{
52			$this->assertNull(Assert::getObjectAttribute($this->namespaceSorter, 'namespaces'));
53			MethodInvoker::callMethodOnObject(
54			$this->namespaceSorter, 'addMissingParentNamespaces', ['Some\Group\Name']
55			);
56
57			$groups = Assert::getObjectAttribute($this->namespaceSorter, 'namespaces');
58			$this->assertArrayHasKey('Some\Group\Name', $groups);
59			$this->assertArrayHasKey('Some\Group', $groups);
60			$this->assertArrayHasKey('Some', $groups);
61			}
62
63			public function testAddMissingElementTypes(): void
64			{
65			MethodInvoker::callMethodOnObject($this->namespaceSorter, 'addMissingElementTypes', ['Some\Group']);
66			$groups = Assert::getObjectAttribute($this->namespaceSorter, 'namespaces');
67			$this->assertArrayHasKey('Some\Group', $groups);
68
69			$someGroup = $groups['Some\Group'];
70			$this->assertArrayHasKey('classes', $someGroup);
71			$this->assertArrayHasKey('constants', $someGroup);
72			$this->assertArrayHasKey('exceptions', $someGroup);
73			$this->assertArrayHasKey('functions', $someGroup);
74			$this->assertArrayHasKey('interfaces', $someGroup);
75			$this->assertArrayHasKey('traits', $someGroup);
76			}
77
78			/**
79			* @dataProvider getCompareNamespacesData()
80			*/
81			public function testCompareNamespaces(string $one, string $two, int $expected): void
82			{
83			$this->assertSame(
84			$expected,
85			MethodInvoker::callMethodOnObject($this->namespaceSorter, 'compareNamespaceNames', [$one, $two])
86			);
87			}
88
89			/**
90			* @return mixed[]
91			*/
92			public function getCompareNamespacesData(): array
93			{
94			return [
95			['GroupOne', 'OtherGroup', -8],
96			['One', 'Two', -5],
97			];
98			}
99			}
100

apigen / ApiGen

GitHub Access Token became invalid

Push — 4.2-to-master ( ed215f )

NamespaceSorterTest::testCompareNamespaces() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like