1 | <?php |
||
2 | |||
3 | |||
4 | namespace Apie\ValueObjects; |
||
5 | |||
6 | use ReflectionClass; |
||
7 | |||
8 | trait StringEnumTrait |
||
9 | { |
||
10 | use StringTrait; |
||
11 | |||
12 | /** |
||
13 | * @var string[] |
||
14 | */ |
||
15 | private static $lookupTable; |
||
16 | |||
17 | final protected function validValue(string $value): bool |
||
18 | { |
||
19 | $values = self::getLookupTable(); |
||
20 | return isset($values[$value]); |
||
21 | } |
||
22 | |||
23 | final protected function sanitizeValue(string $value): string |
||
24 | { |
||
25 | $values = self::getLookupTable(); |
||
26 | assert(isset($values[$value])); |
||
27 | return $values[$value]; |
||
28 | } |
||
29 | |||
30 | private static function getLookupTable(): array |
||
31 | { |
||
32 | if (!self::$lookupTable) { |
||
0 ignored issues
–
show
|
|||
33 | $values = self::getValidValues(); |
||
34 | self::$lookupTable = []; |
||
35 | foreach ($values as $value) { |
||
36 | self::$lookupTable[$value] = $value; |
||
37 | } |
||
38 | foreach ($values as $key => $value) { |
||
39 | self::$lookupTable[$key] = $value; |
||
40 | } |
||
41 | } |
||
42 | return self::$lookupTable; |
||
43 | } |
||
44 | |||
45 | final public static function getValidValues(): array |
||
46 | { |
||
47 | $reflectionClass = new ReflectionClass(__CLASS__); |
||
48 | return $reflectionClass->getConstants(); |
||
49 | } |
||
50 | } |
||
51 |
This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent.
Consider making the comparison explicit by using
empty(..)
or! empty(...)
instead.