ApiPlatform\Core\Bridge\Symfony\Routing\RouterOperationPathResolver

Complexity

Total Complexity

8

Size/Duplication

Total Lines	47
Duplicated Lines	14.89 %

Coupling/Cohesion

Components	1
Dependencies	6

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	9	2
B	resolveOperationPath()	7	26	6

<?php

/*
 * This file is part of the API Platform project.
 *
 * (c) Kévin Dunglas <dunglas@gmail.com>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

declare(strict_types=1);

namespace ApiPlatform\Core\Bridge\Symfony\Routing;

use ApiPlatform\Core\Exception\InvalidArgumentException;
use ApiPlatform\Core\PathResolver\OperationPathResolverInterface;
use Symfony\Component\Routing\RouterInterface;

/**
 * Resolves the operations path using a Symfony route.
 *
 * @author Guilhem N. <egetick@gmail.com>
 */
final class RouterOperationPathResolver implements OperationPathResolverInterface
{
    private $router;
    private $deferred;

    public function __construct(RouterInterface $router, OperationPathResolverInterface $deferred = null)
    {
        if ($deferred) {
            @trigger_error(sprintf('Passing an instance of %s to %s() is deprecated since version 2.0.10 and will be removed in 3.0.', OperationPathResolverInterface::class, __METHOD__), E_USER_DEPRECATED);

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

        }

        $this->router = $router;
        $this->deferred = $deferred;
    }

    /**
     * {@inheritdoc}
     *
     * @throws InvalidArgumentException
     */
    public function resolveOperationPath(string $resourceShortName, array $operation, bool $collection/*, string $operationName = null*/): string
    {
        if (func_num_args() >= 4) {

This code seems to be duplicated across your project.

            $operationName = func_get_arg(3);
        } else {
            @trigger_error(sprintf('Method %s() will have a 4th `string $operationName` argument in version 3.0. Not defining it is deprecated since 2.0.10.', __METHOD__), E_USER_DEPRECATED);

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

            $operationName = null;
        }

        if (isset($operation['route_name'])) {
            $routeName = $operation['route_name'];
        } elseif (null !== $operationName) {
            $routeName = RouteNameGenerator::generate($operationName, $resourceShortName, $collection);
        } elseif ($this->deferred) {
            return $this->deferred->resolveOperationPath($resourceShortName, $operation, $collection, $operationName);

The call to OperationPathResolverInterface::resolveOperationPath() has too many arguments starting with $operationName.

        } else {
            throw new InvalidArgumentException(sprintf('Cannot resolve operation path for resource short name "%s".', $resourceShortName));
        }

        if (!$route = $this->router->getRouteCollection()->get($routeName)) {
            throw new InvalidArgumentException(sprintf('The route "%s" of the resource "%s" was not found.', $routeName, $resourceShortName));
        }

        return $route->getPath();
    }
}