| Conditions | 13 |
| Paths | 42 |
| Total Lines | 77 |
| Code Lines | 46 |
| Lines | 7 |
| Ratio | 9.09 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 56 | public function getSubcollection(string $resourceClass, array $identifiers, array $context, string $operationName) |
||
| 57 | { |
||
| 58 | $manager = $this->managerRegistry->getManagerForClass($resourceClass); |
||
| 59 | if (null === $manager) { |
||
| 60 | throw new ResourceClassNotSupportedException(); |
||
| 61 | } |
||
| 62 | |||
| 63 | $repository = $manager->getRepository($resourceClass); |
||
| 64 | if (!method_exists($repository, 'createQueryBuilder')) { |
||
| 65 | throw new RuntimeException('The repository class must have a "createQueryBuilder" method.'); |
||
| 66 | } |
||
| 67 | |||
| 68 | if (!isset($context['identifiers']) || !isset($context['property'])) { |
||
| 69 | throw new ResourceClassNotSupportedException('The given resource class is not a subcollection'); |
||
| 70 | } |
||
| 71 | |||
| 72 | $queryBuilder = $repository->createQueryBuilder('o'); |
||
| 73 | $queryNameGenerator = new QueryNameGenerator(); |
||
| 74 | $previousQueryBuilder = null; |
||
| 75 | $previousAlias = null; |
||
| 76 | |||
| 77 | $num = count($context['identifiers']); |
||
| 78 | |||
| 79 | while ($num--) { |
||
| 80 | list($identifier, $identifierResourceClass) = $context['identifiers'][$num]; |
||
| 81 | $previousIdentifier = $context['identifiers'][$num + 1][0] ?? $context['property']; |
||
| 82 | |||
| 83 | $classMetadata = $manager->getClassMetadata($identifierResourceClass); |
||
| 84 | |||
| 85 | $qb = $manager->createQueryBuilder(); |
||
| 86 | $alias = $queryNameGenerator->generateJoinAlias($identifier); |
||
| 87 | |||
| 88 | if (null !== $previousIdentifier) { |
||
| 89 | //MANY_TO_MANY relations needs an explicit join so that the identifier part can be retrieved |
||
| 90 | if ($classMetadata->getAssociationMapping($previousIdentifier)['type'] === ClassMetadataInfo::MANY_TO_MANY) { |
||
| 91 | $joinAlias = $queryNameGenerator->generateJoinAlias($previousIdentifier); |
||
| 92 | |||
| 93 | $qb->select($joinAlias) |
||
| 94 | ->from($identifierResourceClass, $alias) |
||
| 95 | ->innerJoin("$alias.$previousIdentifier", $joinAlias); |
||
| 96 | } else { |
||
| 97 | $qb->select("IDENTITY($alias.$previousIdentifier)") |
||
| 98 | ->from($identifierResourceClass, $alias); |
||
| 99 | } |
||
| 100 | } |
||
| 101 | |||
| 102 | $normalizedIdentifiers = $this->normalizeIdentifiers($identifiers[$identifier], $manager, $identifierResourceClass); |
||
| 103 | |||
| 104 | foreach ($normalizedIdentifiers as $key => $value) { |
||
| 105 | $placeholder = $queryNameGenerator->generateParameterName($key); |
||
| 106 | $qb->andWhere("$alias.$key = :$placeholder"); |
||
| 107 | $queryBuilder->setParameter($placeholder, $value); |
||
| 108 | } |
||
| 109 | |||
| 110 | if (null === $previousQueryBuilder) { |
||
| 111 | $previousQueryBuilder = $qb; |
||
| 112 | } else { |
||
| 113 | $previousQueryBuilder->andWhere($qb->expr()->in($previousAlias, $qb->getDQL())); |
||
| 114 | } |
||
| 115 | |||
| 116 | $previousAlias = $alias; |
||
| 117 | } |
||
| 118 | |||
| 119 | $queryBuilder->where( |
||
| 120 | $queryBuilder->expr()->in('o', $previousQueryBuilder->getDQL()) |
||
| 121 | ); |
||
| 122 | |||
| 123 | View Code Duplication | foreach ($this->collectionExtensions as $extension) { |
|
| 124 | $extension->applyToCollection($queryBuilder, $queryNameGenerator, $resourceClass, $operationName); |
||
| 125 | |||
| 126 | if ($extension instanceof QueryResultCollectionExtensionInterface && $extension->supportsResult($resourceClass, $operationName)) { |
||
| 127 | return $extension->getResult($queryBuilder); |
||
| 128 | } |
||
| 129 | } |
||
| 130 | |||
| 131 | return $queryBuilder->getQuery()->getResult(); |
||
| 132 | } |
||
| 133 | } |
||
| 134 |
This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function.
Consider the following example. The parameter
$italyis not defined by the methodfinale(...).The most likely cause is that the parameter was removed, but the annotation was not.