IdentifierConverter::convert() - Code Metrics - Inspection of "Merge pull request #3245 from teohhanhui/merge-2.5" - api-platform/core - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 906aaa...a12ac4 )

by Han Hui

created 2019-11-12 15:02 UTC

IdentifierConverter::convert() B

↳ Parent: IdentifierConverter

Complexity

Conditions	10
Paths	22

Size

Total Lines	41
Code Lines	23

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	10
eloc	23
nc	22
nop	3
dl	0
loc	41
rs	7.6666
c	0
b	0
f	0

How to fix Complexity

<?php

/*
 * This file is part of the API Platform project.
 *
 * (c) Kévin Dunglas <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

declare(strict_types=1);

namespace ApiPlatform\Core\Identifier;

use ApiPlatform\Core\Api\IdentifiersExtractorInterface;
use ApiPlatform\Core\Exception\InvalidIdentifierException;
use ApiPlatform\Core\Metadata\Property\Factory\PropertyMetadataFactoryInterface;
use ApiPlatform\Core\Metadata\Resource\Factory\ResourceMetadataFactoryInterface;
use Symfony\Component\PropertyInfo\Type;
use Symfony\Component\Serializer\Normalizer\DenormalizerInterface;

/**
 * Identifier converter that chains identifier denormalizers.
 *
 * @author Antoine Bluchet <[email protected]>
 */
final class IdentifierConverter implements ContextAwareIdentifierConverterInterface
{
    private $propertyMetadataFactory;
    private $identifiersExtractor;
    private $identifierDenormalizers;
    private $resourceMetadataFactory;

    /**
     * @param iterable<DenormalizerInterface> $identifierDenormalizers
     */
    public function __construct(IdentifiersExtractorInterface $identifiersExtractor, PropertyMetadataFactoryInterface $propertyMetadataFactory, iterable $identifierDenormalizers, ResourceMetadataFactoryInterface $resourceMetadataFactory = null)
    {
        $this->propertyMetadataFactory = $propertyMetadataFactory;
        $this->identifiersExtractor = $identifiersExtractor;
        $this->identifierDenormalizers = $identifierDenormalizers;
        $this->resourceMetadataFactory = $resourceMetadataFactory;
    }

    /**
     * {@inheritdoc}
     */
    public function convert(string $data, string $class, array $context = []): array
    {
        if (null !== $this->resourceMetadataFactory) {
            $resourceMetadata = $this->resourceMetadataFactory->create($class);
            $class = $resourceMetadata->getOperationAttribute($context, 'output', ['class' => $class], true)['class'];
        }

        $keys = $this->identifiersExtractor->getIdentifiersFromResourceClass($class);

        if (($numIdentifiers = \count($keys)) > 1) {
            $identifiers = CompositeIdentifierParser::parse($data);
        } elseif (0 === $numIdentifiers) {
            throw new InvalidIdentifierException(sprintf('Resource "%s" has no identifiers.', $class));
        } else {
            $identifiers = [$keys[0] => $data];
        }

        // Normalize every identifier (DateTime, UUID etc.)
        foreach ($keys as $key) {
            if (!isset($identifiers[$key])) {
                throw new InvalidIdentifierException(sprintf('Invalid identifier "%1$s", "%1$s" was not found.', $key));
            }

            if (null === $type = $this->getIdentifierType($class, $key)) {
                continue;
            }

            foreach ($this->identifierDenormalizers as $identifierDenormalizer) {
                if (!$identifierDenormalizer->supportsDenormalization($identifiers[$key], $type)) {
                    continue;
                }

                try {
                    $identifiers[$key] = $identifierDenormalizer->denormalize($identifiers[$key], $type);
                } catch (InvalidIdentifierException $e) {
                    throw new InvalidIdentifierException(sprintf('Identifier "%s" could not be denormalized.', $key), $e->getCode(), $e);
                }
            }
        }

        return $identifiers;
    }

    private function getIdentifierType(string $resourceClass, string $property): ?string
    {
        if (!$type = $this->propertyMetadataFactory->create($resourceClass, $property)->getType()) {
            return null;
        }

        return Type::BUILTIN_TYPE_OBJECT === ($builtinType = $type->getBuiltinType()) ? $type->getClassName() : $builtinType;
    }
}


1			<?php
2
3			/*
4			* This file is part of the API Platform project.
5			*
6			* (c) Kévin Dunglas <[email protected]>
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			declare(strict_types=1);
13
14			namespace ApiPlatform\Core\Identifier;
15
16			use ApiPlatform\Core\Api\IdentifiersExtractorInterface;
17			use ApiPlatform\Core\Exception\InvalidIdentifierException;
18			use ApiPlatform\Core\Metadata\Property\Factory\PropertyMetadataFactoryInterface;
19			use ApiPlatform\Core\Metadata\Resource\Factory\ResourceMetadataFactoryInterface;
20			use Symfony\Component\PropertyInfo\Type;
21			use Symfony\Component\Serializer\Normalizer\DenormalizerInterface;
22
23			/**
24			* Identifier converter that chains identifier denormalizers.
25			*
26			* @author Antoine Bluchet <[email protected]>
27			*/
28			final class IdentifierConverter implements ContextAwareIdentifierConverterInterface
29			{
30			private $propertyMetadataFactory;
31			private $identifiersExtractor;
32			private $identifierDenormalizers;
33			private $resourceMetadataFactory;
34
35			/**
36			* @param iterable<DenormalizerInterface> $identifierDenormalizers
37			*/
38			public function __construct(IdentifiersExtractorInterface $identifiersExtractor, PropertyMetadataFactoryInterface $propertyMetadataFactory, iterable $identifierDenormalizers, ResourceMetadataFactoryInterface $resourceMetadataFactory = null)
39			{
40			$this->propertyMetadataFactory = $propertyMetadataFactory;
41			$this->identifiersExtractor = $identifiersExtractor;
42			$this->identifierDenormalizers = $identifierDenormalizers;
43			$this->resourceMetadataFactory = $resourceMetadataFactory;
44			}
45
46			/**
47			* {@inheritdoc}
48			*/
49			public function convert(string $data, string $class, array $context = []): array
50			{
51			if (null !== $this->resourceMetadataFactory) {
52			$resourceMetadata = $this->resourceMetadataFactory->create($class);
53			$class = $resourceMetadata->getOperationAttribute($context, 'output', ['class' => $class], true)['class'];
54			}
55
56			$keys = $this->identifiersExtractor->getIdentifiersFromResourceClass($class);
57
58			if (($numIdentifiers = \count($keys)) > 1) {
59			$identifiers = CompositeIdentifierParser::parse($data);
60			} elseif (0 === $numIdentifiers) {
61			throw new InvalidIdentifierException(sprintf('Resource "%s" has no identifiers.', $class));
62			} else {
63			$identifiers = [$keys[0] => $data];
64			}
65
66			// Normalize every identifier (DateTime, UUID etc.)
67			foreach ($keys as $key) {
68			if (!isset($identifiers[$key])) {
69			throw new InvalidIdentifierException(sprintf('Invalid identifier "%1$s", "%1$s" was not found.', $key));
70			}
71
72			if (null === $type = $this->getIdentifierType($class, $key)) {
73			continue;
74			}
75
76			foreach ($this->identifierDenormalizers as $identifierDenormalizer) {
77			if (!$identifierDenormalizer->supportsDenormalization($identifiers[$key], $type)) {
78			continue;
79			}
80
81			try {
82			$identifiers[$key] = $identifierDenormalizer->denormalize($identifiers[$key], $type);
83			} catch (InvalidIdentifierException $e) {
84			throw new InvalidIdentifierException(sprintf('Identifier "%s" could not be denormalized.', $key), $e->getCode(), $e);
85			}
86			}
87			}
88
89			return $identifiers;
90			}
91
92			private function getIdentifierType(string $resourceClass, string $property): ?string
93			{
94			if (!$type = $this->propertyMetadataFactory->create($resourceClass, $property)->getType()) {
95			return null;
96			}
97
98			return Type::BUILTIN_TYPE_OBJECT === ($builtinType = $type->getBuiltinType()) ? $type->getClassName() : $builtinType;
99			}
100			}
101

api-platform / core

Push — master ( 906aaa...a12ac4 )

IdentifierConverter::convert() B

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like