ApiPlatform\Core\Bridge\Doctrine\MongoDB\ItemDataProvider::getItem()

Complexity

Conditions	12
Paths	35

Size

Total Lines	54
Code Lines	30

Duplication

Lines	15
Ratio	27.78 %

Importance

Changes	3
Bugs	0	Features	1

<?php
    public function getItem(string $resourceClass, $id, string $operationName = null, bool $fetchData = false)
    {
        if ($this->decorated) {
            try {
                return $this->decorated->getItem($resourceClass, $id, $operationName, $fetchData);
            } catch (ResourceClassNotSupportedException $resourceClassNotSupportedException) {
                // Ignore it
            }
        }

        $manager = $this->managerRegistry->getManagerForClass($resourceClass);
        if (null === $manager) {
            throw new ResourceClassNotSupportedException();
        }

        $identifierValues = explode('-', $id);
        $identifiers = [];
        $i = 0;

        foreach ($this->propertyNameCollectionFactory->create($resourceClass) as $propertyName) {

This code seems to be duplicated across your project.

            $itemMetadata = $this->propertyMetadataFactory->create($resourceClass, $propertyName);

            $identifier = $itemMetadata->isIdentifier();
            if (null === $identifier || false === $identifier) {
                continue;
            }

            if (!isset($identifierValues[$i])) {
                throw new InvalidArgumentException(sprintf('Invalid identifier "%s".', $id));
            }

            $identifiers[$propertyName] = $identifierValues[$i];
            ++$i;
        }

        if (!$fetchData || $manager instanceof DocumentManager) {
            return $manager->getReference($resourceClass, reset($identifiers));
        }

        /** @var DocumentRepository $repository */
        $repository = $manager->getRepository($resourceClass);
        $queryBuilder = $repository->createQueryBuilder();

        foreach ($identifiers as $propertyName => $value) {
            $queryBuilder
                ->field($propertyName)->equals($value);
        }

        foreach ($this->itemExtensions as $extension) {
            $extension->applyToItem($queryBuilder, $resourceClass, $identifiers, $operationName);
        }

        return $queryBuilder->getQuery()->getSingleResult();

The expression $queryBuilder->getQuery()->getSingleResult(); of type array|object|null adds the type array to the return on line 106 which is incompatible with the return type declared by the interface ApiPlatform\Core\DataProvider\ItemDataProviderInterface::getItem of type object|null.

    }
}