Completed
Pull Request — master (#904)
by Antoine
05:57 queued 02:43
created

SubcollectionDataProvider::getSubcollection()   D

Complexity

Conditions 14
Paths 43

Size

Total Lines 83
Code Lines 49

Duplication

Lines 7
Ratio 8.43 %

Importance

Changes 0
Metric Value
dl 7
loc 83
rs 4.9516
c 0
b 0
f 0
cc 14
eloc 49
nc 43
nop 4

How to fix   Long Method    Complexity   

Long Method

Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.

For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.

Commonly applied refactorings include:

1
<?php
2
3
/*
4
 * This file is part of the API Platform project.
5
 *
6
 * (c) Kévin Dunglas <[email protected]>
7
 *
8
 * For the full copyright and license information, please view the LICENSE
9
 * file that was distributed with this source code.
10
 */
11
12
namespace ApiPlatform\Core\Bridge\Doctrine\Orm;
13
14
use ApiPlatform\Core\Bridge\Doctrine\Orm\Extension\QueryResultCollectionExtensionInterface;
15
use ApiPlatform\Core\Bridge\Doctrine\Orm\Util\IdentifierManagerTrait;
16
use ApiPlatform\Core\Bridge\Doctrine\Orm\Util\QueryNameGenerator;
17
use ApiPlatform\Core\DataProvider\SubcollectionDataProviderInterface;
18
use ApiPlatform\Core\Exception\ResourceClassNotSupportedException;
19
use ApiPlatform\Core\Exception\RuntimeException;
20
use ApiPlatform\Core\Metadata\Property\Factory\PropertyMetadataFactoryInterface;
21
use ApiPlatform\Core\Metadata\Property\Factory\PropertyNameCollectionFactoryInterface;
22
use Doctrine\Common\Persistence\ManagerRegistry;
23
use Doctrine\ORM\EntityManagerInterface;
24
use Doctrine\ORM\Mapping\ClassMetadataInfo;
25
26
/**
27
 * Subcollection data provider for the Doctrine ORM.
28
 *
29
 * @author Antoine Bluchet <[email protected]>
30
 */
31
class SubcollectionDataProvider implements SubcollectionDataProviderInterface
32
{
33
    use IdentifierManagerTrait;
34
35
    private $managerRegistry;
36
    private $collectionExtensions;
37
38
    /**
39
     * @param ManagerRegistry                        $managerRegistry
40
     * @param PropertyNameCollectionFactoryInterface $propertyNameCollectionFactory
41
     * @param PropertyMetadataFactoryInterface       $propertyMetadataFactory
42
     * @param QueryItemExtensionInterface[]          $itemExtensions
0 ignored issues
show
Bug introduced by
There is no parameter named $itemExtensions. Was it maybe removed?

This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function.

Consider the following example. The parameter $italy is not defined by the method finale(...).

/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}

The most likely cause is that the parameter was removed, but the annotation was not.

Loading history...
43
     */
44
    public function __construct(ManagerRegistry $managerRegistry, PropertyNameCollectionFactoryInterface $propertyNameCollectionFactory, PropertyMetadataFactoryInterface $propertyMetadataFactory, array $collectionExtensions = [])
45
    {
46
        $this->managerRegistry = $managerRegistry;
47
        $this->propertyNameCollectionFactory = $propertyNameCollectionFactory;
48
        $this->propertyMetadataFactory = $propertyMetadataFactory;
49
        $this->collectionExtensions = $collectionExtensions;
50
    }
51
52
    /**
53
     * {@inheritdoc}
54
     *
55
     * @throws RuntimeException
56
     */
57
    public function getSubcollection(string $resourceClass, array $identifiers, array $context, string $operationName = null)
58
    {
59
        $manager = $this->managerRegistry->getManagerForClass($resourceClass);
60
        if (null === $manager) {
61
            throw new ResourceClassNotSupportedException();
62
        }
63
64
        $repository = $manager->getRepository($resourceClass);
65
        if (!method_exists($repository, 'createQueryBuilder')) {
66
            throw new RuntimeException('The repository class must have a "createQueryBuilder" method.');
67
        }
68
69
        if (!isset($context['identifiers']) || !isset($context['property'])) {
70
            throw new ResourceClassNotSupportedException('The given resource class is not a subcollection.');
71
        }
72
73
        $queryBuilder = $repository->createQueryBuilder('o');
74
        $queryNameGenerator = new QueryNameGenerator();
75
        $previousQueryBuilder = null;
76
        $previousAlias = null;
77
78
        $num = count($context['identifiers']);
79
80
        while ($num--) {
81
            list($identifier, $identifierResourceClass) = $context['identifiers'][$num];
82
            $previousIdentifier = $context['identifiers'][$num + 1][0] ?? $context['property'];
83
84
            $manager = $this->managerRegistry->getManagerForClass($identifierResourceClass);
85
86
            if (!($manager instanceof EntityManagerInterface)) {
87
                throw new RuntimeException("The manager for $identifierResourceClass must be an EntityManager.");
88
            }
89
90
            $classMetadata = $manager->getClassMetadata($identifierResourceClass);
91
92
            $qb = $manager->createQueryBuilder();
93
            $alias = $queryNameGenerator->generateJoinAlias($identifier);
94
95
            if (null !== $previousIdentifier) {
96
                //MANY_TO_MANY relations needs an explicit join so that the identifier part can be retrieved
97
                if ($classMetadata->getAssociationMapping($previousIdentifier)['type'] === ClassMetadataInfo::MANY_TO_MANY) {
98
                    $joinAlias = $queryNameGenerator->generateJoinAlias($previousIdentifier);
99
100
                    $qb->select($joinAlias)
101
                        ->from($identifierResourceClass, $alias)
102
                        ->innerJoin("$alias.$previousIdentifier", $joinAlias);
103
                } else {
104
                    $qb->select("IDENTITY($alias.$previousIdentifier)")
105
                        ->from($identifierResourceClass, $alias);
106
                }
107
            }
108
109
            $normalizedIdentifiers = $this->normalizeIdentifiers($identifiers[$identifier], $manager, $identifierResourceClass);
110
111
            foreach ($normalizedIdentifiers as $key => $value) {
112
                $placeholder = $queryNameGenerator->generateParameterName($key);
113
                $qb->andWhere("$alias.$key = :$placeholder");
114
                $queryBuilder->setParameter($placeholder, $value);
115
            }
116
117
            if (null === $previousQueryBuilder) {
118
                $previousQueryBuilder = $qb;
119
            } else {
120
                $previousQueryBuilder->andWhere($qb->expr()->in($previousAlias, $qb->getDQL()));
121
            }
122
123
            $previousAlias = $alias;
124
        }
125
126
        $queryBuilder->where(
127
            $queryBuilder->expr()->in('o', $previousQueryBuilder->getDQL())
128
        );
129
130 View Code Duplication
        foreach ($this->collectionExtensions as $extension) {
0 ignored issues
show
Duplication introduced by
This code seems to be duplicated across your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
131
            $extension->applyToCollection($queryBuilder, $queryNameGenerator, $resourceClass, $operationName);
132
133
            if ($extension instanceof QueryResultCollectionExtensionInterface && $extension->supportsResult($resourceClass, $operationName)) {
134
                return $extension->getResult($queryBuilder);
135
            }
136
        }
137
138
        return $queryBuilder->getQuery()->getResult();
139
    }
140
}
141