VarnishPurger::purgeRequest() - Code Metrics - Inspection of "send Varnish BAN requests with smaller headers" - api-platform/core - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#2865)

by Jocelyn

created 2019-06-17 13:44 UTC

VarnishPurger::purgeRequest() A

↳ Parent: VarnishPurger

Complexity

Conditions	3
Paths	4

Size

Total Lines	11
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	3
eloc	6
nc	4
nop	1
dl	0
loc	11
rs	10
c	0
b	0
f	0

<?php

/*
 * This file is part of the API Platform project.
 *
 * (c) Kévin Dunglas <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

declare(strict_types=1);

namespace ApiPlatform\Core\HttpCache;

use GuzzleHttp\ClientInterface;

/**
 * Purges Varnish.
 *
 * @author Kévin Dunglas <[email protected]>
 *
 * @experimental
 */
final class VarnishPurger implements PurgerInterface
{
    const CHUNK_SIZE = 100;
    private $clients;

    /**
     * @param ClientInterface[] $clients
     */
    public function __construct(array $clients)
    {
        $this->clients = $clients;
    }

    /**
     * {@inheritdoc}
     */
    public function purge(array $iris)
    {
        if (!$iris) {

            return;
        }

        $irisChunks = array_chunk($iris, self::CHUNK_SIZE);
        foreach($irisChunks as $irisChunk) {
            $this->purgeRequest($irisChunk);
        }
    }

    private function purgeRequest(array $iris)
    {
        // Create the regex to purge all tags in just one request
        $parts = array_map(function ($iri) {
            return sprintf('(^|\,)%s($|\,)', preg_quote($iri));
        }, $iris);

        $regex = \count($parts) > 1 ? sprintf('(%s)', implode(')|(', $parts)) : array_shift($parts);

        foreach ($this->clients as $client) {
            $client->request('BAN', '', ['headers' => ['ApiPlatform-Ban-Regex' => $regex]]);
        }
    }

}


1			<?php
2
3			/*
4			* This file is part of the API Platform project.
5			*
6			* (c) Kévin Dunglas <[email protected]>
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			declare(strict_types=1);
13
14			namespace ApiPlatform\Core\HttpCache;
15
16			use GuzzleHttp\ClientInterface;
17
18			/**
19			* Purges Varnish.
20			*
21			* @author Kévin Dunglas <[email protected]>
22			*
23			* @experimental
24			*/
25			final class VarnishPurger implements PurgerInterface
26			{
27			const CHUNK_SIZE = 100;
28			private $clients;
29
30			/**
31			* @param ClientInterface[] $clients
32			*/
33			public function __construct(array $clients)
34			{
35			$this->clients = $clients;
36			}
37
38			/**
39			* {@inheritdoc}
40			*/
41			public function purge(array $iris)
42			{
43			if (!$iris) {
			0 ignored issues – show Bug Best Practice introduced 2018-02-08 13:38 UTC by Report Bug Copy Issue Report The expression `$iris` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
44			return;
45			}
46
47			$irisChunks = array_chunk($iris, self::CHUNK_SIZE);
48			foreach($irisChunks as $irisChunk) {
49			$this->purgeRequest($irisChunk);
50			}
51			}
52
53			private function purgeRequest(array $iris)
54			{
55			// Create the regex to purge all tags in just one request
56			$parts = array_map(function ($iri) {
57			return sprintf('(^\|\,)%s($\|\,)', preg_quote($iri));
58			}, $iris);
59
60			$regex = \count($parts) > 1 ? sprintf('(%s)', implode(')\|(', $parts)) : array_shift($parts);
61
62			foreach ($this->clients as $client) {
63			$client->request('BAN', '', ['headers' => ['ApiPlatform-Ban-Regex' => $regex]]);
64			}
65			}
66
67			}
68

api-platform / core

Pull Request — master (#2865)

VarnishPurger::purgeRequest() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like