Issues in FilterCollection.php - New Issues - Inspection of "Merge pull request #1099 from meyerbaptiste/add_fi..." - api-platform/core - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( a40985...862247 )

by Kévin

created 2017-05-15 12:54 UTC

src/Api/FilterCollection.php (1 issue)

Labels

Severity

Major 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/*
 * This file is part of the API Platform project.
 *
 * (c) Kévin Dunglas <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

declare(strict_types=1);

namespace ApiPlatform\Core\Api;

use Psr\Container\ContainerInterface;

/**
 * A list of filters.
 *
 * @author Kévin Dunglas <[email protected]>
 *
 * @deprecated since version 2.1, to be removed in 3.0. Use a service locator {@see \Psr\Container\ContainerInterface}.
 */
final class FilterCollection extends \ArrayObject
{
    public function __construct($input = [], $flags = 0, $iterator_class = 'ArrayIterator')
    {
        @trigger_error(sprintf('The %s class is deprecated since version 2.1 and will be removed in 3.0. Provide an implementation of %s instead.', self::class, ContainerInterface::class), E_USER_DEPRECATED);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}

        parent::__construct($input, $flags, $iterator_class);
    }
}


1			<?php
2
3			/*
4			* This file is part of the API Platform project.
5			*
6			* (c) Kévin Dunglas <[email protected]>
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			declare(strict_types=1);
13
14			namespace ApiPlatform\Core\Api;
15
16			use Psr\Container\ContainerInterface;
17
18			/**
19			* A list of filters.
20			*
21			* @author Kévin Dunglas <[email protected]>
22			*
23			* @deprecated since version 2.1, to be removed in 3.0. Use a service locator {@see \Psr\Container\ContainerInterface}.
24			*/
25			final class FilterCollection extends \ArrayObject
26			{
27			public function __construct($input = [], $flags = 0, $iterator_class = 'ArrayIterator')
28			{
29			@trigger_error(sprintf('The %s class is deprecated since version 2.1 and will be removed in 3.0. Provide an implementation of %s instead.', self::class, ContainerInterface::class), E_USER_DEPRECATED);
			1 ignored issue – show Security Best Practice introduced 2017-05-10 14:28 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
30
31			parent::__construct($input, $flags, $iterator_class);
32			}
33			}
34

api-platform / core

Push — master ( a40985...862247 )

src/Api/FilterCollection.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like