DashOperationPathResolver::__construct() - Code Metrics - Inspection of "Merge pull request #1368 from meyerbaptiste/merge_..." - api-platform/core - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 084be5...060764 )

unknown

created 2017-09-13 21:31 UTC

DashOperationPathResolver::__construct() A

↳ Parent: DashOperationPathResolver

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	4
Ratio	100 %

Importance

Changes

Metric	Value
dl	4
loc	4
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	0

<?php

/*
 * This file is part of the API Platform project.
 *
 * (c) Kévin Dunglas <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

declare(strict_types=1);

namespace ApiPlatform\Core\PathResolver;

use ApiPlatform\Core\Operation\DashPathSegmentNameGenerator;

/**
 * Generates a path with words separated by underscores.
 *
 * @author Paul Le Corre <[email protected]>
 *
 * @deprecated since version 2.1, to be removed in 3.0. Use {@see \ApiPlatform\Core\Operation\DashPathSegmentNameGenerator} instead.
 */
final class DashOperationPathResolver implements OperationPathResolverInterface

{
    public function __construct()
    {
        @trigger_error(sprintf('The use of %s is deprecated since 2.1. Please use %s instead.', __CLASS__, DashPathSegmentNameGenerator::class), E_USER_DEPRECATED);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
    }

    /**
     * {@inheritdoc}
     */
    public function resolveOperationPath(string $resourceShortName, array $operation, $operationType/*, string $operationName = null*/): string
    {
        if (func_num_args() >= 4) {
            $operationName = func_get_arg(3);
        } else {
            $operationName = null;
        }

        return (new OperationPathResolver(new DashPathSegmentNameGenerator()))->resolveOperationPath($resourceShortName, $operation, $operationType, $operationName);

    }
}


1		<?php
2
3		/*
4		* This file is part of the API Platform project.
5		*
6		* (c) Kévin Dunglas <[email protected]>
7		*
8		* For the full copyright and license information, please view the LICENSE
9		* file that was distributed with this source code.
10		*/
11
12		declare(strict_types=1);
13
14		namespace ApiPlatform\Core\PathResolver;
15
16		use ApiPlatform\Core\Operation\DashPathSegmentNameGenerator;
17
18		/**
19		* Generates a path with words separated by underscores.
20		*
21		* @author Paul Le Corre <[email protected]>
22		*
23		* @deprecated since version 2.1, to be removed in 3.0. Use {@see \ApiPlatform\Core\Operation\DashPathSegmentNameGenerator} instead.
24		*/
25	View Code Duplication	final class DashOperationPathResolver implements OperationPathResolverInterface
		0 ignored issues – show Duplication introduced 2017-07-12 13:05 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
26		{
27		public function __construct()
28		{
29		@trigger_error(sprintf('The use of %s is deprecated since 2.1. Please use %s instead.', __CLASS__, DashPathSegmentNameGenerator::class), E_USER_DEPRECATED);
		1 ignored issue – show Security Best Practice introduced 2017-09-12 14:05 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
30		}
31
32		/**
33		* {@inheritdoc}
34		*/
35		public function resolveOperationPath(string $resourceShortName, array $operation, $operationType/, string $operationName = null/): string
36		{
37		if (func_num_args() >= 4) {
38		$operationName = func_get_arg(3);
39		} else {
40		$operationName = null;
41		}
42
43		return (new OperationPathResolver(new DashPathSegmentNameGenerator()))->resolveOperationPath($resourceShortName, $operation, $operationType, $operationName);
		0 ignored issues – show Unused Code introduced 2017-07-12 13:05 UTC by Report Bug Copy Issue Report The call to `OperationPathResolver::resolveOperationPath()` has too many arguments starting with `$operationName`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
44		}
45		}
46

api-platform / core

Push — master ( 084be5...060764 )

DashOperationPathResolver::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like