ApiPlatform\Core\JsonSchema\Command\JsonSchemaGenerateCommand::execute()

Complexity

Conditions	11
Paths	8

Size

Total Lines	34
Code Lines	20

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

<?php
    protected function execute(InputInterface $input, OutputInterface $output)
    {
        $io = new SymfonyStyle($input, $output);

        $resource = $input->getArgument('resource');
        $itemOperation = $input->getOption('itemOperation');
        $collectionOperation = $input->getOption('collectionOperation');
        $format = $input->getOption('format');
        $outputType = $input->getOption('output');

        if (!isset($this->formats[$format])) {
            throw new InvalidOptionException(sprintf('The response format "%s" is not supported. Supported formats are : %s.', $format, implode(', ', array_keys($this->formats))));

It seems like $format can also be of type string[]; however, parameter $args of sprintf() does only seem to accept string, maybe add an additional type check?

        }

        $operationType = null;
        $operationName = null;

        if ($itemOperation && $collectionOperation) {
            throw new InvalidOptionException('You can only use one of "--itemOperation" and "--collectionOperation" options at the same time.');
        }

        if (null !== $itemOperation || null !== $collectionOperation) {
            $operationType = $itemOperation ? OperationType::ITEM : OperationType::COLLECTION;
            $operationName = $itemOperation ?? $collectionOperation;
        }

        $schema = $this->schemaFactory->buildSchema($resource, $format,  $outputType , $operationType, $operationName);

It seems like $resource can also be of type null and string[]; however, parameter $resourceClass of ApiPlatform\Core\JsonSchema\SchemaFactoryInterface::buildSchema() does only seem to accept string, maybe add an additional type check?

        if (null !== $operationType && null !== $operationName && !$schema->isDefined()) {
            $io->error(sprintf('There is no %s defined for the operation "%s" of the resource "%s".',  $outputType ? 'outputs': 'inputs', $operationName, $resource));
            return;
        }

        $io->text(json_encode($schema, JSON_PRETTY_PRINT | JSON_UNESCAPED_SLASHES));
    }