Response::getInfo() - Code Metrics - Inspection of "Add an HTTP client dedicated to functional API tes..." - api-platform/core - Measure and Improve Code Quality continuously with Scrutinizer

Passed
Pull Request — master (#2608)

by Kévin
created 2019-06-24 21:19 UTC
Response::getInfo() A

↳ Parent: Response
Complexity

Conditions	2
Paths	2
Size

Total Lines	7
Code Lines	3
Duplication

Lines	0
Ratio	0 %
Importance

Changes	1
Bugs	0	Features	0
Metric	Value
cc	2
eloc	3
c	1
b	0
f	0
nc	2
nop	1
dl	0
loc	7
rs	10
<?php

/*
 * This file is part of the API Platform project.
 *
 * (c) Kévin Dunglas <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

declare(strict_types=1);

namespace ApiPlatform\Core\Bridge\Symfony\Bundle\Test;

use Symfony\Component\BrowserKit\Response as BrowserKitResponse;
use Symfony\Component\HttpClient\Exception\ClientException;
use Symfony\Component\HttpClient\Exception\JsonException;
use Symfony\Component\HttpClient\Exception\RedirectionException;
use Symfony\Component\HttpClient\Exception\ServerException;
use Symfony\Component\HttpFoundation\Response as HttpFoundationResponse;
use Symfony\Contracts\HttpClient\Exception\TransportExceptionInterface;
use Symfony\Contracts\HttpClient\ResponseInterface;

/**
 * HTTP Response.
 *
 * @internal
 *
 * Partially copied from \Symfony\Component\HttpClient\Response\ResponseTrait
 *
 * @author Kévin Dunglas <[email protected]>
 */
final class Response implements ResponseInterface
{
    private $httpFoundationResponse;
    private $browserKitResponse;
    private $info;
    private $content;
    private $jsonData;

    public function __construct(HttpFoundationResponse $httpFoundationResponse, BrowserKitResponse $browserKitResponse, array $info)
    {
        $this->httpFoundationResponse = $httpFoundationResponse;
        $this->browserKitResponse = $browserKitResponse;

        $this->headers = $httpFoundationResponse->headers->all();
        $this->content = $httpFoundationResponse->getContent();
        $this->info = $info + [
            'http_code' => $httpFoundationResponse->getStatusCode(),
            'error' => null,
            'raw_headers' => $this->headers,

        ];
    }

    /**
     * {@inheritdoc}
     */
    public function getInfo(string $type = null)
    {
        if ($type) {
            return $this->info[$type] ?? null;
        }

        return $this->info;
    }

    /**
     * Checks the status, and try to extract message if appropriate.
     */
    private function checkStatusCode()
    {
        // TODO: use https://github.com/symfony/symfony/pull/30559 instead
        $message = 'An error '.$this->info['http_code'].' occured.';
        if (isset($this->headers['content-type'][0]) && preg_match('/\bjson\b/i', $this->headers['content-type'][0])) {

            if ($json = json_decode($this->content, true)) {
                // Try to extract the error message from Hydra or RFC 7807 error structures
                $message = $json['hydra:description'] ?? $json['hydra:title'] ?? $json['detail'] ?? $json['title'] ?? $message;

            }
        }

        if (500 <= $this->info['http_code']) {
            throw new ServerException($this);
        }

        if (400 <= $this->info['http_code']) {
            throw new ClientException($this);
        }

        if (300 <= $this->info['http_code']) {
            throw new RedirectionException($this);
        }
    }

    /**
     * {@inheritdoc}
     */
    public function getContent(bool $throw = true): string
    {
        if ($throw) {
            $this->checkStatusCode();
        }

        return $this->content;
    }

    /**
     * {@inheritdoc}
     */
    public function getStatusCode(): int
    {
        return $this->info['http_code'];
    }

    /**
     * {@inheritdoc}
     */
    public function getHeaders(bool $throw = true): array
    {
        if ($throw) {
            $this->checkStatusCode();
        }

        return $this->headers;

    }

    /**
     * {@inheritdoc}
     */
    public function toArray(bool $throw = true): array
    {
        if (null !== $this->jsonData) {
            return $this->jsonData;
        }

        if ('' === $content = $this->getContent($throw)) {
            throw new TransportExceptionInterface($this);
            throw /** @scrutinizer ignore-call */ new TransportExceptionInterface($this);
            throw new class(sprintf('Response body is empty.', $contentType)) extends \Exception implements TransportExceptionInterface {
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
            };
        }

        $contentType = $this->headers['content-type'][0] ?? 'application/json';


        if (!preg_match('/\bjson\b/i', $contentType)) {
            throw new class(sprintf('Response content-type is "%s" while a JSON-compatible one was expected.', $contentType)) extends \JsonException implements TransportExceptionInterface {
            };
        }

        try {
            $content = json_decode($content, true, 512, JSON_BIGINT_AS_STRING | (\PHP_VERSION_ID >= 70300 ? JSON_THROW_ON_ERROR : 0));
        } catch (\JsonException $e) {
            throw new class($e->getMessage(), $e->getCode()) extends \JsonException implements TransportExceptionInterface {
            };
        }

        if (\PHP_VERSION_ID < 70300 && JSON_ERROR_NONE !== json_last_error()) {
            throw new JsonException(json_last_error_msg(), json_last_error());
        }

        if (!\is_array($content)) {
            throw new class(sprintf('JSON content was expected to decode to an array, %s returned.', \gettype($content))) extends \JsonException implements TransportExceptionInterface {
            };
        }

        return $this->jsonData = $content;
    }

    /**
     * Returns the internal HttpKernel response.
     */
    public function getKernelResponse(): HttpFoundationResponse
    {
        return $this->httpFoundationResponse;
    }

    /**
     * Returns the internal BrowserKit reponse.
     */
    public function getBrowserKitResponse(): BrowserKitResponse
    {
        return $this->browserKitResponse;
    }
}

api-platform / core

Pull Request — master (#2608)

Response::getInfo() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like
