| Conditions | 4 |
| Total Lines | 75 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | package org.apereo.cas.pm.web.flow; |
||
| 93 | private void createPasswordResetFlow() { |
||
| 94 | final Flow flow = getLoginFlow(); |
||
| 95 | if (flow != null) { |
||
| 96 | final boolean autoLogin = casProperties.getAuthn().getPm().isAutoLogin(); |
||
| 97 | |||
| 98 | final ViewState state = getState(flow, CasWebflowConstants.STATE_ID_VIEW_LOGIN_FORM, ViewState.class); |
||
| 99 | createTransitionForState(state, CasWebflowConstants.TRANSITION_ID_RESET_PASSWORD, |
||
| 100 | CasWebflowConstants.VIEW_ID_SEND_RESET_PASSWORD_ACCT_INFO); |
||
| 101 | final ViewState accountInfo = createViewState(flow, CasWebflowConstants.VIEW_ID_SEND_RESET_PASSWORD_ACCT_INFO, |
||
| 102 | CasWebflowConstants.VIEW_ID_SEND_RESET_PASSWORD_ACCT_INFO); |
||
| 103 | createTransitionForState(accountInfo, "findAccount", SEND_PASSWORD_RESET_INSTRUCTIONS_ACTION); |
||
| 104 | final ActionState sendInst = createActionState(flow, SEND_PASSWORD_RESET_INSTRUCTIONS_ACTION, |
||
| 105 | createEvaluateAction("sendPasswordResetInstructionsAction")); |
||
| 106 | createTransitionForState(sendInst, CasWebflowConstants.TRANSITION_ID_SUCCESS, |
||
| 107 | CasWebflowConstants.VIEW_ID_SENT_RESET_PASSWORD_ACCT_INFO); |
||
| 108 | createTransitionForState(sendInst, CasWebflowConstants.TRANSITION_ID_ERROR, accountInfo.getId()); |
||
| 109 | createViewState(flow, CasWebflowConstants.VIEW_ID_SENT_RESET_PASSWORD_ACCT_INFO, |
||
| 110 | CasWebflowConstants.VIEW_ID_SENT_RESET_PASSWORD_ACCT_INFO); |
||
| 111 | |||
| 112 | final Flow pswdFlow = buildFlow("classpath:/webflow/pswdreset/pswdreset-webflow.xml", FLOW_ID_PASSWORD_RESET); |
||
| 113 | createViewState(pswdFlow, "passwordResetErrorView", CasWebflowConstants.VIEW_ID_PASSWORD_RESET_ERROR); |
||
| 114 | createViewState(pswdFlow, CasWebflowConstants.STATE_ID_PASSWORD_UPDATE_SUCCESS, |
||
| 115 | CasWebflowConstants.VIEW_ID_PASSWORD_UPDATE_SUCCESS); |
||
| 116 | configurePasswordResetFlow(pswdFlow, CasWebflowConstants.VIEW_ID_MUST_CHANGE_PASSWORD); |
||
| 117 | loginFlowDefinitionRegistry.registerFlowDefinition(pswdFlow); |
||
| 118 | |||
| 119 | final ActionState initializeLoginFormState = getState(flow, CasWebflowConstants.STATE_ID_INIT_LOGIN_FORM, ActionState.class); |
||
| 120 | final String originalTargetState = initializeLoginFormState.getTransition(CasWebflowConstants.STATE_ID_SUCCESS).getTargetStateId(); |
||
| 121 | final SubflowState pswdResetSubFlowState = createSubflowState(flow, CasWebflowConstants.STATE_ID_PASSWORD_RESET_SUBFLOW, FLOW_ID_PASSWORD_RESET); |
||
| 122 | |||
| 123 | getTransitionableState(flow, CasWebflowConstants.STATE_ID_REAL_SUBMIT).getEntryActionList() |
||
| 124 | .add(createEvaluateAction("flowScope." + DO_CHANGE_PASSWORD_PARAMETER |
||
| 125 | + " = requestParameters." + DO_CHANGE_PASSWORD_PARAMETER + " != null")); |
||
| 126 | |||
| 127 | createDecisionState(flow, CasWebflowConstants.CHECK_FOR_PASSWORD_RESET_TOKEN_ACTION, |
||
| 128 | "requestParameters." + SendPasswordResetInstructionsAction.PARAMETER_NAME_TOKEN + " != null", |
||
| 129 | CasWebflowConstants.STATE_ID_PASSWORD_RESET_SUBFLOW, |
||
| 130 | originalTargetState); |
||
| 131 | createTransitionForState(initializeLoginFormState, |
||
| 132 | CasWebflowConstants.STATE_ID_SUCCESS, |
||
| 133 | CasWebflowConstants.CHECK_FOR_PASSWORD_RESET_TOKEN_ACTION, true); |
||
| 134 | createEndState(pswdFlow, CasWebflowConstants.STATE_ID_PASSWORD_RESET_FLOW_COMPLETE); |
||
| 135 | createTransitionForState( |
||
| 136 | getTransitionableState(pswdFlow, CasWebflowConstants.STATE_ID_PASSWORD_UPDATE_SUCCESS), |
||
| 137 | CasWebflowConstants.TRANSITION_ID_PROCEED, |
||
| 138 | CasWebflowConstants.STATE_ID_PASSWORD_RESET_FLOW_COMPLETE); |
||
| 139 | createEndState(flow, CasWebflowConstants.STATE_ID_REDIRECT_TO_LOGIN, "'" + CasWebflowConfigurer.FLOW_ID_LOGIN + "'", true); |
||
| 140 | |||
| 141 | createTransitionForState( |
||
| 142 | pswdResetSubFlowState, |
||
| 143 | CasWebflowConstants.STATE_ID_PASSWORD_RESET_FLOW_COMPLETE, |
||
| 144 | autoLogin ? CasWebflowConstants.STATE_ID_REAL_SUBMIT : CasWebflowConstants.STATE_ID_REDIRECT_TO_LOGIN); |
||
| 145 | |||
| 146 | createDecisionState(flow, |
||
| 147 | CasWebflowConstants.STATE_ID_CHECK_DO_CHANGE_PASSWORD, |
||
| 148 | "flowScope." + DO_CHANGE_PASSWORD_PARAMETER + " == true", |
||
| 149 | CasWebflowConstants.VIEW_ID_MUST_CHANGE_PASSWORD, |
||
| 150 | getTransitionableState(flow, CasWebflowConstants.STATE_ID_REAL_SUBMIT) |
||
| 151 | .getTransition(CasWebflowConstants.TRANSITION_ID_SUCCESS).getTargetStateId()) |
||
| 152 | .getEntryActionList().add(createEvaluateAction("flowScope.pswdChangePostLogin=true")); |
||
| 153 | |||
| 154 | createTransitionForState(getTransitionableState(flow, CasWebflowConstants.STATE_ID_REAL_SUBMIT), |
||
| 155 | CasWebflowConstants.TRANSITION_ID_SUCCESS, CasWebflowConstants.STATE_ID_CHECK_DO_CHANGE_PASSWORD, true); |
||
| 156 | |||
| 157 | createDecisionState(flow, |
||
| 158 | CasWebflowConstants.STATE_ID_PSWD_CHANGE_CHECK_POST_LOGIN, |
||
| 159 | "flowScope.pswdChangePostLogin == true", |
||
| 160 | getTransitionableState(flow, CasWebflowConstants.VIEW_ID_SHOW_AUTHN_WARNING_MSGS) |
||
| 161 | .getTransition(CasWebflowConstants.TRANSITION_ID_PROCEED).getTargetStateId(), |
||
| 162 | autoLogin ? CasWebflowConstants.STATE_ID_REAL_SUBMIT : CasWebflowConstants.STATE_ID_REDIRECT_TO_LOGIN); |
||
| 163 | |||
| 164 | createTransitionForState( |
||
| 165 | getTransitionableState(flow, CasWebflowConstants.STATE_ID_PASSWORD_UPDATE_SUCCESS), |
||
| 166 | CasWebflowConstants.TRANSITION_ID_PROCEED, |
||
| 167 | CasWebflowConstants.STATE_ID_PSWD_CHANGE_CHECK_POST_LOGIN); |
||
| 168 | |||
| 192 |