AlphaGenerator - Code Metrics - Inspection of "Refactor to extract generators" - antonioribeiro/random - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ef82f9...6cec72 )

by Antonio Carlos

created 2017-11-21 05:21 UTC

AlphaGenerator A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	38
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Test Coverage

Coverage

100%

Importance

Changes

Metric	Value
wmc	5
lcom	1
cbo	0
dl	0
loc	38
ccs	9
cts	9
cp	1
rs	10
c	0
b	0
f	0

3 Methods

Rating	Name	Size	Complexity
A	generateAlpha()	4	1
A	getNumericGenerator()	6	1
A	generateNumeric()	8	3

<?php

namespace PragmaRX\Random\Generators;

trait AlphaGenerator
{
    /**
     * Generate a random string.
     *
     * @return int|string
     */
    protected function generateAlpha()
    {
        return $this->generateString($this->getAlphaGenerator());
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * Get the alpha generator.
     *
     * @return mixed
     */
    protected function getNumericGenerator()
    {
        return function () {
            return random_int(0, PHP_INT_MAX);
        };
    }

    /**
     * Generate a numeric random value.
     *
     * @return int|string
     */
    protected function generateNumeric()
    {
        if (is_null($this->size) && $this->pattern == static::DEFAULT_PATTERN) {
class MyClass { }

$x = new MyClass();
$x->foo = true;
            return $this->generateInteger();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        }

        return $this->generateString($this->getNumericGenerator());
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }
}


1		<?php
2
3		namespace PragmaRX\Random\Generators;
4
5		trait AlphaGenerator
6		{
7		/**
8		* Generate a random string.
9		*
10		* @return int\|string
11		*/
12	9	protected function generateAlpha()
13		{
14	9	return $this->generateString($this->getAlphaGenerator());
		0 ignored issues – show Bug introduced 2017-11-21 05:22 UTC by Report Bug Copy Issue Report It seems like `getAlphaGenerator()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history... Bug introduced 2017-11-21 05:22 UTC by Report Bug Copy Issue Report It seems like `generateString()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
15		}
16
17		/**
18		* Get the alpha generator.
19		*
20		* @return mixed
21		*/
22		protected function getNumericGenerator()
23		{
24	3	return function () {
25	3	return random_int(0, PHP_INT_MAX);
26	3	};
27		}
28
29		/**
30		* Generate a numeric random value.
31		*
32		* @return int\|string
33		*/
34	3	protected function generateNumeric()
35		{
36	3	if (is_null($this->size) && $this->pattern == static::DEFAULT_PATTERN) {
		0 ignored issues – show Bug introduced 2017-09-19 00:23 UTC by Report Bug Copy Issue Report The property `size` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history... Bug introduced 2017-09-19 00:23 UTC by Report Bug Copy Issue Report The property `pattern` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
37	1	return $this->generateInteger();
		0 ignored issues – show Bug introduced 2017-11-21 05:22 UTC by Report Bug Copy Issue Report It seems like `generateInteger()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
38		}
39
40	3	return $this->generateString($this->getNumericGenerator());
		0 ignored issues – show Bug introduced 2017-11-21 05:22 UTC by Report Bug Copy Issue Report It seems like `generateString()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
41		}
42		}
43

antonioribeiro / random

Push — master ( ef82f9...6cec72 )

AlphaGenerator A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

3 Methods

Duplication Side-by-Side

Filter issues like