PragmaRX\Random\Generators\StringGenerator

Complexity

Total Complexity

8

Size/Duplication

Total Lines	66
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Test Coverage

Coverage

100%

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	generateString()	0	10	2
A	getAlphaGenerator()	0	6	1
A	getSize()	0	4	2
A	size()	0	6	1
A	trimToExpectedSize()	0	4	2

<?php

namespace PragmaRX\Random\Generators;

trait StringGenerator
{
    /**
     * Generate a random string.
     *
     * @param \Closure $generator
     * @return mixed
     */
    protected function generateString($generator)
    {
        $string = '';

        while (strlen($string) < $size = $this->getSize()) {
            $string .= $this->extractPattern($generator($size));

It seems like extractPattern() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        }

        return $this->trimToExpectedSize($string, $size);
    }

    /**
     * Get the alpha generator.
     *
     * @return mixed
     */
    protected function getAlphaGenerator()
    {
        return function ($size) {
            return random_bytes($size);
        };
    }

    /**
     * Get the final string size.
     *
     * @return integer
     */
    public function getSize()
    {
        return $this->size ?: static::DEFAULT_STRING_SIZE;

The property size does not exist. Did you maybe forget to declare it?

    }

    /**
     * Set the return string size.
     *
     * @param $size
     * @return $this
     */
    public function size($size)
    {
        $this->size = $size;

        return $this;
    }

    /**
     * Trim string to expected size.
     *
     * @param $string
     * @param int|null $size
     * @return string
     */
    protected function trimToExpectedSize($string, $size = null)
    {
        return substr($string, 0, $size ?: $this->getSize());
    }
}