Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
10 | trait Macroable |
||
11 | { |
||
12 | /** |
||
13 | * The registered string macros. |
||
14 | * |
||
15 | * @var array |
||
16 | */ |
||
17 | protected static $macros = []; |
||
18 | |||
19 | /** |
||
20 | * Register a custom macro. |
||
21 | * |
||
22 | * @param string $name |
||
23 | * @param object|callable $macro |
||
24 | * |
||
25 | * @return void |
||
26 | */ |
||
27 | 9 | public static function macro($name, $macro) |
|
31 | |||
32 | /** |
||
33 | * Mix another object into the class. |
||
34 | * |
||
35 | * @param object $mixin |
||
36 | * @param bool $replace |
||
37 | * @return void |
||
38 | * |
||
39 | * @throws \ReflectionException |
||
40 | */ |
||
41 | 2 | public static function mixin($mixin, $replace = true) |
|
54 | |||
55 | /** |
||
56 | * Checks if macro is registered. |
||
57 | * |
||
58 | * @param string $name |
||
59 | * @return bool |
||
60 | */ |
||
61 | 9 | public static function hasMacro($name) |
|
65 | |||
66 | /** |
||
67 | * Dynamically handle calls to the class. |
||
68 | * |
||
69 | * @param string $method |
||
70 | * @param array $parameters |
||
71 | * @return mixed |
||
72 | * |
||
73 | * @throws \BadMethodCallException |
||
74 | */ |
||
75 | 2 | View Code Duplication | public static function __callStatic($method, $parameters) |
91 | |||
92 | /** |
||
93 | * Dynamically handle calls to the class. |
||
94 | * |
||
95 | * @param string $method |
||
96 | * @param array $parameters |
||
97 | * @return mixed |
||
98 | * |
||
99 | * @throws \BadMethodCallException |
||
100 | */ |
||
101 | 8 | View Code Duplication | public function __call($method, $parameters) |
117 | } |
||
118 |
It seems like the type of the argument is not accepted by the function/method which you are calling.
In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug.
We suggest to add an explicit type cast like in the following example: