antonioribeiro / health

src/Commands.php

Doc Comments +3 added lines, -3 removed lines

@@ -100,7 +100,7 @@ 
      * Format input to textual table.
      *
      * @param Command|null $command
-     * @param $columns
+     * @param string[] $columns
      * @param  \Illuminate\Contracts\Support\Arrayable|array $rows
      */
     private function table($command, $columns, $rows)
@@ -114,7 +114,7 @@ 
      * Write a string as information output.
      *
      * @param Command|null $command
-     * @param $string
+     * @param string $string
      */
     private function info($command, $string)
     {
@@ -127,7 +127,7 @@ 
      * Write a string as information output.
      *
      * @param Command|null $command
-     * @param $string
+     * @param string $string
      */
     private function error($command, $string)
     {

Spacing +4 added lines, -4 removed lines

@@ -58,7 +58,7 @@ 
         $columns = ['Resource', 'State', 'Message'];
 
         $rows = $this->getTargetsFomResources($this->healthService->health())
-            ->map(function ($target) {
+            ->map(function($target) {
                 return [
                     "{$target->resource->name} ({$target->display})",
                     $target->result->healthy
@@ -76,9 +76,9 @@ 
     {
         $checker = $this->healthService->getSilentChecker();
 
-        $errors = $this->getTargetsFomResources($checker()->filter(function ($resource) {
-            return ! $resource->isGlobal;
-        }))->reduce(function ($carry, $target) {
+        $errors = $this->getTargetsFomResources($checker()->filter(function($resource) {
+            return !$resource->isGlobal;
+        }))->reduce(function($carry, $target) {
             return $carry + ($target->result->healthy ? 0 : 1);
         }, 0);
 

src/Http/Controllers/Health.php

Doc Comments +2 added lines, -2 removed lines

@@ -39,7 +39,7 @@ 
     /**
      * Check and get one resource.
      *
-     * @param $slug
+     * @param string $slug
      * @return mixed
      * @throws \Exception
      */
@@ -53,7 +53,7 @@ 
     /**
      * Get all resources.
      *
-     * @return mixed
+     * @return \Illuminate\Support\Collection
      * @throws \Exception
      */
     public function allResources()

src/Service.php

Spacing +2 added lines, -2 removed lines

@@ -83,7 +83,7 @@ 
      */
     public function getSilentChecker()
     {
-        return function () {
+        return function() {
             return $this->checkResources();
         };
     }
@@ -132,7 +132,7 @@ 
      */
     public function string()
     {
-        return collect($this->health())->reduce(function ($current, $resource) {
+        return collect($this->health())->reduce(function($current, $resource) {
             return
                 $current.
                 ($current ? config('health.string.glue') : '').

src/Notifications/HealthStatus.php

Doc Comments +3 added lines, -3 removed lines

@@ -132,8 +132,8 @@ 
     /**
      * Get the action message.
      *
-     * @param $item
-     * @return \Illuminate\Config\Repository|mixed
+     * @param HealthStatus $item
+     * @return string
      */
     private function getActionMessage($item)
     {
@@ -145,7 +145,7 @@ 
     /**
      * Get the action title.
      *
-     * @return mixed
+     * @return string
      */
     protected function getActionTitle()
     {

Spacing +1 added lines, -1 removed lines

@@ -103,7 +103,7 @@
                 config('health.notifications.from.icon_emoji')
             )
             ->content($this->getMessage())
-            ->attachment(function ($attachment) {
+            ->attachment(function($attachment) {
                 $attachment
                     ->title($this->getActionTitle(), $this->getActionLink())
                     ->content($this->result->errorMessage);

src/Support/Resource.php

Doc Comments +6 added lines, -6 removed lines

@@ -87,7 +87,7 @@ 
      * Resource factory.
      *
      * @param Collection $data
-     * @return resource
+     * @return Resource
      * @throws \Exception
      */
     public static function factory(Collection $data)
@@ -176,7 +176,7 @@ 
      * Check all targets for a resource.
      *
      * @param string $action
-     * @return resource
+     * @return Resource
      */
     public function check($action = 'resource')
     {
@@ -195,7 +195,7 @@ 
      * Check global resources.
      *
      * @param $resources
-     * @return resource
+     * @return Resource
      */
     public function checkGlobal($resources)
     {
@@ -234,7 +234,7 @@ 
     /**
      * Send notifications.
      *
-     * @return static
+     * @return Collection
      */
     protected function sendNotifications()
     {
@@ -279,7 +279,7 @@ 
      * Set current action.
      *
      * @param string $currentAction
-     * @return resource
+     * @return Resource
      */
     public function setCurrentAction(string $currentAction)
     {
@@ -292,7 +292,7 @@ 
      * Resources setter.
      *
      * @param $resources
-     * @return resource
+     * @return Resource
      */
     protected function setResources($resources)
     {

Spacing +9 added lines, -9 removed lines

@@ -145,12 +145,12 @@ 
         $current = collect();
 
         $targets = $targets
-            ->map(function (Collection $targetList) {
-                return $targetList->map(function ($target, $name) {
+            ->map(function(Collection $targetList) {
+                return $targetList->map(function($target, $name) {
                     return Target::factory($this, $target, $name);
                 });
             })
-            ->reduce(function ($current, $targetList) {
+            ->reduce(function($current, $targetList) {
                 foreach ($targetList as $target) {
                     $current[] = $target;
                 }
@@ -180,7 +180,7 @@ 
      */
     public function check($action = 'resource')
     {
-        $this->setCurrentAction($action)->targets->each(function (
+        $this->setCurrentAction($action)->targets->each(function(
             Target $target
         ) {
             $target->check($target);
@@ -209,14 +209,14 @@ 
      */
     public function isHealthy()
     {
-        return $this->targets->reduce(function ($carry, $target) {
+        return $this->targets->reduce(function($carry, $target) {
             return $carry && $target->result->healthy;
         }, true);
     }
 
     protected function keysToCamel($array)
     {
-        return collect($array)->mapWithKeys(function ($item, $key) {
+        return collect($array)->mapWithKeys(function($item, $key) {
             return [camel_case($key) => $item];
         });
     }
@@ -238,7 +238,7 @@ 
      */
     protected function sendNotifications()
     {
-        return collect(config('health.notifications.channels'))->each(function (
+        return collect(config('health.notifications.channels'))->each(function(
             $channel
         ) {
             try {
@@ -257,9 +257,9 @@ 
     protected function canNotify()
     {
         return
-            ! $this->notified &&
+            !$this->notified &&
             $this->notificationsAreEnabled() &&
-            ! $this->isHealthy();
+            !$this->isHealthy();
     }
 
     /**

src/Support/ResourceChecker.php

Doc Comments +3 added lines, -3 removed lines

@@ -152,7 +152,7 @@ 
     /**
      * Get current action.
      *
-     * @return mixed
+     * @return string
      */
     public function getCurrentAction()
     {
@@ -298,7 +298,7 @@ 
      * Get one resource.
      *
      * @param resource|Collection $resource
-     * @return resource
+     * @return Resource
      * @throws Exception
      */
     public function makeResource($resource)
@@ -313,7 +313,7 @@ 
     /**
      * Sort resources.
      *
-     * @param $resources
+     * @param Collection $resources
      * @return \Illuminate\Support\Collection
      */
     protected function sortResources($resources)

Spacing +16 added lines, -16 removed lines

@@ -79,21 +79,21 @@ 
      */
     public function checkResources($force = false)
     {
-        if (! ($resources = $this->getCachedResources($force))->isEmpty()) {
+        if (!($resources = $this->getCachedResources($force))->isEmpty()) {
             return $resources;
         }
 
-        if (! $this->allResourcesAreGood()) {
+        if (!$this->allResourcesAreGood()) {
             return $this->resources = collect();
         }
 
         $resources = $this->sortResources(
             $this->getNonGlobalResources()
-                ->each(function ($resource) {
+                ->each(function($resource) {
                     $this->checkResource($resource);
                 })
                 ->merge(
-                    $this->getGlobalResources()->each(function ($resource) {
+                    $this->getGlobalResources()->each(function($resource) {
                         return $resource->checkGlobal($this->getResources());
                     })
                 )
@@ -118,7 +118,7 @@ 
                 ? $resource
                 : $this->getResourceBySlug($resource);
 
-        $checked = $this->cache->remember($resource->slug, function () use (
+        $checked = $this->cache->remember($resource->slug, function() use (
             $resource
         ) {
             return $resource->check($this->getCurrentAction());
@@ -167,9 +167,9 @@ 
      */
     protected function allResourcesAreGood()
     {
-        return ! $this->getResources()
-            ->reject(function ($resource) {
-                return ! $resource instanceof Resource;
+        return !$this->getResources()
+            ->reject(function($resource) {
+                return !$resource instanceof Resource;
             })
             ->isEmpty();
     }
@@ -182,8 +182,8 @@ 
      */
     protected function getNonGlobalResources()
     {
-        return $this->getResources()->filter(function (Resource $resource) {
-            return ! $resource->isGlobal;
+        return $this->getResources()->filter(function(Resource $resource) {
+            return !$resource->isGlobal;
         });
     }
 
@@ -195,7 +195,7 @@ 
      */
     protected function getGlobalResources()
     {
-        return $this->getResources()->filter(function (Resource $resource) {
+        return $this->getResources()->filter(function(Resource $resource) {
             return $resource->isGlobal;
         });
     }
@@ -227,7 +227,7 @@ 
             ? $exception->getMessage()
             : static::UNKNOWN_ERROR;
 
-        if (! isset($resourceChecker)) {
+        if (!isset($resourceChecker)) {
             return [
                 null,
                 [
@@ -283,8 +283,8 @@ 
     {
         if (is_null($this->resources) || $this->resources->isEmpty()) {
             $this->resources = $this->resourceLoader->loadResources()->map(
-                function ($resource) {
-                    return $this->handleExceptions(function () use ($resource) {
+                function($resource) {
+                    return $this->handleExceptions(function() use ($resource) {
                         return $this->makeResource($resource);
                     });
                 }
@@ -319,8 +319,8 @@ 
     protected function sortResources($resources)
     {
         if ($sortBy = config('health.sort_by')) {
-            return $resources->sortBy(function ($resource) use ($sortBy) {
-                return $this->handleExceptions(function () use (
+            return $resources->sortBy(function($resource) use ($sortBy) {
+                return $this->handleExceptions(function() use (
                     $resource,
                     $sortBy
                 ) {

src/Checkers/Horizon.php

Spacing +2 added lines, -2 removed lines

@@ -25,11 +25,11 @@
      */
     protected function horizonIsRunning()
     {
-        if (! $masters = app(MasterSupervisorRepository::class)->all()) {
+        if (!$masters = app(MasterSupervisorRepository::class)->all()) {
             return false;
         }
 
-        return collect($masters)->contains(function ($master) {
+        return collect($masters)->contains(function($master) {
             return $master->status === 'paused';
         })
             ? false

tests/PhpUnit/Service/ServiceTest.php

Spacing +6 added lines, -6 removed lines

@@ -143,7 +143,7 @@ 
 
     private function getResources($force = false)
     {
-        if ($force || ! $this->resources) {
+        if ($force || !$this->resources) {
             $this->resources = $this->service->checkResources($force);
         }
 
@@ -221,7 +221,7 @@ 
 
     public function assertCheckedResources($resources)
     {
-        $healthCount = $resources->reduce(function ($carry, $resource) {
+        $healthCount = $resources->reduce(function($carry, $resource) {
             return $carry + ($resource->isHealthy() ? 1 : 0);
         }, 0);
 
@@ -230,7 +230,7 @@ 
             $healthCount
         );
 
-        $failing = $resources->filter(function ($resource) {
+        $failing = $resources->filter(function($resource) {
             return $resource->isHealthy();
         });
 
@@ -257,7 +257,7 @@ 
     {
         $this->assertEquals(
             collect(static::ALL_RESOURCES)
-                ->map(function ($value) {
+                ->map(function($value) {
                     return strtolower($value);
                 })
                 ->sort()
@@ -265,7 +265,7 @@ 
                 ->toArray(),
             $this->getResources()
                 ->keys()
-                ->map(function ($value) {
+                ->map(function($value) {
                     return strtolower($value);
                 })
                 ->sort()
@@ -282,7 +282,7 @@ 
             (new Commands($this->service))->$command();
         }
 
-        $this->assertFalse(! true);
+        $this->assertFalse(!true);
     }
 
     public function testController()

src/Checkers/Queue.php

Unused Use Statements -1 removed lines

@@ -2,7 +2,6 @@
 
 namespace PragmaRX\Health\Checkers;
 
-use Illuminate\Queue\Worker;
 use Illuminate\Queue\WorkerOptions;
 use PragmaRX\Health\Support\Result;