Certificate::getResourceUrlArray() - Code Metrics - Inspection of "Merge pull request #233 from qschmick/fix/remove-a..." - antonioribeiro/health - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( 3ef329...d55ae3 )

by Antonio Carlos

created 2020-10-27 18:55 UTC

Certificate::getResourceUrlArray() A

↳ Parent: Certificate

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
nc	2
nop	0
dl	0
loc	8
rs	10
c	0
b	0
f	0

<?php

namespace PragmaRX\Health\Checkers;

use Illuminate\Support\Collection;
use Illuminate\Support\Str;
use PragmaRX\Health\Support\Result;
use Spatie\SslCertificate\SslCertificate;

class Certificate extends Base
{
    /**
     * HTTP Checker.
     *
     * @return Result
     */
    public function check()
    {
        $resources = $this->getResourceUrlArray();

        $first = collect($resources)->first();

        if (filled($first)) {
            $this->target->setDisplay("{$first}");
        }

        try {
            foreach ($resources as $url) {
                [$healthy, $message] = $this->checkCertificate($url);


                if (! $healthy) {
                    return $this->makeResult(false, $message);
                }
            }

            return $this->makeHealthyResult();
        } catch (\Exception $exception) {
            report($exception);

            return $this->makeResultFromException($exception);
        }
    }

    /**
     * HTTP Checker.
     *
     * @return Result
     */
    public function checkCertificate($url)
    {
        return $this->checkHostCertificate($this->getHost($url));
    }

    /**
     * Get the error message.
     *
     * @return string
     */
    protected function getErrorMessage($host)
    {
        return sprintf($this->target->resource->errorMessage, $host);
    }

    /**
     * Get the error message.
     *
     * @return string
     */
    protected function getHost($url)
    {
        $parsed = parse_url($url);

        if (isset($parsed['host'])) {
            return $parsed['host'];
        }

        return $url;
    }

    /**
     *  Get array of resource urls.
     *
     * @return array
     */
    private function getResourceUrlArray()
    {
        if (is_a($this->target->urls, Collection::class)) {
            return $this->target->urls->toArray();
        }

        return (array) $this->target->urls;
    }

    public function checkHostCertificate($host)
    {
        $result = collect([
            'openssl' => $this->checkCertificateWithOpenSSL($host),

            'package' => [
                SslCertificate::createForHostName($host)->isValid(),
                'Invalid certificate',
            ],

            'php' => $this->checkCertificateWithPhp($host),
        ])
            ->filter(function ($result) {
                return $result[0] === false;
            })
            ->first();

        if ($result === null) {
            return [true, ''];
        }

        return $result;
    }

    public function checkCertificateWithOpenSSL($host)
    {
        exec($this->makeCommand($host), $output);

        $result = collect($output)
            ->filter(
                function ($line) {
                    return Str::contains(
                        $line,
                        $this->target->resource->verifyString
                    );
                }
            )
            ->first();

        if (blank($result)) {
            $output = blank($output) ? 'Unkown openssl error' : $output;

            return [false, json_encode($output)];
        }

        return [
            trim($result) == $this->target->resource->successString,
            $result,
        ];
    }

    public function checkCertificateWithPhp($host)
    {
        try {
            $get = stream_context_create([
                'ssl' => ['capture_peer_cert' => true],
            ]);

            $read = stream_socket_client(
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
                'ssl://'.$host.':443',
                $errno,
                $errstr,
                30,
                STREAM_CLIENT_CONNECT,
                $get
            );
        } catch (\Exception $exception) {
            return [false, $exception->getMessage()];
        }

        return [true, ''];
    }

    /**
     * @param $host
     * @return string|string[]
     */
    protected function makeCommand($host)
    {
        $command = $this->target->resource->command;

        $command = str_replace('{$options}', $this->target->options, $command);

        $command = str_replace('{$host}', $host, $command);

        return $command;
    }
}


1			<?php
2
3			namespace PragmaRX\Health\Checkers;
4
5			use Illuminate\Support\Collection;
6			use Illuminate\Support\Str;
7			use PragmaRX\Health\Support\Result;
8			use Spatie\SslCertificate\SslCertificate;
9
10			class Certificate extends Base
11			{
12			/**
13			* HTTP Checker.
14			*
15			* @return Result
16			*/
17			public function check()
18			{
19			$resources = $this->getResourceUrlArray();
20
21			$first = collect($resources)->first();
22
23			if (filled($first)) {
24			$this->target->setDisplay("{$first}");
25			}
26
27			try {
28			foreach ($resources as $url) {
29			[$healthy, $message] = $this->checkCertificate($url);
			0 ignored issues – show Bug introduced 2020-10-10 10:22 UTC by Report Bug Copy Issue Report The variable `$healthy` does not exist. Did you forget to declare it? This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug. Loading history... Bug introduced 2020-10-10 10:22 UTC by Report Bug Copy Issue Report The variable `$message` does not exist. Did you forget to declare it? This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug. Loading history...
30
31			if (! $healthy) {
32			return $this->makeResult(false, $message);
33			}
34			}
35
36			return $this->makeHealthyResult();
37			} catch (\Exception $exception) {
38			report($exception);
39
40			return $this->makeResultFromException($exception);
41			}
42			}
43
44			/**
45			* HTTP Checker.
46			*
47			* @return Result
48			*/
49			public function checkCertificate($url)
50			{
51			return $this->checkHostCertificate($this->getHost($url));
52			}
53
54			/**
55			* Get the error message.
56			*
57			* @return string
58			*/
59			protected function getErrorMessage($host)
60			{
61			return sprintf($this->target->resource->errorMessage, $host);
62			}
63
64			/**
65			* Get the error message.
66			*
67			* @return string
68			*/
69			protected function getHost($url)
70			{
71			$parsed = parse_url($url);
72
73			if (isset($parsed['host'])) {
74			return $parsed['host'];
75			}
76
77			return $url;
78			}
79
80			/**
81			* Get array of resource urls.
82			*
83			* @return array
84			*/
85			private function getResourceUrlArray()
86			{
87			if (is_a($this->target->urls, Collection::class)) {
88			return $this->target->urls->toArray();
89			}
90
91			return (array) $this->target->urls;
92			}
93
94			public function checkHostCertificate($host)
95			{
96			$result = collect([
97			'openssl' => $this->checkCertificateWithOpenSSL($host),
98
99			'package' => [
100			SslCertificate::createForHostName($host)->isValid(),
101			'Invalid certificate',
102			],
103
104			'php' => $this->checkCertificateWithPhp($host),
105			])
106			->filter(function ($result) {
107			return $result[0] === false;
108			})
109			->first();
110
111			if ($result === null) {
112			return [true, ''];
113			}
114
115			return $result;
116			}
117
118			public function checkCertificateWithOpenSSL($host)
119			{
120			exec($this->makeCommand($host), $output);
121
122			$result = collect($output)
123			->filter(
124			function ($line) {
125			return Str::contains(
126			$line,
127			$this->target->resource->verifyString
128			);
129			}
130			)
131			->first();
132
133			if (blank($result)) {
134			$output = blank($output) ? 'Unkown openssl error' : $output;
135
136			return [false, json_encode($output)];
137			}
138
139			return [
140			trim($result) == $this->target->resource->successString,
141			$result,
142			];
143			}
144
145			public function checkCertificateWithPhp($host)
146			{
147			try {
148			$get = stream_context_create([
149			'ssl' => ['capture_peer_cert' => true],
150			]);
151
152			$read = stream_socket_client(
			0 ignored issues – show Unused Code introduced 2020-10-27 18:43 UTC by Report Bug Copy Issue Report `$read` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
153			'ssl://'.$host.':443',
154			$errno,
155			$errstr,
156			30,
157			STREAM_CLIENT_CONNECT,
158			$get
159			);
160			} catch (\Exception $exception) {
161			return [false, $exception->getMessage()];
162			}
163
164			return [true, ''];
165			}
166
167			/**
168			* @param $host
169			* @return string\|string[]
170			*/
171			protected function makeCommand($host)
172			{
173			$command = $this->target->resource->command;
174
175			$command = str_replace('{$options}', $this->target->options, $command);
176
177			$command = str_replace('{$host}', $host, $command);
178
179			return $command;
180			}
181			}
182

antonioribeiro / health

Push — master ( 3ef329...d55ae3 )

Certificate::getResourceUrlArray() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like