Issues in HealthStatus.php - New Issues - Inspection of "Merge branch 'master' of https://github.com/antoni..." - antonioribeiro/health - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( 13dcda...44dfad )

by Antonio Carlos

created 2018-09-18 02:55 UTC

src/Notifications/HealthStatus.php (2 issues)

Labels

Severity

Informational 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace PragmaRX\Health\Notifications;

use Request;
use Illuminate\Bus\Queueable;
use Illuminate\Notifications\Notification;
use Illuminate\Notifications\Messages\MailMessage;
use Illuminate\Notifications\Messages\SlackMessage;

class HealthStatus extends Notification
{
    use Queueable;

    /**
     * @var
     */
    private $item;
    /**
     * @var
     */
    private $channel;

    /**
     * Create a new notification instance.
     *
     * @param $item
     */
    public function __construct($item, $channel)
    {
        $this->item = $item;

        $this->channel = $channel;
    }

    /**
     * Get sender instance.
     *
     * @param $name
     * @return \Illuminate\Foundation\Application|mixed
     */
    private function getSenderInstance($name)
    {
        $name = substr($name, 2);

        return instantiate(
            config(
                'health.notifications.channels.' . strtolower($name) . '.sender'
            )
        );
    }

    /**
     * Get the notification's delivery channels.
     *
     * @return array
     */
    public function via()
    {
        return [$this->channel];
    }

    /**
     * Magic getter.
     *
     * @param $name
     * @return null
     */
    public function __get($name)
    {
        if (isset($this->item->$name)) {
            return $this->item->$name;
        }

        return null;
    }

    /**
     * @param $name
     * @param $parameters
     * @return mixed
     */
    public function __call($name, $parameters)
    {
        $parameters[] = $this->item;

        return call_user_func_array(
            [$this->getSenderInstance($name), 'send'],
            $parameters
        );
    }

    /**
     * Create Slack message.
     *
     * @param $notifiable
     * @return SlackMessage
     */
    public function toSlack($notifiable)
    {
        return (new SlackMessage())
            ->error()
            ->from(
                config('health.notifications.from.name'),
                config('health.notifications.from.icon_emoji')
            )
            ->content($this->getMessage())
            ->attachment(function ($attachment) {
                $attachment
                    ->title($this->getActionTitle(), $this->getActionLink())
                    ->content($this->result->errorMessage);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            });
    }

    /**
     * Create Mail message.
     *
     * @param $notifiable
     * @return MailMessage
     */
    public function toMail($notifiable)
    {
        return (new MailMessage())
            ->line($this->getMessage($notifiable))
            ->from(
                config('health.notifications.from.address'),
                config('health.notifications.from.name')
            )
            ->action($this->getActionTitle(), $this->getActionLink());
    }

    /**
     * Get the action message.
     *
     * @param $item
     * @return \Illuminate\Config\Repository|mixed
     */
    private function getActionMessage($item)
    {
        return isset($item->errorMessage)
            ? $item->errorMessage
            : config('health.notifications.action_message');
    }

    /**
     * Get the action title.
     *
     * @return mixed
     */
    protected function getActionTitle()
    {
        return config('health.notifications.action-title');
    }

    /**
     * Get failing message.
     *
     * @return string
     */
    protected function getMessage()
    {
        $domain = Request::server('SERVER_NAME');

        return sprintf(
            $this->getActionMessage($this),
            studly_case($this->resource->name),
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $domain ? " in {$domain}." : '.'
        );
    }

    /**
     * Get the action link.
     *
     * @return string
     */
    protected function getActionLink()
    {
        return route(config('health.routes.notification'));
    }
}


1		<?php
2
3		namespace PragmaRX\Health\Notifications;
4
5		use Request;
6		use Illuminate\Bus\Queueable;
7		use Illuminate\Notifications\Notification;
8		use Illuminate\Notifications\Messages\MailMessage;
9		use Illuminate\Notifications\Messages\SlackMessage;
10
11		class HealthStatus extends Notification
12		{
13		use Queueable;
14
15		/**
16		* @var
17		*/
18		private $item;
19		/**
20		* @var
21		*/
22		private $channel;
23
24		/**
25		* Create a new notification instance.
26		*
27		* @param $item
28		*/
29	1	public function __construct($item, $channel)
30		{
31	1	$this->item = $item;
32
33	1	$this->channel = $channel;
34	1	}
35
36		/**
37		* Get sender instance.
38		*
39		* @param $name
40		* @return \Illuminate\Foundation\Application\|mixed
41		*/
42		private function getSenderInstance($name)
43		{
44		$name = substr($name, 2);
45
46		return instantiate(
47		config(
48		'health.notifications.channels.' . strtolower($name) . '.sender'
49		)
50		);
51		}
52
53		/**
54		* Get the notification's delivery channels.
55		*
56		* @return array
57		*/
58	1	public function via()
59		{
60	1	return [$this->channel];
61		}
62
63		/**
64		* Magic getter.
65		*
66		* @param $name
67		* @return null
68		*/
69	1	public function __get($name)
70		{
71	1	if (isset($this->item->$name)) {
72	1	return $this->item->$name;
73		}
74
75		return null;
76		}
77
78		/**
79		* @param $name
80		* @param $parameters
81		* @return mixed
82		*/
83		public function __call($name, $parameters)
84		{
85		$parameters[] = $this->item;
86
87		return call_user_func_array(
88		[$this->getSenderInstance($name), 'send'],
89		$parameters
90		);
91		}
92
93		/**
94		* Create Slack message.
95		*
96		* @param $notifiable
97		* @return SlackMessage
98		*/
99		public function toSlack($notifiable)
100		{
101		return (new SlackMessage())
102		->error()
103		->from(
104		config('health.notifications.from.name'),
105		config('health.notifications.from.icon_emoji')
106		)
107		->content($this->getMessage())
108		->attachment(function ($attachment) {
109		$attachment
110		->title($this->getActionTitle(), $this->getActionLink())
111		->content($this->result->errorMessage);
		0 ignored issues – show Documentation introduced 2018-09-18 03:00 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `result` does not exist on `object<PragmaRX\Health\N...fications\HealthStatus>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
112		});
113		}
114
115		/**
116		* Create Mail message.
117		*
118		* @param $notifiable
119		* @return MailMessage
120		*/
121	1	public function toMail($notifiable)
122		{
123	1	return (new MailMessage())
124	1	->line($this->getMessage($notifiable))
125	1	->from(
126	1	config('health.notifications.from.address'),
127	1	config('health.notifications.from.name')
128		)
129	1	->action($this->getActionTitle(), $this->getActionLink());
130		}
131
132		/**
133		* Get the action message.
134		*
135		* @param $item
136		* @return \Illuminate\Config\Repository\|mixed
137		*/
138	1	private function getActionMessage($item)
139		{
140	1	return isset($item->errorMessage)
141		? $item->errorMessage
142	1	: config('health.notifications.action_message');
143		}
144
145		/**
146		* Get the action title.
147		*
148		* @return mixed
149		*/
150	1	protected function getActionTitle()
151		{
152	1	return config('health.notifications.action-title');
153		}
154
155		/**
156		* Get failing message.
157		*
158		* @return string
159		*/
160	1	protected function getMessage()
161		{
162	1	$domain = Request::server('SERVER_NAME');
163
164	1	return sprintf(
165	1	$this->getActionMessage($this),
166	1	studly_case($this->resource->name),
		0 ignored issues – show Documentation introduced 2018-09-18 03:00 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `resource` does not exist on `object<PragmaRX\Health\N...fications\HealthStatus>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
167	1	$domain ? " in {$domain}." : '.'
168		);
169		}
170
171		/**
172		* Get the action link.
173		*
174		* @return string
175		*/
176	1	protected function getActionLink()
177		{
178	1	return route(config('health.routes.notification'));
179		}
180		}
181

antonioribeiro / health

Push — master ( 13dcda...44dfad )

src/Notifications/HealthStatus.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like