Issues in Health.php - Fixed Issues - Inspection of "Fix tests" - antonioribeiro/health - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( 892598...558941 )

by Antonio Carlos

created 2018-09-12 21:57 UTC

src/Http/Controllers/Health.php (1 issue)

Labels

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace PragmaRX\Health\Http\Controllers;

use PragmaRX\Health\Service;
use Illuminate\Routing\Controller;
use Illuminate\Support\Facades\File;

class Health extends Controller
{
    /**
     * @var Service
     */
    private $healthService;

    /**
     * Health constructor.
     *
     * @param Service $healthService
     */
    public function __construct(Service $healthService)
    {
        $this->healthService = $healthService;
    }

    /**
     * Check all resources.
     *
     * @return array
     * @throws \Exception
     */
    public function check()
    {
        $this->healthService->setAction('check');

        return response($this->healthService->health());
    }

    /**
     * Check and get one resource.
     *
     * @param $slug
     * @return mixed
     * @throws \Exception
     */
    public function getResource($slug)
    {
        $this->healthService->setAction('resource');

        return $this->healthService->resource($slug);
    }

    /**
     * Get all resources.
     *
     * @return mixed
     * @throws \Exception
     */
    public function allResources()
    {
        return $this->healthService->getResources();
    }

    /**
     * @return mixed
     * @throws \Exception
     */
    public function string()
    {
        $this->healthService->setAction('string');

        return response(
            $this->healthService->string(),
            $this->getReponseCode()
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        );
    }

    /**
     * @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View
     * @throws \Exception
     */
    public function panel()
    {
        $this->healthService->setAction('panel');

        return response((string) view(config('health.views.panel')));
    }

    public function assetAppJs()
    {
        $file = File::get(config('health.assets.js'));

        $response = response()->make($file);

        $response->header('Content-Type', 'text/css');

        return $response;
    }

    public function assetAppCss()
    {
        $file = File::get(config('health.assets.css'));

        $response = response()->make($file);

        $response->header('Content-Type', 'text/css');

        return $response;
    }

    public function config()
    {
        return config('health');
    }
}


1		<?php
2
3		namespace PragmaRX\Health\Http\Controllers;
4
5		use PragmaRX\Health\Service;
6		use Illuminate\Routing\Controller;
7		use Illuminate\Support\Facades\File;
8
9		class Health extends Controller
10		{
11		/**
12		* @var Service
13		*/
14		private $healthService;
15
16		/**
17		* Health constructor.
18		*
19		* @param Service $healthService
20		*/
21		public function __construct(Service $healthService)
22		{
23		$this->healthService = $healthService;
24		}
25
26		/**
27		* Check all resources.
28		*
29		* @return array
30		* @throws \Exception
31		*/
32		public function check()
33		{
34		$this->healthService->setAction('check');
35
36		return response($this->healthService->health());
37		}
38
39		/**
40		* Check and get one resource.
41		*
42		* @param $slug
43		* @return mixed
44		* @throws \Exception
45		*/
46		public function getResource($slug)
47		{
48		$this->healthService->setAction('resource');
49
50		return $this->healthService->resource($slug);
51		}
52
53		/**
54		* Get all resources.
55		*
56		* @return mixed
57		* @throws \Exception
58		*/
59		public function allResources()
60		{
61		return $this->healthService->getResources();
62		}
63
64		/**
65		* @return mixed
66		* @throws \Exception
67		*/
68		public function string()
69		{
70		$this->healthService->setAction('string');
71
72		return response(
73		$this->healthService->string(),
74		$this->getReponseCode()
		0 ignored issues – show Documentation Bug introduced 2018-09-11 17:00 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `getReponseCode` does not exist on `object<PragmaRX\Health\Http\Controllers\Health>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
75		);
76		}
77
78		/**
79		* @return \Illuminate\Contracts\View\Factory\|\Illuminate\View\View
80		* @throws \Exception
81		*/
82		public function panel()
83		{
84		$this->healthService->setAction('panel');
85
86		return response((string) view(config('health.views.panel')));
87		}
88
89	View Code Duplication	public function assetAppJs()
90		{
91		$file = File::get(config('health.assets.js'));
92
93		$response = response()->make($file);
94
95		$response->header('Content-Type', 'text/css');
96
97		return $response;
98		}
99
100	View Code Duplication	public function assetAppCss()
101		{
102		$file = File::get(config('health.assets.css'));
103
104		$response = response()->make($file);
105
106		$response->header('Content-Type', 'text/css');
107
108		return $response;
109		}
110
111		public function config()
112		{
113		return config('health');
114		}
115		}
116

antonioribeiro / health

Push — master ( 892598...558941 )

src/Http/Controllers/Health.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like