Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
9 | class Health extends Controller |
||
10 | { |
||
11 | /** |
||
12 | * @var Service |
||
13 | */ |
||
14 | private $healthService; |
||
15 | |||
16 | /** |
||
17 | * Health constructor. |
||
18 | * |
||
19 | * @param Service $healthService |
||
20 | */ |
||
21 | 1 | public function __construct(Service $healthService) |
|
22 | { |
||
23 | 1 | $this->healthService = $healthService; |
|
24 | 1 | } |
|
25 | |||
26 | /** |
||
27 | * Check all resources. |
||
28 | * |
||
29 | * @return array |
||
30 | * @throws \Exception |
||
31 | */ |
||
32 | 1 | public function check() |
|
38 | |||
39 | /** |
||
40 | * Check and get one resource. |
||
41 | * |
||
42 | * @param $slug |
||
43 | * @return mixed |
||
44 | * @throws \Exception |
||
45 | */ |
||
46 | public function getResource($slug) |
||
52 | |||
53 | /** |
||
54 | * Get all resources. |
||
55 | * |
||
56 | * @return mixed |
||
57 | * @throws \Exception |
||
58 | */ |
||
59 | public function allResources() |
||
63 | |||
64 | /** |
||
65 | * @return mixed |
||
66 | * @throws \Exception |
||
67 | */ |
||
68 | 1 | public function string() |
|
76 | |||
77 | /** |
||
78 | * @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View |
||
79 | * @throws \Exception |
||
80 | */ |
||
81 | 1 | public function panel() |
|
87 | |||
88 | View Code Duplication | public function assetAppJs() |
|
98 | |||
99 | View Code Duplication | public function assetAppCss() |
|
109 | |||
110 | public function config() |
||
114 | } |
||
115 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.