Issues in Database.php - All Issues - Inspection of "Merge branch 'master' of https://github.com/antoni..." - antonioribeiro/health - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( 6cb9f0...7deac3 )

by Antonio Carlos

created 2018-09-12 19:45 UTC

src/Support/Traits/Database.php (3 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace PragmaRX\Health\Support\Traits;

use PragmaRX\Health\Data\Models\HealthCheck;

trait Database
{
    protected $database;

    public function loadDatabase()
    {
        $this->database = $this->__load();
    }

    /**
     * Load cache.
     *
     * @return \Illuminate\Support\Collection
     */
    public function __load()

    {
        if (!file_exists($file = $this->getDatabaseFileName())) {
            return collect();
        }

        return collect(json_decode(file_get_contents($file), true));
    }

    /**
     * Get cache filename.
     *
     * @return string|null
     */
    protected function getDatabaseFileName()
    {
        return $this->target->saveTo;
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     * Check if database is enabled.
     *
     * @return bool
     */
    protected function databaseEnabled()
    {
        return config('health.database.enabled');
    }

    protected function saveResultsToDatabase($target, $result)
    {
        HealthCheck::create([

            'resource_name' => $resource = $target->resource->name,
            'resource_slug' => $target->resource->slug,
            'target_name' => $target->name,
            'target_slug' => str_slug($target->name),
            'target_display' => $target->display,
            'healthy' => $result->healthy,
            'error_message' => $result->errorMessage,
            'runtime' => $result->elapsedTime,
            'value' => $result->value,
            'value_human' => $result->valueHuman,
        ]);

        return
            HealthCheck::where([
                'resource_slug' => $target->resource->slug,
                'target_name' => $target->name,
            ])
                ->orderBy('created_at', 'desc')
                ->take(config('health.database.max_records'))
                ->get();
    }
}


1		<?php
2
3		namespace PragmaRX\Health\Support\Traits;
4
5		use PragmaRX\Health\Data\Models\HealthCheck;
6
7		trait Database
8		{
9		protected $database;
10
11		public function loadDatabase()
12		{
13		$this->database = $this->__load();
14		}
15
16		/**
17		* Load cache.
18		*
19		* @return \Illuminate\Support\Collection
20		*/
21	View Code Duplication	public function __load()
		0 ignored issues – show Duplication introduced 2018-09-09 22:51 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
22		{
23		if (!file_exists($file = $this->getDatabaseFileName())) {
24		return collect();
25		}
26
27		return collect(json_decode(file_get_contents($file), true));
28		}
29
30		/**
31		* Get cache filename.
32		*
33		* @return string\|null
34		*/
35		protected function getDatabaseFileName()
36		{
37		return $this->target->saveTo;
		0 ignored issues – show Bug introduced 2018-09-09 22:51 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `target` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
38		}
39
40		/**
41		* Check if database is enabled.
42		*
43		* @return bool
44		*/
45		protected function databaseEnabled()
46		{
47		return config('health.database.enabled');
48		}
49
50		protected function saveResultsToDatabase($target, $result)
51		{
52		HealthCheck::create([
		0 ignored issues – show Bug introduced 2018-09-11 03:12 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `create()` does not exist on `PragmaRX\Health\Data\Models\HealthCheck`. Did you maybe mean `created()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
53		'resource_name' => $resource = $target->resource->name,
54		'resource_slug' => $target->resource->slug,
55		'target_name' => $target->name,
56		'target_slug' => str_slug($target->name),
57		'target_display' => $target->display,
58		'healthy' => $result->healthy,
59		'error_message' => $result->errorMessage,
60		'runtime' => $result->elapsedTime,
61		'value' => $result->value,
62		'value_human' => $result->valueHuman,
63		]);
64
65		return
66		HealthCheck::where([
67		'resource_slug' => $target->resource->slug,
68		'target_name' => $target->name,
69		])
70		->orderBy('created_at', 'desc')
71		->take(config('health.database.max_records'))
72		->get();
73		}
74		}
75

antonioribeiro / health

Push — master ( 6cb9f0...7deac3 )

src/Support/Traits/Database.php (3 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like