antonioribeiro / health

src/Commands.php

Spacing +6 added lines, -6 removed lines

@@ -40,7 +40,7 @@ 
     {
         $columns = ['Resource', 'State', 'Message'];
 
-        $rows = $this->healthService->health()->map(function ($resource) {
+        $rows = $this->healthService->health()->map(function($resource) {
             return [
                 $resource['name'],
                 $resource['health']['healthy']
@@ -57,7 +57,7 @@ 
     {
         $checker = $this->healthService->getSilentChecker();
 
-        $errors = $checker()->where('is_global', false)->reduce(function ($carry, $item) {
+        $errors = $checker()->where('is_global', false)->reduce(function($carry, $item) {
             return $carry + ($item['health']['healthy'] ? 0 : 1);
         }, 0);
 
@@ -77,14 +77,14 @@ 
     {
         $yaml = new Yaml();
 
-        collect(config('health.resources'))->each(function ($resource, $key) use ($command, $yaml) {
+        collect(config('health.resources'))->each(function($resource, $key) use ($command, $yaml) {
             $path = config('health.resources_location.path');
 
             $resource['column_size'] = (int) $resource['columnSize'];
 
             unset($resource['columnSize']);
 
-            if (! file_exists($path)) {
+            if (!file_exists($path)) {
                 mkdir($path, 0660, true);
             }
 
@@ -100,8 +100,8 @@ 
     {
         $yaml = new Yaml();
 
-        $yaml->loadYamlFromDir(package_resources_dir(), false)->each(function ($value, $key) use ($command) {
-            if (! file_exists($path = config('health.resources_location.path'))) {
+        $yaml->loadYamlFromDir(package_resources_dir(), false)->each(function($value, $key) use ($command) {
+            if (!file_exists($path = config('health.resources_location.path'))) {
                 mkdir($path, 0660, true);
             }
 

Doc Comments +4 added lines, -4 removed lines

@@ -120,7 +120,7 @@ 
      * Format input to textual table.
      *
      * @param Command|null $command
-     * @param $columns
+     * @param string[] $columns
      * @param  \Illuminate\Contracts\Support\Arrayable|array $rows
      */
     private function table($command, $columns, $rows)
@@ -134,7 +134,7 @@ 
      * Write a string as information output.
      *
      * @param Command|null $command
-     * @param $string
+     * @param string $string
      */
     private function info($command, $string)
     {
@@ -147,7 +147,7 @@ 
      * Write a string as information output.
      *
      * @param Command|null $command
-     * @param $string
+     * @param string $string
      */
     private function error($command, $string)
     {
@@ -160,7 +160,7 @@ 
      * Write a string as information output.
      *
      * @param Command|null $command
-     * @param $string
+     * @param string $string
      */
     private function warn($command, $string)
     {

src/Support/Yaml.php

Doc Comments +5 added lines, -5 removed lines

@@ -11,7 +11,7 @@ 
      *
      * @param $directory
      * @param bool $parseYaml
-     * @return static
+     * @return \Illuminate\Support\Collection
      */
     public function loadYamlFromDir($directory, $parseYaml = true)
     {
@@ -25,7 +25,7 @@ 
     /**
      * Parse a yaml file.
      *
-     * @param $contents
+     * @param string $contents
      * @return mixed
      */
     private function parseFile($contents)
@@ -37,7 +37,7 @@ 
      * Replace contents.
      *
      * @param $contents
-     * @return mixed
+     * @return string
      */
     private function replaceContents($contents)
     {
@@ -55,7 +55,7 @@ 
     /**
      * Resolve variable.
      *
-     * @param $key
+     * @param string $key
      * @return string
      */
     private function resolveVariable($key)
@@ -72,7 +72,7 @@ 
     /**
      * Execute function.
      *
-     * @param $string
+     * @param string $string
      * @return mixed
      */
     private function executeFunction($string)

Spacing +4 added lines, -4 removed lines

@@ -15,13 +15,13 @@
      */
     public function loadYamlFromDir($directory, $parseYaml = true)
     {
-        if (! file_exists($directory)) {
+        if (!file_exists($directory)) {
             return collect([]);
         }
 
-        return collect(scandir($directory) ?: [])->reject(function ($item) {
-            return is_dir($item) || ! ends_with($item, '.yml');
-        })->mapWithKeys(function ($file) use ($directory, $parseYaml) {
+        return collect(scandir($directory) ?: [])->reject(function($item) {
+            return is_dir($item) || !ends_with($item, '.yml');
+        })->mapWithKeys(function($file) use ($directory, $parseYaml) {
             return [$file => $this->loadFile($directory, $file, $parseYaml)];
         });
     }

src/Support/ResourceLoader.php

Spacing +11 added lines, -11 removed lines

@@ -33,8 +33,8 @@ 
     private function getEnabledResources($resources)
     {
         if (is_array($keys = config($configKey = 'health.resources_enabled'))) {
-            return collect($resources)->reject(function ($value, $key) use ($keys) {
-                return ! in_array($key, $keys);
+            return collect($resources)->reject(function($value, $key) use ($keys) {
+                return !in_array($key, $keys);
             });
         }
 
@@ -70,7 +70,7 @@ 
      */
     private function loadArray()
     {
-        return collect(config('health.resources'))->mapWithKeys(function ($value, $key) {
+        return collect(config('health.resources'))->mapWithKeys(function($value, $key) {
             return [studly_case($key) => $value];
         });
     }
@@ -84,9 +84,9 @@ 
     {
         $local = $this->yaml->loadYamlFromDir(config('health.resources_location.path'));
 
-        return $this->yaml->loadYamlFromDir(package_resources_dir())->reject(function ($item, $key) use ($local) {
+        return $this->yaml->loadYamlFromDir(package_resources_dir())->reject(function($item, $key) use ($local) {
             return $local->keys()->has($key);
-        })->merge($local)->mapWithKeys(function ($value, $key) {
+        })->merge($local)->mapWithKeys(function($value, $key) {
             return [$this->removeExtension($key) => $value];
         });
     }
@@ -144,7 +144,7 @@ 
      */
     protected function makeResourcesCollection()
     {
-        return collect($this->load())->map(function ($item, $key) {
+        return collect($this->load())->map(function($item, $key) {
             $item['slug'] = $key;
 
             $item['name'] = Str::studly($key);
@@ -189,8 +189,8 @@ 
      */
     private function sanitizeResources($resources)
     {
-        return $resources->map(function ($resource) {
-            return collect($resource)->mapWithKeys(function ($value, $key) {
+        return $resources->map(function($resource) {
+            return collect($resource)->mapWithKeys(function($value, $key) {
                 return [$this->sanitizeKey($key) => $value];
             });
         });
@@ -205,10 +205,10 @@ 
     protected function sortResources($resources)
     {
         if ($sortBy = config('health.sort_by')) {
-            $resources = $resources->sortBy(function ($item) use ($sortBy) {
+            $resources = $resources->sortBy(function($item) use ($sortBy) {
                 return $item['is_global']
-                    ? 0 .$item[$sortBy]
-                    : 1 .$item[$sortBy];
+                    ? 0.$item[$sortBy]
+                    : 1.$item[$sortBy];
             });
 
             return $resources;

src/Support/helpers.php

Doc Comments +1 added lines, -1 removed lines

@@ -56,7 +56,7 @@
      * Check if string is absolute path.
      *
      * @param $path
-     * @return string
+     * @return boolean
      */
     function is_absolute_path($path)
     {

Spacing +4 added lines, -4 removed lines

@@ -2,7 +2,7 @@ 
 
 use PragmaRX\Health\Service;
 
-if (! function_exists('instantiate')) {
+if (!function_exists('instantiate')) {
     /**
      * Instantiate a class.
      *
@@ -22,7 +22,7 @@ 
     }
 }
 
-if (! function_exists('package_dir')) {
+if (!function_exists('package_dir')) {
     /**
      * Get the package root directory.
      *
@@ -36,7 +36,7 @@ 
     }
 }
 
-if (! function_exists('package_resources_dir')) {
+if (!function_exists('package_resources_dir')) {
     /**
      * Get package resources directory.
      *
@@ -52,7 +52,7 @@ 
     }
 }
 
-if (! function_exists('is_absolute_path')) {
+if (!function_exists('is_absolute_path')) {
     /**
      * Check if string is absolute path.
      *

src/Checkers/DocusignChecker.php

Spacing +1 added lines, -1 removed lines

@@ -19,7 +19,7 @@
             return $this->makeResult(false, $this->resource['not_installed_message']);
         }
 
-        if (! $this->login()) {
+        if (!$this->login()) {
             throw new DomainException('Unable to authenticate to the DocuSign Api');
         }
 

tests/PhpUnit/Service/ServiceTest.php

Spacing +3 added lines, -3 removed lines

@@ -88,7 +88,7 @@ 
 
     public function testResourcesWhereChecked()
     {
-        $healthCount = $this->resources->reduce(function ($carry, $item) {
+        $healthCount = $this->resources->reduce(function($carry, $item) {
             return $carry + (isset($item['health']['healthy'])
                     ? 1
                     : 0);
@@ -97,7 +97,7 @@ 
         $this->assertEquals(count(static::ALL_RESOURCES), $healthCount);
 
         $failing = $this->resources
-            ->filter(function ($item) {
+            ->filter(function($item) {
                 return $item['health']['healthy'];
             });
 
@@ -123,7 +123,7 @@ 
     {
         $this->assertEquals(
             static::ALL_RESOURCES,
-            $this->resources->keys()->map(function ($value) {
+            $this->resources->keys()->map(function($value) {
                 return strtolower($value);
             })->toArray()
         );

src/ServiceProvider.php

Doc Comments +2 added lines, -2 removed lines

@@ -142,7 +142,7 @@ 
     /**
      * Get the resource checker closure for instantiation.
      *
-     * @param $resourceLoader
+     * @param ResourceLoader $resourceLoader
      * @param $cache
      * @return \Closure
      */
@@ -354,7 +354,7 @@ 
     /**
      * Get the services provided by the provider.
      *
-     * @return array
+     * @return string[]
      */
     public function provides()
     {

Spacing +12 added lines, -12 removed lines

@@ -96,7 +96,7 @@ 
 
         $cache = call_user_func($this->cacheClosure);
 
-        $this->healthServiceClosure = function () use ($resourceChecker, $cache) {
+        $this->healthServiceClosure = function() use ($resourceChecker, $cache) {
             return $this->instantiateService($resourceChecker, $cache);
         };
 
@@ -122,7 +122,7 @@ 
      */
     private function getCacheClosure()
     {
-        $cacheClosure = function () {
+        $cacheClosure = function() {
             return new Cache();
         };
 
@@ -148,7 +148,7 @@ 
      */
     private function getResourceCheckerClosure($resourceLoader, $cache)
     {
-        $resourceCheckerInstance = function () use ($resourceLoader, $cache) {
+        $resourceCheckerInstance = function() use ($resourceLoader, $cache) {
             return new ResourceChecker($resourceLoader, $cache);
         };
 
@@ -162,10 +162,10 @@ 
      */
     private function getRouter()
     {
-        if (! $this->router) {
+        if (!$this->router) {
             $this->router = $this->app->router;
 
-            if (! $this->router instanceof Router) {
+            if (!$this->router instanceof Router) {
                 $this->router = app()->router;
             }
         }
@@ -241,9 +241,9 @@ 
 
     private function registerResourcesRoutes()
     {
-        collect(config('health.resources'))->each(function ($item) {
+        collect(config('health.resources'))->each(function($item) {
             if (isset($item['routes'])) {
-                collect($item['routes'])->each(function ($route, $key) {
+                collect($item['routes'])->each(function($route, $key) {
                     $this->registerRoute($route, $key);
                 });
             }
@@ -257,19 +257,19 @@ 
     {
         $commands = $this->commands;
 
-        Artisan::command('health:panel', function () use ($commands) {
+        Artisan::command('health:panel', function() use ($commands) {
             $commands->panel($this);
         })->describe('Show all resources and their current health states.');
 
-        Artisan::command('health:check', function () use ($commands) {
+        Artisan::command('health:check', function() use ($commands) {
             $commands->check($this);
         })->describe('Check resources health and send error notifications.');
 
-        Artisan::command('health:export', function () use ($commands) {
+        Artisan::command('health:export', function() use ($commands) {
             $commands->export($this);
         })->describe('Export "array" resources to .yml files');
 
-        Artisan::command('health:publish', function () use ($commands) {
+        Artisan::command('health:publish', function() use ($commands) {
             $commands->publish($this);
         })->describe('Publish all .yml resouces files to config directory.');
     }
@@ -303,7 +303,7 @@ 
      */
     private function registerRoutes()
     {
-        collect($routes = $this->getRoutes())->each(function ($route) {
+        collect($routes = $this->getRoutes())->each(function($route) {
             $this->registerRoute($route);
         });
 

src/Service.php

Spacing +1 added lines, -1 removed lines

@@ -67,7 +67,7 @@
      */
     public function getSilentChecker()
     {
-        return function () {
+        return function() {
             $this->cache->flush();
 
             return $this->checkResources();