antonioribeiro / google2fa

src/Support/QRCode.php

<?php

namespace PragmaRX\Google2FA\Support;

trait QRCode
{
    /**
     * Creates a QR code url.
     *
     * @param string $company
     * @param string $holder
     * @param string $secret
     *
     * @return string
     */
    public function getQRCodeUrl($company, $holder, $secret)
    {
        return 'otpauth://totp/' .
            rawurlencode($company) .
            ':' .
            rawurlencode($holder) .
            '?secret=' .
            $secret .
            '&issuer=' .
            rawurlencode($company) .
            '&algorithm=' .
            rawurlencode(strtoupper($this->getAlgorithm())) .

It seems like getAlgorithm() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            '&digits=' .
            rawurlencode(strtoupper((string) $this->getOneTimePasswordLength())) .

It seems like getOneTimePasswordLength() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            '&period=' .
            rawurlencode(strtoupper((string) $this->getKeyRegeneration())) .

It seems like getKeyRegeneration() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            '';
    }
}