Input - Code Metrics - Inspection of "Merge style ci changes" - antonioribeiro/google2fa-laravel - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 5c8721...fc356f )

by Antonio Carlos

created 2017-06-20 05:36 UTC

Input A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	17
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes

Metric	Value
wmc	2
c	0
b	0
f	0
lcom	0
cbo	0
dl	0
loc	17
rs	10

2 Methods

Rating	Name	Duplication	Size	Complexity
A	inputHasOneTimePassword()	0	4	1
A	input()	0	4	1

<?php

namespace PragmaRX\Google2FALaravel\Support;

trait Input
{
    /**
     * Check if the request input has the OTP.
     *
     * @return mixed
     */
    protected function inputHasOneTimePassword()
    {
        return $this->getRequest()->has($this->config('otp_input'));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    public function input($var)
    {
        return $this->getRequest()->input($var);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }
}


1			<?php
2
3			namespace PragmaRX\Google2FALaravel\Support;
4
5			trait Input
6			{
7			/**
8			* Check if the request input has the OTP.
9			*
10			* @return mixed
11			*/
12			protected function inputHasOneTimePassword()
13			{
14			return $this->getRequest()->has($this->config('otp_input'));
			0 ignored issues – show Bug introduced 2017-06-20 05:38 UTC by Report Bug Copy Issue Report It seems like `getRequest()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history... Bug introduced 2017-06-20 05:38 UTC by Report Bug Copy Issue Report It seems like `config()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
15			}
16
17			public function input($var)
18			{
19			return $this->getRequest()->input($var);
			0 ignored issues – show Bug introduced 2017-06-20 05:38 UTC by Report Bug Copy Issue Report It seems like `getRequest()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
20			}
21			}
22

antonioribeiro / google2fa-laravel

Push — master ( 5c8721...fc356f )

Input A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

Duplication Side-by-Side

Filter issues like