Session::sessionGet() - Code Metrics - Inspection of "Merge pull request #2 from antonioribeiro/analysis..." - antonioribeiro/google2fa-laravel - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 671383...5c8721 )

by Antonio Carlos

created 2017-06-20 05:03 UTC

Session::sessionGet() A

↳ Parent: Session

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	6
rs	9.4285
cc	1
eloc	3
nc	1
nop	1

<?php

namespace PragmaRX\Google2FALaravel\Support;

trait Session
{
    /**
     * Make a session var name for.
     *
     * @param null $name
     *
     * @return mixed
     */
    protected function makeSessionVarName($name = null)
    {
        return $this->config('session_var').(is_null($name) || empty($name) ? '' : '.'.$name);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * Get a session var value.
     *
     * @param null $var
     *
     * @return mixed
     */
    public function sessionGet($var = null)
    {
        return $this->request->session()->get(
class MyClass { }

$x = new MyClass();
$x->foo = true;
            $this->makeSessionVarName($var)
        );
    }

    /**
     * Put a var value to the current session.
     *
     * @param $var
     * @param $value
     *
     * @return mixed
     */
    protected function sessionPut($var, $value)
    {
        $this->request->session()->put(
            $this->makeSessionVarName($var),
            $value
        );

        return $value;
    }

    /**
     * Forget a session var.
     *
     * @param null $var
     */
    protected function sessionForget($var = null)
    {
        $this->request->session()->forget(
            $this->makeSessionVarName($var)
        );
    }
}


1			<?php
2
3			namespace PragmaRX\Google2FALaravel\Support;
4
5			trait Session
6			{
7			/**
8			* Make a session var name for.
9			*
10			* @param null $name
11			*
12			* @return mixed
13			*/
14			protected function makeSessionVarName($name = null)
15			{
16			return $this->config('session_var').(is_null($name) \|\| empty($name) ? '' : '.'.$name);
			0 ignored issues – show Bug introduced 2017-06-20 05:05 UTC by Report Bug Copy Issue Report It seems like `config()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
17			}
18
19			/**
20			* Get a session var value.
21			*
22			* @param null $var
23			*
24			* @return mixed
25			*/
26			public function sessionGet($var = null)
27			{
28			return $this->request->session()->get(
			0 ignored issues – show Bug introduced 2017-06-20 05:05 UTC by Report Bug Copy Issue Report The property `request` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
29			$this->makeSessionVarName($var)
30			);
31			}
32
33			/**
34			* Put a var value to the current session.
35			*
36			* @param $var
37			* @param $value
38			*
39			* @return mixed
40			*/
41			protected function sessionPut($var, $value)
42			{
43			$this->request->session()->put(
44			$this->makeSessionVarName($var),
45			$value
46			);
47
48			return $value;
49			}
50
51			/**
52			* Forget a session var.
53			*
54			* @param null $var
55			*/
56			protected function sessionForget($var = null)
57			{
58			$this->request->session()->forget(
59			$this->makeSessionVarName($var)
60			);
61			}
62			}
63

antonioribeiro / google2fa-laravel

Push — master ( 671383...5c8721 )

Session::sessionGet() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like