Clear::fire() - Code Metrics - Inspection of "Refactor artisan commands" - antonioribeiro/firewall - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 6bfad1...b9baef )

by Antonio Carlos

created 2017-09-03 21:38 UTC

Clear::fire() A

↳ Parent: Clear

Complexity

Conditions	3
Paths	3

Size

Total Lines	9
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	3
eloc	7
nc	3
nop	0
dl	0
loc	9
rs	9.6666
c	0
b	0
f	0

<?php

namespace PragmaRX\Firewall\Vendor\Laravel\Artisan;

use Symfony\Component\Console\Input\InputOption;

class Clear extends Base
{
    /**
     * The console command name.
     *
     * @var string
     */
    protected $name = 'firewall:clear';

    /**
     * The console command description.
     *
     * @var string
     */
    protected $description = 'Remove all ip addresses from white and black lists.';

    /**
     * Execute the console command.
     *
     * @return mixed
     */
    public function fire()
    {
        if (!$this->option('force')) {
            $this->error('This command won\'t run unless you use --force.');
        } else {
            if ($this->laravel->firewall->clear()) {

                $this->info('List cleared.');
            } else {
                $this->info('There were no IP addresses to be deleted.');
            }
        }
    }

    /**
     * Get the console command options.
     *
     * @return array
     */
    protected function getOptions()
    {
        return [
            ['force', null, InputOption::VALUE_NONE, 'Remove IP before adding it to the list.'],
        ];
    }
}


1			<?php
2
3			namespace PragmaRX\Firewall\Vendor\Laravel\Artisan;
4
5			use Symfony\Component\Console\Input\InputOption;
6
7			class Clear extends Base
8			{
9			/**
10			* The console command name.
11			*
12			* @var string
13			*/
14			protected $name = 'firewall:clear';
15
16			/**
17			* The console command description.
18			*
19			* @var string
20			*/
21			protected $description = 'Remove all ip addresses from white and black lists.';
22
23			/**
24			* Execute the console command.
25			*
26			* @return mixed
27			*/
28			public function fire()
29			{
30			if (!$this->option('force')) {
31			$this->error('This command won\'t run unless you use --force.');
32			} else {
33			if ($this->laravel->firewall->clear()) {
			0 ignored issues – show Bug introduced 2017-09-03 16:43 UTC by Report Bug Copy Issue Report Accessing `firewall` on the interface `Illuminate\Contracts\Foundation\Application` suggest that you code against a concrete implementation. How about adding an `instanceof` check? Loading history...
34			$this->info('List cleared.');
35			} else {
36			$this->info('There were no IP addresses to be deleted.');
37			}
38			}
39			}
40
41			/**
42			* Get the console command options.
43			*
44			* @return array
45			*/
46			protected function getOptions()
47			{
48			return [
49			['force', null, InputOption::VALUE_NONE, 'Remove IP before adding it to the list.'],
50			];
51			}
52			}
53

antonioribeiro / firewall

Push — master ( 6bfad1...b9baef )

Clear::fire() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like