PragmaRX\Firewall\Vendor\Laravel\Artisan\Base

Complexity

Total Complexity

5

Size/Duplication

Total Lines	21
Duplicated Lines	0 %

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	displayMessages()	0	4	2
A	handle()	0	3	1
A	fireCommand()	0	7	2

<?php

namespace PragmaRX\Firewall\Vendor\Laravel\Artisan;

use Illuminate\Console\Command;

abstract class Base extends Command
{
    public function displayMessages($type, $messages)
    {
        foreach ($messages as $message) {
            $this->$type($message);
        }
    }

    public function handle()
    {
        $this->fire();

The method fire() does not exist on PragmaRX\Firewall\Vendor\Laravel\Artisan\Base. Since it exists in all sub-types, consider adding an abstract or default implementation to PragmaRX\Firewall\Vendor\Laravel\Artisan\Base.

    }

    public function fireCommand($method, $parameters)
    {
        $type = call_user_func_array ( [$this->laravel->firewall, $method], $parameters)

Accessing firewall on the interface Illuminate\Contracts\Foundation\Application suggest that you code against a concrete implementation. How about adding an instanceof check?

            ? 'info'
            : 'error';

        $this->displayMessages($type, $this->laravel->firewall->getMessages());
    }
}